From: Mark Rutland <mark.rutland@arm.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: catalin.marinas@arm.com, will@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: Support CMDLINE_EXTEND
Date: Tue, 21 Mar 2023 11:19:55 +0000 [thread overview]
Message-ID: <ZBmS28ciIei5sKHY@FVFF77S0Q05N> (raw)
In-Reply-To: <20230320211451.2512800-1-chris.packham@alliedtelesis.co.nz>
On Tue, Mar 21, 2023 at 10:14:51AM +1300, Chris Packham wrote:
> Support extending the bootloader provided command line for arm64
> targets. This support is already present via generic DT/EFI code the
> only thing required is for the architecture to make it selectable.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
We deliberately dropped support for CMDLINE_EXTEND in commit:
cae118b6acc3 ("arm64: Drop support for CMDLINE_EXTEND")
... which was mentioned the last time somone tried to re-add it:
https://lore.kernel.org/linux-arm-kernel/ZAh8dWvbNkVQT11C@arm.com/
Has something changes such that those issues no longer apply? If so, please
call that out explicitly in the commit message. If not, I do not think we
should take this patch.
Thanks,
Mark.
> ---
> arch/arm64/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1023e896d46b..3c837b085f21 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -2228,6 +2228,12 @@ config CMDLINE_FROM_BOOTLOADER
> the boot loader doesn't provide any, the default kernel command
> string provided in CMDLINE will be used.
>
> +config CMDLINE_EXTEND
> + bool "Extend bootloader kernel arguments"
> + help
> + The command-line arguments provided by the boot loader will be
> + appended to the default kernel command string.
> +
> config CMDLINE_FORCE
> bool "Always use the default kernel command string"
> help
> --
> 2.40.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-21 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 21:14 [PATCH] arm64: Support CMDLINE_EXTEND Chris Packham
2023-03-21 3:54 ` Anshuman Khandual
2023-03-21 4:15 ` Chris Packham
2023-03-21 10:45 ` Anshuman Khandual
2023-03-21 11:19 ` Mark Rutland [this message]
2023-03-21 19:06 ` Mark Brown
2023-03-21 20:16 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBmS28ciIei5sKHY@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox