From: Cristian Marussi <cristian.marussi@arm.com>
To: Tejun Heo <tj@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation
Date: Fri, 21 Apr 2023 09:46:11 +0100 [thread overview]
Message-ID: <ZEJNU1om5IhQHB2J@e120937-lin> (raw)
In-Reply-To: <ZEGTnajiQm7mkkZS@slm.duckdns.org>
On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote:
> scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active.
> Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs
> interface and using 0 for @max_active for the default setting.
>
Hi Tejun,
my bad I messed up the params in the call.
LGTM.
Thanks,
Cristian
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/firmware/arm_scmi/raw_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/firmware/arm_scmi/raw_mode.c
> +++ b/drivers/firmware/arm_scmi/raw_mode.c
> @@ -1066,7 +1066,7 @@ static int scmi_xfer_raw_worker_init(str
>
> raw->wait_wq = alloc_workqueue("scmi-raw-wait-wq-%d",
> WQ_UNBOUND | WQ_FREEZABLE |
> - WQ_HIGHPRI, WQ_SYSFS, raw->id);
> + WQ_HIGHPRI | WQ_SYSFS, 0, raw->id);
> if (!raw->wait_wq)
> return -ENOMEM;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-21 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 19:33 [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue() invocation Tejun Heo
2023-04-21 8:46 ` Cristian Marussi [this message]
2023-04-21 9:27 ` Sudeep Holla
2023-04-21 9:38 ` Cristian Marussi
2023-04-21 9:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEJNU1om5IhQHB2J@e120937-lin \
--to=cristian.marussi@arm.com \
--cc=kernel-team@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox