* [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed
@ 2023-08-01 8:48 Alexander Stein
2023-08-11 8:20 ` Vinod Koul
2023-08-17 9:55 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2023-08-01 8:48 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-phy, linux-arm-kernel
This adds an error message if getting vbus failed for some reason,
-EPROBE_DEFER is handled appropriately as well and adds a nice
information to debugfs.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
index c1a57541fbb3..3af007b8e77f 100644
--- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
+++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
@@ -399,7 +399,7 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
if (PTR_ERR(imx_phy->vbus) == -ENODEV)
imx_phy->vbus = NULL;
else if (IS_ERR(imx_phy->vbus))
- return PTR_ERR(imx_phy->vbus);
+ return dev_err_probe(dev, PTR_ERR(imx_phy->vbus), "failed to get vbus\n");
phy_set_drvdata(imx_phy->phy, imx_phy);
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed
2023-08-01 8:48 [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed Alexander Stein
@ 2023-08-11 8:20 ` Vinod Koul
2023-08-17 9:55 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-08-11 8:20 UTC (permalink / raw)
To: Alexander Stein
Cc: Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, linux-phy,
linux-arm-kernel
On 01-08-23, 10:48, Alexander Stein wrote:
> This adds an error message if getting vbus failed for some reason,
> -EPROBE_DEFER is handled appropriately as well and adds a nice
> information to debugfs.
Fails to apply on phy/next
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> index c1a57541fbb3..3af007b8e77f 100644
> --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c
> @@ -399,7 +399,7 @@ static int imx8mq_usb_phy_probe(struct platform_device *pdev)
> if (PTR_ERR(imx_phy->vbus) == -ENODEV)
> imx_phy->vbus = NULL;
> else if (IS_ERR(imx_phy->vbus))
> - return PTR_ERR(imx_phy->vbus);
> + return dev_err_probe(dev, PTR_ERR(imx_phy->vbus), "failed to get vbus\n");
>
> phy_set_drvdata(imx_phy->phy, imx_phy);
>
> --
> 2.34.1
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed
2023-08-01 8:48 [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed Alexander Stein
2023-08-11 8:20 ` Vinod Koul
@ 2023-08-17 9:55 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2023-08-17 9:55 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Shawn Guo, Sascha Hauer, Fabio Estevam,
Alexander Stein
Cc: Pengutronix Kernel Team, NXP Linux Team, linux-phy,
linux-arm-kernel
On Tue, 01 Aug 2023 10:48:07 +0200, Alexander Stein wrote:
> This adds an error message if getting vbus failed for some reason,
> -EPROBE_DEFER is handled appropriately as well and adds a nice
> information to debugfs.
>
>
Applied, thanks!
[1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed
commit: a11ecceaf41d2dd542228007940652fea7532276
Best regards,
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-17 9:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 8:48 [PATCH 1/1] phy: fsl-imx8mq-usb: add dev_err_probe if getting vbus failed Alexander Stein
2023-08-11 8:20 ` Vinod Koul
2023-08-17 9:55 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox