From: Wolfram Sang <wsa@kernel.org>
To: Daniel Scally <dan.scally@ideasonboard.com>
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Subject: Re: [PATCH] i2c: xiic: Correct return value check for xiic_reinit()
Date: Fri, 22 Sep 2023 12:07:30 +0200 [thread overview]
Message-ID: <ZQ1nYkSe+e/D2c7s@shikoro> (raw)
In-Reply-To: <20230920134109.2232769-1-dan.scally@ideasonboard.com>
[-- Attachment #1.1: Type: text/plain, Size: 473 bytes --]
On Wed, Sep 20, 2023 at 02:41:09PM +0100, Daniel Scally wrote:
> The error paths for xiic_reinit() return negative values on failure
> and 0 on success - this error message therefore is triggered on
> _success_ rather than failure. Correct the condition so it's only
> shown on failure as intended.
>
> Fixes: 8fa9c9388053 ("i2c: xiic: return value of xiic_reinit")
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
Applied to for-current, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-09-22 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 13:41 [PATCH] i2c: xiic: Correct return value check for xiic_reinit() Daniel Scally
2023-09-21 12:13 ` Michal Simek
2023-09-21 21:30 ` Andi Shyti
2023-09-22 10:07 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQ1nYkSe+e/D2c7s@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=raviteja.narayanam@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox