From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY
Date: Wed, 27 Sep 2023 10:48:28 +0000 [thread overview]
Message-ID: <ZRQIfC67fDmOUBNY@kekkonen.localdomain> (raw)
In-Reply-To: <20230927040438.5589-1-rdunlap@infradead.org>
Hi Randy,
Thanks for the patch.
On Tue, Sep 26, 2023 at 09:04:38PM -0700, Randy Dunlap wrote:
> When selecting GENERIC_PHY_MIPI_DPHY, also select GENERIC_PHY to
> prevent kconfig warnings:
>
> WARNING: unmet direct dependencies detected for GENERIC_PHY_MIPI_DPHY
> Depends on [n]: GENERIC_PHY [=n]
> Selected by [y]:
> - VIDEO_SUN8I_A83T_MIPI_CSI2 [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && VIDEO_DEV [=y] && (ARCH_SUNXI || COMPILE_TEST [=y]) && PM [=y] && COMMON_CLK [=y] && RESET_CONTROLLER [=y]
>
> Fixes: 94d7fd9692b5 ("media: sunxi: Depend on GENERIC_PHY_MIPI_DPHY")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: lore.kernel.org/r/ZQ/WS8HC1A3F0Qn8@rli9-mobl
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-sunxi@lists.linux.dev
> ---
> drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> --- a/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> +++ b/drivers/media/platform/sunxi/sun8i-a83t-mipi-csi2/Kconfig
> @@ -8,6 +8,7 @@ config VIDEO_SUN8I_A83T_MIPI_CSI2
> select VIDEO_V4L2_SUBDEV_API
> select V4L2_FWNODE
> select REGMAP_MMIO
> + select GENERIC_PHY
Could GENERIC_PHY_MIPI_DPHY select GENERIC_PHY instead of depending it?
There seem to be a few other drivers that appear to have the same issue.
> select GENERIC_PHY_MIPI_DPHY
> help
> Support for the Allwinner A83T MIPI CSI-2 controller and D-PHY.
--
Regards,
Sakari Ailus
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-27 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 4:04 [PATCH] media: sunxi: a83-mips-csi2: also select GENERIC_PHY Randy Dunlap
2023-09-27 10:48 ` Sakari Ailus [this message]
2023-10-01 2:20 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRQIfC67fDmOUBNY@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=arnd@arndb.de \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=lkp@intel.com \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox