From: Mark Rutland <mark.rutland@arm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will@kernel.org, suzuki.poulose@arm.com,
anshuman.khandual@arm.com, shan.gavin@gmail.com
Subject: Re: [PATCH] arm64: Remove system_uses_lse_atomics()
Date: Tue, 17 Oct 2023 11:35:44 +0100 [thread overview]
Message-ID: <ZS5jgCNm8jV9E8Ao@FVFF77S0Q05N> (raw)
In-Reply-To: <20231017005036.334067-1-gshan@redhat.com>
On Tue, Oct 17, 2023 at 10:50:36AM +1000, Gavin Shan wrote:
> There are two variants of system_uses_lse_atomics(), depending on
> CONFIG_ARM64_LSE_ATOMICS. The function isn't called anywhere when
> CONFIG_ARM64_LSE_ATOMICS is disabled. It can be directly replaced
> by alternative_has_cap_likely(ARM64_HAS_LSE_ATOMICS) when the kernel
> option is enabled.
>
> No need to keep system_uses_lse_atomics() and just remove it.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
I had meant to remove this already, so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
> ---
> arch/arm64/include/asm/lse.h | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/arm64/include/asm/lse.h b/arch/arm64/include/asm/lse.h
> index cbbcdc35c4cd..3129a5819d0e 100644
> --- a/arch/arm64/include/asm/lse.h
> +++ b/arch/arm64/include/asm/lse.h
> @@ -16,14 +16,9 @@
> #include <asm/atomic_lse.h>
> #include <asm/cpucaps.h>
>
> -static __always_inline bool system_uses_lse_atomics(void)
> -{
> - return alternative_has_cap_likely(ARM64_HAS_LSE_ATOMICS);
> -}
> -
> #define __lse_ll_sc_body(op, ...) \
> ({ \
> - system_uses_lse_atomics() ? \
> + alternative_has_cap_likely(ARM64_HAS_LSE_ATOMICS) ? \
> __lse_##op(__VA_ARGS__) : \
> __ll_sc_##op(__VA_ARGS__); \
> })
> @@ -34,8 +29,6 @@ static __always_inline bool system_uses_lse_atomics(void)
>
> #else /* CONFIG_ARM64_LSE_ATOMICS */
>
> -static inline bool system_uses_lse_atomics(void) { return false; }
> -
> #define __lse_ll_sc_body(op, ...) __ll_sc_##op(__VA_ARGS__)
>
> #define ARM64_LSE_ATOMIC_INSN(llsc, lse) llsc
> --
> 2.41.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-17 10:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 0:50 [PATCH] arm64: Remove system_uses_lse_atomics() Gavin Shan
2023-10-17 10:35 ` Mark Rutland [this message]
2023-10-18 10:15 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZS5jgCNm8jV9E8Ao@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shan.gavin@gmail.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox