public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: "xinglong.yang" <seanyang230@gmail.com>
Cc: xinglong.yang@cixtech.com, sudeep.holla@arm.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
Date: Thu, 2 Nov 2023 11:25:27 +0000	[thread overview]
Message-ID: <ZUOHJzRf3_n0a15w@pluto> (raw)
In-Reply-To: <20231101081726.1163042-1-xinglong.yang@cixtech.com>

On Wed, Nov 01, 2023 at 04:17:26PM +0800, xinglong.yang wrote:
> The platform may not support fastchannel, but this is a legal
> operation.
> 
>         -Before this patch, when the platform not support fastchannel,
>         goto err_xfer will print "Failed to ...". This log is misleading.
> 
>         -With this patch, when the fastchannel is not been supported,
>         the "Failed to ..." log will be skipped.
> 

Hi,

the message that you are killing:

 dev_warn(ph->dev,
	  "Failed to get FC for protocol %X [MSG_ID:%u / RES_ID:%u] - ret:%d. Using regular messaging.\n",

despite not being an error indeed, informs the user that some FCs could not be
configured and we will revet to use full messaging...it can help detect an
anomaly IMO.

So I would NOT kill it at all and just drop this patch and instead change the
dev_warn to dev_info and used a different wording instead of "Failed..." like

	  "Cannot configure FC for protocol %X [MSG_ID:%u / RES_ID:%u] - ret:%d. Using regular messaging.\n",

Thanks,
Cristian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-11-02 11:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-01  8:17 [PATCH] firmware: arm_scmi: Remove inappropriate error log xinglong.yang
2023-11-02  9:55 ` Fwd: " sean yang
2023-11-02 11:08   ` Sudeep Holla
2023-11-02 11:16 ` Sudeep Holla
2023-11-02 11:25 ` Cristian Marussi [this message]
2023-11-02 11:42   ` sean yang
  -- strict thread matches above, loose matches on Subject: below --
2023-11-01  8:10 xinglong.yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZUOHJzRf3_n0a15w@pluto \
    --to=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=seanyang230@gmail.com \
    --cc=sudeep.holla@arm.com \
    --cc=xinglong.yang@cixtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox