public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, will@kernel.org,
	catalin.marinas@arm.com, James Clark <james.clark@arm.com>,
	Rob Herring <robh@kernel.org>, Marc Zyngier <maz@kernel.org>,
	Suzuki Poulose <suzuki.poulose@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH V16 1/8] arm64/sysreg: Add BRBE registers and fields
Date: Wed, 21 Feb 2024 14:05:24 +0000	[thread overview]
Message-ID: <ZdYDJPe1n5-V-AnT@FVFF77S0Q05N> (raw)
In-Reply-To: <e89ecbde-0967-4b8e-af77-3a72f207f3d7@sirena.org.uk>

On Wed, Feb 21, 2024 at 01:59:03PM +0000, Mark Brown wrote:
> On Wed, Feb 21, 2024 at 01:52:38PM +0000, Mark Rutland wrote:
> > On Thu, Jan 25, 2024 at 03:11:12PM +0530, Anshuman Khandual wrote:
> 
> > Minor nit, but could we please list thse in order:
> 
> > 	BRBCR_EL1
> > 	BRBCR_EL12
> > 	BRBCR_EL2
> 
> > ... since that way the names are ordered alphnumerically, which is what we've
> > done for other groups (e.g. PIR_EL{1,12,2}), and it's the way the ARM ARM
> > happens to be ordered.
> 
> It's a good point about the sorting, though the file is currently mostly
> sorted by encoding rather than alphanumerically (similarly to how
> sysreg.h was done).

Sure, we're inconsistent. I'd just prefer that there's *some* local ordering
here, as the patch is neither ordered as above nor by encoding:

Sysreg       BRBCR_EL2       2       4       9       0       0
...
Sysreg       BRBCR_EL1       2       1       9       0       0
...
Sysreg       BRBCR_EL12      2       5       9       0       0

Mark.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-02-21 14:05 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  9:41 [PATCH V16 0/8] arm64/perf: Enable branch stack sampling Anshuman Khandual
2024-01-25  9:41 ` [PATCH V16 1/8] arm64/sysreg: Add BRBE registers and fields Anshuman Khandual
2024-01-25 14:20   ` Mark Brown
2024-02-21 13:52   ` Mark Rutland
2024-02-21 13:59     ` Mark Brown
2024-02-21 14:05       ` Mark Rutland [this message]
2024-02-21 14:07         ` Mark Brown
2024-02-23  5:28           ` Anshuman Khandual
2024-02-23 13:31             ` Mark Brown
2024-02-23  6:36     ` Anshuman Khandual
2024-02-26  4:22   ` [PATCH] arm64/hw_breakpoint: Determine lengths from generic perf breakpoint macros Anshuman Khandual
2024-02-26  4:26     ` Anshuman Khandual
2024-02-26  4:24   ` [PATCH] arm64/sysreg: Add BRBE registers and fields Anshuman Khandual
2024-02-26 13:18     ` Mark Brown
2024-02-27 10:06     ` Mark Rutland
2024-01-25  9:41 ` [PATCH V16 2/8] KVM: arm64: Prevent guest accesses into BRBE system registers/instructions Anshuman Khandual
2024-01-29 12:15   ` Suzuki K Poulose
2024-01-30  3:40     ` Anshuman Khandual
2024-02-21 14:01   ` Mark Rutland
2024-02-23  7:28     ` Anshuman Khandual
2024-02-27 10:04       ` Mark Rutland
2024-02-27 11:13         ` Anshuman Khandual
2024-02-29 11:45           ` Suzuki K Poulose
2024-02-29 12:50             ` Mark Rutland
2024-02-29 15:43               ` Suzuki K Poulose
2024-03-01  7:46               ` Anshuman Khandual
2024-03-01 12:49                 ` Mark Rutland
2024-01-25  9:41 ` [PATCH V16 3/8] drivers: perf: arm_pmuv3: Enable branch stack sampling framework Anshuman Khandual
2024-01-25 13:44   ` Suzuki K Poulose
2024-01-29  4:35     ` Anshuman Khandual
2024-02-21 17:25   ` Mark Rutland
2024-03-01  5:37     ` Anshuman Khandual
2024-03-01 13:52       ` Mark Rutland
2024-01-25  9:41 ` [PATCH V16 4/8] drivers: perf: arm_pmuv3: Enable branch stack sampling via FEAT_BRBE Anshuman Khandual
2024-02-21 18:23   ` Mark Rutland
2024-02-28  8:11     ` Anshuman Khandual
2024-02-28 11:52       ` Mark Rutland
2024-02-29  8:55         ` Anshuman Khandual
2024-02-29 11:49   ` [PATCH] arm64/boot: Enable EL2 requirements for BRBE Anshuman Khandual
2024-01-25  9:41 ` [PATCH V16 5/8] KVM: arm64: nvhe: Disable branch generation in nVHE guests Anshuman Khandual
2024-01-29 12:20   ` Suzuki K Poulose
2024-01-30  3:41     ` Anshuman Khandual
2024-02-29 18:40   ` Marc Zyngier
2024-03-01  2:20     ` Anshuman Khandual
2024-01-25  9:41 ` [PATCH V16 6/8] perf: test: Speed up running brstack test on an Arm model Anshuman Khandual
2024-01-25  9:41 ` [PATCH V16 7/8] perf: test: Remove empty lines from branch filter test output Anshuman Khandual
2024-01-25  9:41 ` [PATCH V16 8/8] perf: test: Extend branch stack sampling test for Arm64 BRBE Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZdYDJPe1n5-V-AnT@FVFF77S0Q05N \
    --to=mark.rutland@arm.com \
    --cc=acme@kernel.org \
    --cc=anshuman.khandual@arm.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.clark@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox