From: Stanislav Jakubek <stano.jakubek@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)
Date: Mon, 25 Mar 2024 21:25:04 +0100 [thread overview]
Message-ID: <ZgHdoK6luxRcKgRx@standask-GA-A55M-S2HP> (raw)
In-Reply-To: <ffa93b4a-608a-4cf5-b111-0d1f8520afdd@linaro.org>
On Mon, Mar 25, 2024 at 08:28:27PM +0100, Konrad Dybcio wrote:
> On 24.03.2024 3:04 PM, Stanislav Jakubek wrote:
> > Add a device tree for the Motorola Moto G (2013) smartphone based
> > on the Qualcomm MSM8226 SoC.
> >
> > Initially supported features:
> > - Buttons (Volume Down/Up, Power)
> > - eMMC
> > - Hall Effect Sensor
> > - SimpleFB display
> > - TMP108 temperature sensor
> > - Vibrator
> >
> > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com>
> > ---
>
> [...]
>
> > + hob-ram@f500000 {
> > + reg = <0x0f500000 0x40000>,
> > + <0x0f540000 0x2000>;
> > + no-map;
> > + };
>
> Any reason it's in two parts? Should it be one contiguous region, or
> two separate nodes?
>
> lgtm otherwise
Hi Konrad, I copied this from downstream as-is.
According to the downstream docs [1]:
HOB RAM MMAP Device provides ability for userspace to access the
hand over block memory to read out modem related parameters.
And the two regs are the "DHOB partition" and "SHOB partition".
I suppose this is something Motorola (firmware?) specific (since the
downstream compatible is mmi,hob_ram [2]).
Should I split this into 2 nodes - dhob@f500000 and shob@f540000?
Stanislav
[1] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/Documentation/devicetree/bindings/misc/hob_ram.txt
[2] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/arch/arm/boot/dts/msm8226-moto-common.dtsi#L258
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-25 20:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 14:03 [PATCH 1/2] dt-bindings: arm: qcom: Add Motorola Moto G (2013) Stanislav Jakubek
2024-03-24 14:04 ` [PATCH 2/2] ARM: dts: qcom: Add support for " Stanislav Jakubek
2024-03-25 19:28 ` Konrad Dybcio
2024-03-25 20:25 ` Stanislav Jakubek [this message]
2024-03-26 10:10 ` Konrad Dybcio
2024-03-25 12:18 ` [PATCH 1/2] dt-bindings: arm: qcom: Add " Krzysztof Kozlowski
2024-03-25 13:55 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgHdoK6luxRcKgRx@standask-GA-A55M-S2HP \
--to=stano.jakubek@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox