From: Sudeep Holla <sudeep.holla@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: cristian.marussi@arm.com, linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] firmware: arm_scmi: power_control: support suspend command
Date: Tue, 16 Apr 2024 10:14:04 +0100 [thread overview]
Message-ID: <Zh5BXAuLKM1uUOyD@bogus> (raw)
In-Reply-To: <20240415101141.1591112-1-peng.fan@oss.nxp.com>
On Mon, Apr 15, 2024 at 06:11:41PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Support System suspend notification. Using a work struct to call
> pm_suspend. There is no way to pass suspend level to pm_suspend,
> so use MEM as of now.
>
While the change itself is simple and no-controversial, I am bit worried
about:
1. The choice of S2R(MEM) by default - not sure if different system
prefer different things. The userspace can configure whatever default
behaviour expected as S2R IIUC, so should be OK. I need to check though.
2. The userspace needs to keep the wakeup source enabled always which
I need to check if it is feasible on all the platforms. If wakeups
are not configured properly and suspend is triggered, the system can
never resume back.
We may need to mention above points at-least as part of commit log. I
would wait for some feedback from SCMI users.
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-16 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 10:11 [PATCH] firmware: arm_scmi: power_control: support suspend command Peng Fan (OSS)
2024-04-15 20:45 ` Cristian Marussi
2024-04-16 7:01 ` Peng Fan
2024-04-16 10:15 ` Cristian Marussi
2024-04-16 12:34 ` Peng Fan
2024-04-16 13:24 ` Cristian Marussi
2024-04-16 13:28 ` Peng Fan
2024-04-16 9:14 ` Sudeep Holla [this message]
2024-04-16 12:26 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh5BXAuLKM1uUOyD@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox