* [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP
@ 2024-05-14 13:18 Peng Fan (OSS)
2024-05-31 13:40 ` Peng Fan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peng Fan (OSS) @ 2024-05-14 13:18 UTC (permalink / raw)
To: sudeep.holla, cristian.marussi, ulf.hansson
Cc: linux-arm-kernel, linux-kernel, linux-pm, Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Set flag GENPD_FLAG_ACTIVE_WAKEUP to scmi genpd, then when a device
is set as wakeup source using device_set_wakeup_enable, the power
domain could be kept on to make sure the device could wakeup the system.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
drivers/pmdomain/arm/scmi_pm_domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pmdomain/arm/scmi_pm_domain.c b/drivers/pmdomain/arm/scmi_pm_domain.c
index 0e05a79de82d..a7784a8bb5db 100644
--- a/drivers/pmdomain/arm/scmi_pm_domain.c
+++ b/drivers/pmdomain/arm/scmi_pm_domain.c
@@ -102,6 +102,7 @@ static int scmi_pm_domain_probe(struct scmi_device *sdev)
scmi_pd->genpd.name = scmi_pd->name;
scmi_pd->genpd.power_off = scmi_pd_power_off;
scmi_pd->genpd.power_on = scmi_pd_power_on;
+ scmi_pd->genpd.flags = GENPD_FLAG_ACTIVE_WAKEUP;
pm_genpd_init(&scmi_pd->genpd, NULL,
state == SCMI_POWER_STATE_GENERIC_OFF);
--
2.37.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP
2024-05-14 13:18 [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP Peng Fan (OSS)
@ 2024-05-31 13:40 ` Peng Fan
2024-06-03 13:19 ` Sudeep Holla
2024-06-05 9:57 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2024-05-31 13:40 UTC (permalink / raw)
To: Peng Fan (OSS), sudeep.holla@arm.com, cristian.marussi@arm.com,
ulf.hansson@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
> Subject: [PATCH] pmdomain: arm: scmi_pm_domain: set flag
> GENPD_FLAG_ACTIVE_WAKEUP
Ping..
Thanks,
Peng.
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Set flag GENPD_FLAG_ACTIVE_WAKEUP to scmi genpd, then when a device is
> set as wakeup source using device_set_wakeup_enable, the power domain
> could be kept on to make sure the device could wakeup the system.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/pmdomain/arm/scmi_pm_domain.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/arm/scmi_pm_domain.c
> b/drivers/pmdomain/arm/scmi_pm_domain.c
> index 0e05a79de82d..a7784a8bb5db 100644
> --- a/drivers/pmdomain/arm/scmi_pm_domain.c
> +++ b/drivers/pmdomain/arm/scmi_pm_domain.c
> @@ -102,6 +102,7 @@ static int scmi_pm_domain_probe(struct
> scmi_device *sdev)
> scmi_pd->genpd.name = scmi_pd->name;
> scmi_pd->genpd.power_off = scmi_pd_power_off;
> scmi_pd->genpd.power_on = scmi_pd_power_on;
> + scmi_pd->genpd.flags = GENPD_FLAG_ACTIVE_WAKEUP;
>
> pm_genpd_init(&scmi_pd->genpd, NULL,
> state == SCMI_POWER_STATE_GENERIC_OFF);
> --
> 2.37.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP
2024-05-14 13:18 [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP Peng Fan (OSS)
2024-05-31 13:40 ` Peng Fan
@ 2024-06-03 13:19 ` Sudeep Holla
2024-06-05 9:57 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Sudeep Holla @ 2024-06-03 13:19 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: cristian.marussi, ulf.hansson, Sudeep Holla, linux-arm-kernel,
linux-kernel, linux-pm, Peng Fan
On Tue, May 14, 2024 at 09:18:33PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Set flag GENPD_FLAG_ACTIVE_WAKEUP to scmi genpd, then when a device
> is set as wakeup source using device_set_wakeup_enable, the power
> domain could be kept on to make sure the device could wakeup the system.
>
I am fine with the change, wonder if it can be made conditional but I can't
think of a sane way to do so. If Ulf thinks it is harmless to keep it
unconditional on all the domains, then I am fine with that.
I assume Ulf can pick this up directly,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP
2024-05-14 13:18 [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP Peng Fan (OSS)
2024-05-31 13:40 ` Peng Fan
2024-06-03 13:19 ` Sudeep Holla
@ 2024-06-05 9:57 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2024-06-05 9:57 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: sudeep.holla, cristian.marussi, linux-arm-kernel, linux-kernel,
linux-pm, Peng Fan
On Tue, 14 May 2024 at 15:10, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Set flag GENPD_FLAG_ACTIVE_WAKEUP to scmi genpd, then when a device
> is set as wakeup source using device_set_wakeup_enable, the power
> domain could be kept on to make sure the device could wakeup the system.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/arm/scmi_pm_domain.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pmdomain/arm/scmi_pm_domain.c b/drivers/pmdomain/arm/scmi_pm_domain.c
> index 0e05a79de82d..a7784a8bb5db 100644
> --- a/drivers/pmdomain/arm/scmi_pm_domain.c
> +++ b/drivers/pmdomain/arm/scmi_pm_domain.c
> @@ -102,6 +102,7 @@ static int scmi_pm_domain_probe(struct scmi_device *sdev)
> scmi_pd->genpd.name = scmi_pd->name;
> scmi_pd->genpd.power_off = scmi_pd_power_off;
> scmi_pd->genpd.power_on = scmi_pd_power_on;
> + scmi_pd->genpd.flags = GENPD_FLAG_ACTIVE_WAKEUP;
>
> pm_genpd_init(&scmi_pd->genpd, NULL,
> state == SCMI_POWER_STATE_GENERIC_OFF);
> --
> 2.37.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-05 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-14 13:18 [PATCH] pmdomain: arm: scmi_pm_domain: set flag GENPD_FLAG_ACTIVE_WAKEUP Peng Fan (OSS)
2024-05-31 13:40 ` Peng Fan
2024-06-03 13:19 ` Sudeep Holla
2024-06-05 9:57 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox