public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: e60k02: fix aliases for mmc
@ 2024-06-05  8:39 Andreas Kemnade
  2024-06-06  1:13 ` Peng Fan
  2024-06-17  1:11 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Kemnade @ 2024-06-05  8:39 UTC (permalink / raw)
  To: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	devicetree, imx, linux-arm-kernel, linux-kernel
  Cc: Andreas Kemnade

Since commit fa2d0aa96941
("mmc: core: Allow setting slot index via device tree alias")
mmc numbering are changed, confusing boot scripts. Fix that by adding
proper aliases

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Well, this has lingered around a long time in my branches and probably
used by virtually everyone using this devicetree.

 arch/arm/boot/dts/nxp/imx/e60k02.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/nxp/imx/e60k02.dtsi b/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
index 13756d39fb7b..0029c12f16c8 100644
--- a/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
@@ -14,6 +14,10 @@
 #include <dt-bindings/input/input.h>
 
 / {
+	aliases {
+		mmc0 = &usdhc2;
+		mmc1 = &usdhc3;
+	};
 
 	chosen {
 		stdout-path = &uart1;
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] ARM: dts: e60k02: fix aliases for mmc
  2024-06-05  8:39 [PATCH] ARM: dts: e60k02: fix aliases for mmc Andreas Kemnade
@ 2024-06-06  1:13 ` Peng Fan
  2024-06-17  1:11 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2024-06-06  1:13 UTC (permalink / raw)
  To: Andreas Kemnade, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org

> Subject: [PATCH] ARM: dts: e60k02: fix aliases for mmc
> 
> Since commit fa2d0aa96941
> ("mmc: core: Allow setting slot index via device tree alias") mmc numbering
> are changed, confusing boot scripts. Fix that by adding proper aliases
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> Well, this has lingered around a long time in my branches and probably used
> by virtually everyone using this devicetree.
> 
>  arch/arm/boot/dts/nxp/imx/e60k02.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
> b/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
> index 13756d39fb7b..0029c12f16c8 100644
> --- a/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/e60k02.dtsi
> @@ -14,6 +14,10 @@
>  #include <dt-bindings/input/input.h>
> 
>  / {
> +	aliases {
> +		mmc0 = &usdhc2;
> +		mmc1 = &usdhc3;
> +	};
> 
>  	chosen {
>  		stdout-path = &uart1;
> --
> 2.39.2
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: e60k02: fix aliases for mmc
  2024-06-05  8:39 [PATCH] ARM: dts: e60k02: fix aliases for mmc Andreas Kemnade
  2024-06-06  1:13 ` Peng Fan
@ 2024-06-17  1:11 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-06-17  1:11 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: robh, krzk+dt, conor+dt, shawnguo, s.hauer, kernel, festevam,
	devicetree, imx, linux-arm-kernel, linux-kernel

On Wed, Jun 05, 2024 at 10:39:50AM +0200, Andreas Kemnade wrote:
> Since commit fa2d0aa96941
> ("mmc: core: Allow setting slot index via device tree alias")
> mmc numbering are changed, confusing boot scripts. Fix that by adding
> proper aliases
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Applied, thanks!



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-17  1:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-05  8:39 [PATCH] ARM: dts: e60k02: fix aliases for mmc Andreas Kemnade
2024-06-06  1:13 ` Peng Fan
2024-06-17  1:11 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox