[PATCH v2 0/6] arm64: dts: freescale: 2nrd clean up dtb warning under freescale

[PATCH v2 0/6] arm64: dts: freescale: 2nrd clean up dtb warning under freescale

[Frank Li]

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Changes in v2:
- added fixed tag for arm64: dts: imx8mm-phygate: fix typo pinctrcl-0 .
- remove compatible string for dto file
- drop patches, which already in mainstream
- Link to v1: https://lore.kernel.org/r/20240805-fsl_dts_warning-v1-0-055653dd5c96@nxp.com

---
Frank Li (6):
      arm64: dts: fsl-ls1028a: remove undocumented 'little-endian' for dspi node
      arm64: dts: fsl-ls208xa: move reboot node under syscon
      arm64: dts: imx8mm-venice-gw7901: add #address(size)-cells for gsc@20
      arm64: dts: imx8mp-data-modul-edm-sbc: remove #clock-cells for sai3
      arm64: dts: imx8mp-venice-gw74xx-imx219: remove compatible in overlay file
      arm64: dts: imx8mm-phygate: fix typo pinctrcl-0

 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi              |  3 ---
 arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi              | 13 ++++++-------
 .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso   |  2 +-
 .../dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso   |  2 +-
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts      |  2 ++
 arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts |  1 -
 .../boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso     |  2 --
 7 files changed, 10 insertions(+), 15 deletions(-)
---
base-commit: 1e391b34f6aa043c7afa40a2103163a0ef06d179
change-id: 20240805-fsl_dts_warning-8ea01aca79dd

Best regards,
---
Frank Li <Frank.Li@nxp.com>

[PATCH v2 1/6] arm64: dts: fsl-ls1028a: remove undocumented 'little-endian' for dspi node

[Frank Li]

According to binding doc http://devicetree.org/schemas/spi/fsl,dspi.yaml
and driver drivers/spi/spi-fsl-dspi.c, default is little-endian, should
use big-endian for big-endian system. Remove 'little-endian' to fix below
warning:

arch/arm64/boot/dts/freescale/fsl-ls1028a-qds-85bb.dtb: spi@2100000: Unevaluated properties are not allowed ('little-endian' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index acf293310f7a0..36e23d7b1676b 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -381,7 +381,6 @@ dspi0: spi@2100000 {
 			dmas = <&edma0 0 62>, <&edma0 0 60>;
 			dma-names = "tx", "rx";
 			spi-num-chipselects = <4>;
-			little-endian;
 			status = "disabled";
 		};
 
@@ -397,7 +396,6 @@ dspi1: spi@2110000 {
 			dmas = <&edma0 0 58>, <&edma0 0 56>;
 			dma-names = "tx", "rx";
 			spi-num-chipselects = <4>;
-			little-endian;
 			status = "disabled";
 		};
 
@@ -413,7 +411,6 @@ dspi2: spi@2120000 {
 			dmas = <&edma0 0 54>, <&edma0 0 2>;
 			dma-names = "tx", "rx";
 			spi-num-chipselects = <3>;
-			little-endian;
 			status = "disabled";
 		};
 

-- 
2.34.1

[PATCH v2 2/6] arm64: dts: fsl-ls208xa: move reboot node under syscon

[Frank Li]

Move reboot node under syscon and change compatible string to
fsl,ls1028a-rstcr because it is exactly same as ls1028a.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls2088a-qds.dtb:
 /syscon@1e60000: failed to match any schema with compatible: ['fsl,ls2080a-rstcr', 'syscon']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
index 1b306d6802ce3..214ca181e685d 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
@@ -68,15 +68,14 @@ its: msi-controller@6020000 {
 	};
 
 	rstcr: syscon@1e60000 {
-		compatible = "fsl,ls2080a-rstcr", "syscon";
+		compatible = "fsl,ls1028a-reset", "syscon", "simple-mfd";
 		reg = <0x0 0x1e60000 0x0 0x4>;
-	};
 
-	reboot {
-		compatible = "syscon-reboot";
-		regmap = <&rstcr>;
-		offset = <0x0>;
-		mask = <0x2>;
+		reboot {
+			compatible = "syscon-reboot";
+			offset = <0x0>;
+			mask = <0x2>;
+		};
 	};
 
 	thermal-zones {

-- 
2.34.1

[PATCH v2 3/6] arm64: dts: imx8mm-venice-gw7901: add #address(size)-cells for gsc@20

[Frank Li]

Add #address-cells and #size-cells for gsc@20 to fix below warning:
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb: gsc@20: '#address-cells' is a required propert

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
index 136cb30df03a6..35ae0faa815bc 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
@@ -364,6 +364,8 @@ gsc: gsc@20 {
 		interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
 		interrupt-controller;
 		#interrupt-cells = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
 
 		adc {
 			compatible = "gw,gsc-adc";

-- 
2.34.1

[PATCH v2 4/6] arm64: dts: imx8mp-data-modul-edm-sbc: remove #clock-cells for sai3

[Frank Li]

Remove #clock-cells for sai3 because sai3 is not clock controller to fix
below warning:
/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dtb: sai@30c30000: Unevaluated properties are not allowed ('#clock-cells' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
index 7e1b58dbe23a7..837ea79741e8d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
@@ -499,7 +499,6 @@ &pwm4 {
 };
 
 &sai3 {
-	#clock-cells = <0>;
 	#sound-dai-cells = <0>;
 	assigned-clocks = <&clk IMX8MP_CLK_SAI3>;
 	assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL1_OUT>;

-- 
2.34.1

[PATCH v2 5/6] arm64: dts: imx8mp-venice-gw74xx-imx219: remove compatible in overlay file

[Frank Li]

Remove compatible string in overlay file to fix below warning:
gw,imx8mp-gw74xx' is not one of ['fsl,ls1043a-rdb', 'fsl,ls1043a-qds']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- remove compatible string totally
---
 arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso
index edf22ff549a47..eb673a947484a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso
@@ -11,8 +11,6 @@
 /plugin/;
 
 &{/} {
-	compatible = "gw,imx8mp-gw74xx", "fsl,imx8mp";
-
 	reg_cam: regulator-cam {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_reg_cam>;

-- 
2.34.1

[PATCH v2 6/6] arm64: dts: imx8mm-phygate: fix typo pinctrcl-0

[Frank Li]

Fix typo pinctrcl-0 with pinctrl-0.
Fix below warning:

arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtb: gpio@30220000: 'pinctrl-0' is a dependency of 'pinctrl-names'
        from schema $id: http://devicetree.org/schemas/pinctrl/pinctrl-consumer.yaml#
arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtb: uart4_rs485_en: $nodename:0: 'uart4_rs485_en' does not match '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$

Fixes: 8d97083c0b5d ("arm64: dts: phygate-tauri-l: add overlays for RS232 and RS485")
Reviewed-by: Teresa Remmet <t.remmet@phytec.de>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso | 2 +-
 arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
index 9dd0703423635..f1f38b739ef76 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs232.dtso
@@ -16,7 +16,7 @@
 
 &gpio3 {
 	pinctrl-names = "default";
-	pinctrcl-0 = <&pinctrl_gpio3_hog>;
+	pinctrl-0 = <&pinctrl_gpio3_hog>;
 
 	uart4_rs485_en {
 		gpio-hog;
diff --git a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
index 045cd8082781c..1d8951e1a47e8 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
+++ b/arch/arm64/boot/dts/freescale/imx8mm-phygate-tauri-l-rs232-rs485.dtso
@@ -17,7 +17,7 @@
 
 &gpio3 {
 	pinctrl-names = "default";
-	pinctrcl-0 = <&pinctrl_gpio3_hog>;
+	pinctrl-0 = <&pinctrl_gpio3_hog>;
 
 	uart4_rs485_en {
 		gpio-hog;

-- 
2.34.1

Re: [PATCH v2 4/6] arm64: dts: imx8mp-data-modul-edm-sbc: remove #clock-cells for sai3

[Fabio Estevam]

Adding Marek.

On Wed, Aug 7, 2024 at 11:52 AM Frank Li <Frank.Li@nxp.com> wrote:
>
> Remove #clock-cells for sai3 because sai3 is not clock controller to fix
> below warning:
> /arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dtb: sai@30c30000: Unevaluated properties are not allowed ('#clock-cells' was unexpected)
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> index 7e1b58dbe23a7..837ea79741e8d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
> @@ -499,7 +499,6 @@ &pwm4 {
>  };
>
>  &sai3 {
> -       #clock-cells = <0>;
>         #sound-dai-cells = <0>;
>         assigned-clocks = <&clk IMX8MP_CLK_SAI3>;
>         assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL1_OUT>;
>
> --
> 2.34.1
>

RE: [PATCH v2 5/6] arm64: dts: imx8mp-venice-gw74xx-imx219: remove compatible in overlay file

[Peng Fan]

> Subject: [PATCH v2 5/6] arm64: dts: imx8mp-venice-gw74xx-imx219:
> remove compatible in overlay file
> 
> Remove compatible string in overlay file to fix below warning:
> gw,imx8mp-gw74xx' is not one of ['fsl,ls1043a-rdb', 'fsl,ls1043a-qds']
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - remove compatible string totally
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso |
> 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-
> imx219.dtso b/arch/arm64/boot/dts/freescale/imx8mp-venice-
> gw74xx-imx219.dtso
> index edf22ff549a47..eb673a947484a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-
> imx219.dtso
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-
> imx219.dtso
> @@ -11,8 +11,6 @@
>  /plugin/;
> 
>  &{/} {
> -	compatible = "gw,imx8mp-gw74xx", "fsl,imx8mp";


This machine string should be added to device tree, but not just delete.

Regards,
Peng.

> -
>  	reg_cam: regulator-cam {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_reg_cam>;
> 
> --
> 2.34.1
> 

Re: [PATCH v2 5/6] arm64: dts: imx8mp-venice-gw74xx-imx219: remove compatible in overlay file

[Frank Li]

On Thu, Aug 08, 2024 at 02:39:19AM +0000, Peng Fan wrote:
> > Subject: [PATCH v2 5/6] arm64: dts: imx8mp-venice-gw74xx-imx219:
> > remove compatible in overlay file
> >
> > Remove compatible string in overlay file to fix below warning:
> > gw,imx8mp-gw74xx' is not one of ['fsl,ls1043a-rdb', 'fsl,ls1043a-qds']
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Change from v1 to v2
> > - remove compatible string totally
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtso |
> > 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-
> > imx219.dtso b/arch/arm64/boot/dts/freescale/imx8mp-venice-
> > gw74xx-imx219.dtso
> > index edf22ff549a47..eb673a947484a 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-
> > imx219.dtso
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-
> > imx219.dtso
> > @@ -11,8 +11,6 @@
> >  /plugin/;
> >
> >  &{/} {
> > -	compatible = "gw,imx8mp-gw74xx", "fsl,imx8mp";
>
>
> This machine string should be added to device tree, but not just delete.

This overlay file, this compatible string should already in major dts file.

Frank

>
> Regards,
> Peng.
>
> > -
> >  	reg_cam: regulator-cam {
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&pinctrl_reg_cam>;
> >
> > --
> > 2.34.1
> >
>

Re: [PATCH v2 4/6] arm64: dts: imx8mp-data-modul-edm-sbc: remove #clock-cells for sai3

[Marek Vasut]

On 8/7/24 8:42 PM, Fabio Estevam wrote:

Hello everyone,

> Adding Marek.

Thank you Fabio.

> On Wed, Aug 7, 2024 at 11:52 AM Frank Li <Frank.Li@nxp.com> wrote:
>>
>> Remove #clock-cells for sai3 because sai3 is not clock controller to fix
>> below warning:
>> /arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dtb: sai@30c30000: Unevaluated properties are not allowed ('#clock-cells' was unexpected)
>>
>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>> ---
>>   arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
>> index 7e1b58dbe23a7..837ea79741e8d 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-data-modul-edm-sbc.dts
>> @@ -499,7 +499,6 @@ &pwm4 {
>>   };
>>
>>   &sai3 {
>> -       #clock-cells = <0>;

The change is correct, thank you Frank.

Reviewed-by: Marek Vasut <marex@denx.de>

Re: [PATCH v2 0/6] arm64: dts: freescale: 2nrd clean up dtb warning under freescale

[Shawn Guo]

On Wed, Aug 07, 2024 at 10:52:03AM -0400, Frank Li wrote:
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Changes in v2:
> - added fixed tag for arm64: dts: imx8mm-phygate: fix typo pinctrcl-0 .
> - remove compatible string for dto file
> - drop patches, which already in mainstream
> - Link to v1: https://lore.kernel.org/r/20240805-fsl_dts_warning-v1-0-055653dd5c96@nxp.com
> 
> ---
> Frank Li (6):
>       arm64: dts: fsl-ls1028a: remove undocumented 'little-endian' for dspi node
>       arm64: dts: fsl-ls208xa: move reboot node under syscon
>       arm64: dts: imx8mm-venice-gw7901: add #address(size)-cells for gsc@20
>       arm64: dts: imx8mp-data-modul-edm-sbc: remove #clock-cells for sai3
>       arm64: dts: imx8mp-venice-gw74xx-imx219: remove compatible in overlay file
>       arm64: dts: imx8mm-phygate: fix typo pinctrcl-0

Applied all, thanks!

Re: [PATCH v2 3/6] arm64: dts: imx8mm-venice-gw7901: add #address(size)-cells for gsc@20

[Tim Harvey]

On Wed, Aug 7, 2024 at 7:54 AM Frank Li <Frank.Li@nxp.com> wrote:
>
> Add #address-cells and #size-cells for gsc@20 to fix below warning:
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb: gsc@20: '#address-cells' is a required propert
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> index 136cb30df03a6..35ae0faa815bc 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> @@ -364,6 +364,8 @@ gsc: gsc@20 {
>                 interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
>                 interrupt-controller;
>                 #interrupt-cells = <1>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
>
>                 adc {
>                         compatible = "gw,gsc-adc";
>
> --
> 2.34.1
>
>

Hi Frank,

I just noticed this patch (along with a few others to
imx8m*venice*dts* which undoes what was done in commit 3343ab4cc698
"arm64: dts: freescale: imx8m*-venice-*: fix gw,gsc dt-schema
warnings" which my commit message states: Fix the dt-schema warnings
due to #address-cells/#size-cells being unnecessary when there are no
children with reg cells.

With your patch applied I now see warnings again:
$ touch arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make dtbs W=1
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx-0x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts:361.14-467.4:
Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
0a20000/gsc@20: unnecessary #address-cells/#size-cells without
"ranges", "dma-ranges" or child "reg" property
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts:311.14-418.4:
Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
0a20000/gsc@20: unnecessary #address-cells/#size-cells without
"ranges", "dma-ranges" or child "reg" property
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts:277.14-364.4:
Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
0a20000/gsc@20: unnecessary #address-cells/#size-cells without
"ranges", "dma-ranges" or child "reg" property
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts:330.14-411.4:
Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
0a20000/gsc@20: unnecessary #address-cells/#size-cells without
"ranges", "dma-ranges" or child "reg" property
  DTC     arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dtb
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts:309.14-416.4:
Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
0a20000/gsc@20: unnecessary #address-cells/#size-cells without
"ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/freescale/imx8mn.dtsi:1128.11-1138.7: Warning
(graph_child_address): /soc@0/bus@32c00000/isi@32e20000/ports: grap
h node has single child node 'port@0', #address-cells/#size-cells are
not necessary
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx-2x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx-2x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw75xx-2x.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-imx219.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-imx219.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-imx219.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-imx219.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rpidsi.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rpidsi.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs422.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs422.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs485.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs485.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-rpidsi.dtbo
  DTOVL   arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-rpidsi.dtb

Is this some case of dueling dt-schema checks for dtb checks?

Best Regards,

Tim

Re: [PATCH v2 3/6] arm64: dts: imx8mm-venice-gw7901: add #address(size)-cells for gsc@20

[Frank Li]

On Thu, Sep 05, 2024 at 11:56:41AM -0700, Tim Harvey wrote:
> On Wed, Aug 7, 2024 at 7:54 AM Frank Li <Frank.Li@nxp.com> wrote:
> >
> > Add #address-cells and #size-cells for gsc@20 to fix below warning:
> > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb: gsc@20: '#address-cells' is a required propert
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> > index 136cb30df03a6..35ae0faa815bc 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> > @@ -364,6 +364,8 @@ gsc: gsc@20 {
> >                 interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
> >                 interrupt-controller;
> >                 #interrupt-cells = <1>;
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> >
> >                 adc {
> >                         compatible = "gw,gsc-adc";
> >
> > --
> > 2.34.1
> >
> >
>
> Hi Frank,
>
> I just noticed this patch (along with a few others to
> imx8m*venice*dts* which undoes what was done in commit 3343ab4cc698
> "arm64: dts: freescale: imx8m*-venice-*: fix gw,gsc dt-schema
> warnings" which my commit message states: Fix the dt-schema warnings
> due to #address-cells/#size-cells being unnecessary when there are no
> children with reg cells.
>
> With your patch applied I now see warnings again:
> $ touch arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make dtbs W=1
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx-0x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts:361.14-467.4:
> Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
> 0a20000/gsc@20: unnecessary #address-cells/#size-cells without
> "ranges", "dma-ranges" or child "reg" property

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y freescale/imx8mm-venice-gw7901.dtb
No warning report at my side.

Did you update your dt schema?

pip3 install git+https://github.com/devicetree-org/dt-schema.git@main

Frank

>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts:311.14-418.4:
> Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
> 0a20000/gsc@20: unnecessary #address-cells/#size-cells without
> "ranges", "dma-ranges" or child "reg" property
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts:277.14-364.4:
> Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
> 0a20000/gsc@20: unnecessary #address-cells/#size-cells without
> "ranges", "dma-ranges" or child "reg" property
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dtb
> arch/arm64/boot/dts/freescale/imx8mm-venice-gw7904.dts:330.14-411.4:
> Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
> 0a20000/gsc@20: unnecessary #address-cells/#size-cells without
> "ranges", "dma-ranges" or child "reg" property
>   DTC     arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dtb
> arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts:309.14-416.4:
> Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
> 0a20000/gsc@20: unnecessary #address-cells/#size-cells without
> "ranges", "dma-ranges" or child "reg" property
> arch/arm64/boot/dts/freescale/imx8mn.dtsi:1128.11-1138.7: Warning
> (graph_child_address): /soc@0/bus@32c00000/isi@32e20000/ports: grap
> h node has single child node 'port@0', #address-cells/#size-cells are
> not necessary
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw71xx-2x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw72xx-2x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw73xx-2x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw75xx-2x.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-imx219.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-imx219.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rpidsi.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs232-rts.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs422.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x-rs485.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-imx219.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-imx219.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rpidsi.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rpidsi.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs232-rts.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs422.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs422.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs485.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x-rs485.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-imx219.dtb
>   DTC     arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-rpidsi.dtbo
>   DTOVL   arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx-rpidsi.dtb
>
> Is this some case of dueling dt-schema checks for dtb checks?
>
> Best Regards,
>
> Tim

Re: [PATCH v2 3/6] arm64: dts: imx8mm-venice-gw7901: add #address(size)-cells for gsc@20

[Tim Harvey]

On Thu, Sep 5, 2024 at 12:17 PM Frank Li <Frank.li@nxp.com> wrote:
>
> On Thu, Sep 05, 2024 at 11:56:41AM -0700, Tim Harvey wrote:
> > On Wed, Aug 7, 2024 at 7:54 AM Frank Li <Frank.Li@nxp.com> wrote:
> > >
> > > Add #address-cells and #size-cells for gsc@20 to fix below warning:
> > > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb: gsc@20: '#address-cells' is a required propert
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> > > index 136cb30df03a6..35ae0faa815bc 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts
> > > @@ -364,6 +364,8 @@ gsc: gsc@20 {
> > >                 interrupts = <16 IRQ_TYPE_EDGE_FALLING>;
> > >                 interrupt-controller;
> > >                 #interrupt-cells = <1>;
> > > +               #address-cells = <1>;
> > > +               #size-cells = <0>;
> > >
> > >                 adc {
> > >                         compatible = "gw,gsc-adc";
> > >
> > > --
> > > 2.34.1
> > >
> > >
> >
> > Hi Frank,
> >
> > I just noticed this patch (along with a few others to
> > imx8m*venice*dts* which undoes what was done in commit 3343ab4cc698
> > "arm64: dts: freescale: imx8m*-venice-*: fix gw,gsc dt-schema
> > warnings" which my commit message states: Fix the dt-schema warnings
> > due to #address-cells/#size-cells being unnecessary when there are no
> > children with reg cells.
> >
> > With your patch applied I now see warnings again:
> > $ touch arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make dtbs W=1
> >   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx-0x.dtb
> >   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx-0x.dtb
> >   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx-0x.dtb
> >   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw75xx-0x.dtb
> >   DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
> > arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts:361.14-467.4:
> > Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
> > 0a20000/gsc@20: unnecessary #address-cells/#size-cells without
> > "ranges", "dma-ranges" or child "reg" property
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y freescale/imx8mm-venice-gw7901.dtb
> No warning report at my side.
>
> Did you update your dt schema?
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
>

Frank,

Yes, I've updated my dt-schema with the above command.

So with your patch a make CHECK_DTBS=y produces no warnings but a make W=1 does:
$ touch arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make
ARCH=arm64 CROSS_COMPILE=aar
ch64-linux-gnu- -j8 CHECK_DTBS=y freescale/imx8mm-venice-gw7901.dtb
  SYNC    include/config/auto.conf.cmd
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
/usr/src/venice/linux-next/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml:
ti,x-plate-ohms: missing type definit
ion
  DTC_CHK arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
$ touch arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 W=1
freescale/imx8mm-venice-gw7901.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts:361.14-467.4:
Warning (avoid_unnecessary_addr_size): /soc@0/bus@30800000/i2c@3
0a20000/gsc@20: unnecessary #address-cells/#size-cells without
"ranges", "dma-ranges" or child "reg" property

reverting your patch flips this around:
$ git revert c59339ec2661
$ touch arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make
ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 W=1
freescale/imx8mm-venice-gw7901.dtb
  UPD     include/config/kernel.release
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
tharvey@tharvey:/usr/src/venice/linux-next$ touch
arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y
freescale/imx8mm-venice-gw7901.dtb
  DTC_CHK arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb
/usr/src/venice/linux-next/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb:
gsc@20: '#address-cells' is a required property
        from schema $id: http://devicetree.org/schemas/mfd/gateworks-gsc.yaml#
/usr/src/venice/linux-next/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb:
gsc@20: '#size-cells' is a required property
        from schema $id: http://devicetree.org/schemas/mfd/gateworks-gsc.yaml#
tharvey@tharvey:/usr/src/venice/linux-next$ touch
arch/arm64/boot/dts/freescale/imx8m*venice*.dts*; make ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- -j8 W=1
freescale/imx8mm-venice-gw7901.dtb
  DTC     arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtb

Maybe the dt experts can tell us what the difference is with
CHECK_DTBS=y vs W=1 and which patch is correct between
c59339ec2661 arm64: dts: imx8mm-venice-gw7901: add
#address(size)-cells for gsc@20
3343ab4cc698 arm64: dts: freescale: imx8m*-venice-*: fix gw,gsc
dt-schema warnings

Best Regards,

Tim