From: Shawn Guo <shawnguo2@yeah.net>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
llvm@lists.linux.dev, patches@lists.linux.dev
Subject: Re: [PATCH] ARM: imx: Annotate imx7d_enet_init() as __init
Date: Sun, 1 Sep 2024 15:36:59 +0800 [thread overview]
Message-ID: <ZtQZmxbLxr3dXZ/N@dragon> (raw)
In-Reply-To: <20240822-imx7d-mark-imx7d_enet_init-as-init-v1-1-8dfadee3bed4@kernel.org>
On Thu, Aug 22, 2024 at 05:05:17PM -0700, Nathan Chancellor wrote:
> After a recent LLVM change [1] that deduces __cold on functions that
> only call cold code (such as __init functions), there is a section
> mismatch warning from imx7d_enet_init(), which got moved to
> .text.unlikely. as a result of that optimization:
>
> WARNING: modpost: vmlinux: section mismatch in reference: imx7d_enet_init+0x20 (section: .text.unlikely.) -> imx7d_enet_clk_sel (section: .init.text)
>
> Drop the inline keyword (which does not guarantee inlining) and replace
> it with __init, as imx7d_enet_init() is only called from __init code,
> which clears up the warning.
>
> Link: https://github.com/llvm/llvm-project/commit/6b11573b8c5e3d36beee099dbe7347c2a007bf53 [1]
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Applied, thanks!
prev parent reply other threads:[~2024-09-01 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 0:05 [PATCH] ARM: imx: Annotate imx7d_enet_init() as __init Nathan Chancellor
2024-08-23 9:20 ` Peng Fan
2024-09-01 7:36 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtQZmxbLxr3dXZ/N@dragon \
--to=shawnguo2@yeah.net \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=patches@lists.linux.dev \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox