* [PATCH 0/2] add I2C support for S32G2/S32G3 SoCs
@ 2024-11-04 10:00 Ciprian Costea
2024-11-04 10:00 ` [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G Ciprian Costea
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Ciprian Costea @ 2024-11-04 10:00 UTC (permalink / raw)
To: Oleksij Rempel, Pengutronix Kernel Team, Andi Shyti, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel,
Christophe Lizzi, Alberto Ruiz, Enric Balletbo,
Ciprian Marian Costea
From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
S32G2 and S32G3 SoCs share the same I2C controller as i.MX.
Address the hardware particularities for S32 SoC family,
such as:
- different <clock divider, register value> pairs
- regshift
Ciprian Marian Costea (2):
dt-bindings: i2c: imx: add SoC specific compatible strings for S32G
i2c: imx: add support for S32G2/S32G3 SoCs
.../devicetree/bindings/i2c/i2c-imx.yaml | 4 ++
drivers/i2c/busses/Kconfig | 7 ++--
drivers/i2c/busses/i2c-imx.c | 37 ++++++++++++++++++-
3 files changed, 44 insertions(+), 4 deletions(-)
--
2.45.2
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G 2024-11-04 10:00 [PATCH 0/2] add I2C support for S32G2/S32G3 SoCs Ciprian Costea @ 2024-11-04 10:00 ` Ciprian Costea 2024-11-04 16:37 ` Frank Li 2024-11-04 18:44 ` Conor Dooley 2024-11-04 10:00 ` [PATCH 2/2] i2c: imx: add support for S32G2/S32G3 SoCs Ciprian Costea 2024-11-05 15:02 ` [PATCH 0/2] add I2C " Andi Shyti 2 siblings, 2 replies; 7+ messages in thread From: Ciprian Costea @ 2024-11-04 10:00 UTC (permalink / raw) To: Oleksij Rempel, Pengutronix Kernel Team, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam Cc: linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel, Christophe Lizzi, Alberto Ruiz, Enric Balletbo, Ciprian Marian Costea From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> S32G2 and S32G3 SoCs use the same I2C controller as i.MX. But there are small differences such as specific <clock divider, register value> pairs. So add new compatible strings 'nxp,s32g2-i2c'and 'nxp,s32g3-i2c' for S32G2/S32G3 Socs. Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> --- Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml index 85ee1282d6d2..0682a5a10d41 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml @@ -18,6 +18,7 @@ properties: - const: fsl,imx1-i2c - const: fsl,imx21-i2c - const: fsl,vf610-i2c + - const: nxp,s32g2-i2c - items: - enum: - fsl,ls1012a-i2c @@ -54,6 +55,9 @@ properties: - fsl,imx8mn-i2c - fsl,imx8mp-i2c - const: fsl,imx21-i2c + - items: + - const: nxp,s32g3-i2c + - const: nxp,s32g2-i2c reg: maxItems: 1 -- 2.45.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G 2024-11-04 10:00 ` [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G Ciprian Costea @ 2024-11-04 16:37 ` Frank Li 2024-11-04 18:44 ` Conor Dooley 1 sibling, 0 replies; 7+ messages in thread From: Frank Li @ 2024-11-04 16:37 UTC (permalink / raw) To: Ciprian Costea Cc: Oleksij Rempel, Pengutronix Kernel Team, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel, Christophe Lizzi, Alberto Ruiz, Enric Balletbo On Mon, Nov 04, 2024 at 12:00:43PM +0200, Ciprian Costea wrote: > From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> > > S32G2 and S32G3 SoCs use the same I2C controller as i.MX. > But there are small differences such as specific > <clock divider, register value> pairs. > So add new compatible strings 'nxp,s32g2-i2c'and 'nxp,s32g3-i2c' > for S32G2/S32G3 Socs. nit: Please wrap at 75 char or need empty line between segment. Reviewed-by: Frank Li <Frank.Li@nxp.com> > > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> > --- > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > index 85ee1282d6d2..0682a5a10d41 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > @@ -18,6 +18,7 @@ properties: > - const: fsl,imx1-i2c > - const: fsl,imx21-i2c > - const: fsl,vf610-i2c > + - const: nxp,s32g2-i2c > - items: > - enum: > - fsl,ls1012a-i2c > @@ -54,6 +55,9 @@ properties: > - fsl,imx8mn-i2c > - fsl,imx8mp-i2c > - const: fsl,imx21-i2c > + - items: > + - const: nxp,s32g3-i2c > + - const: nxp,s32g2-i2c > > reg: > maxItems: 1 > -- > 2.45.2 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G 2024-11-04 10:00 ` [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G Ciprian Costea 2024-11-04 16:37 ` Frank Li @ 2024-11-04 18:44 ` Conor Dooley 1 sibling, 0 replies; 7+ messages in thread From: Conor Dooley @ 2024-11-04 18:44 UTC (permalink / raw) To: Ciprian Costea Cc: Oleksij Rempel, Pengutronix Kernel Team, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel, Christophe Lizzi, Alberto Ruiz, Enric Balletbo [-- Attachment #1: Type: text/plain, Size: 1444 bytes --] On Mon, Nov 04, 2024 at 12:00:43PM +0200, Ciprian Costea wrote: > From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> > > S32G2 and S32G3 SoCs use the same I2C controller as i.MX. > But there are small differences such as specific > <clock divider, register value> pairs. > So add new compatible strings 'nxp,s32g2-i2c'and 'nxp,s32g3-i2c' > for S32G2/S32G3 Socs. Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> > --- > Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > index 85ee1282d6d2..0682a5a10d41 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml > @@ -18,6 +18,7 @@ properties: > - const: fsl,imx1-i2c > - const: fsl,imx21-i2c > - const: fsl,vf610-i2c > + - const: nxp,s32g2-i2c > - items: > - enum: > - fsl,ls1012a-i2c > @@ -54,6 +55,9 @@ properties: > - fsl,imx8mn-i2c > - fsl,imx8mp-i2c > - const: fsl,imx21-i2c > + - items: > + - const: nxp,s32g3-i2c > + - const: nxp,s32g2-i2c > > reg: > maxItems: 1 > -- > 2.45.2 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] i2c: imx: add support for S32G2/S32G3 SoCs 2024-11-04 10:00 [PATCH 0/2] add I2C support for S32G2/S32G3 SoCs Ciprian Costea 2024-11-04 10:00 ` [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G Ciprian Costea @ 2024-11-04 10:00 ` Ciprian Costea 2024-11-04 16:42 ` Frank Li 2024-11-05 15:02 ` [PATCH 0/2] add I2C " Andi Shyti 2 siblings, 1 reply; 7+ messages in thread From: Ciprian Costea @ 2024-11-04 10:00 UTC (permalink / raw) To: Oleksij Rempel, Pengutronix Kernel Team, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam Cc: linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel, Christophe Lizzi, Alberto Ruiz, Enric Balletbo, Ciprian Marian Costea, Ionut Vicovan From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> Some S32G2/S32G3 SoC I2C particularities exist such as different <clock divider, register value> pairs. Those are addressed by adding specific S32G2 and S32G3 compatible strings. Co-developed-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> --- drivers/i2c/busses/Kconfig | 7 ++++--- drivers/i2c/busses/i2c-imx.c | 37 +++++++++++++++++++++++++++++++++++- 2 files changed, 40 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 6b3ba7e5723a..45ea214e4b0e 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -741,13 +741,14 @@ config I2C_IMG config I2C_IMX tristate "IMX I2C interface" - depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE || COMPILE_TEST + depends on ARCH_MXC || ARCH_LAYERSCAPE || ARCH_S32 || COLDFIRE \ + || COMPILE_TEST select I2C_SLAVE help Say Y here if you want to use the IIC bus controller on - the Freescale i.MX/MXC, Layerscape or ColdFire processors. + the Freescale i.MX/MXC/S32G, Layerscape or ColdFire processors. - This driver can also be built as a module. If so, the module + This driver can also be built as a module. If so, the module will be called i2c-imx. config I2C_IMX_LPI2C diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index 98539313cbc9..3509c37c89ab 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -17,7 +17,7 @@ * Copyright (C) 2008 Darius Augulis <darius.augulis at teltonika.lt> * * Copyright 2013 Freescale Semiconductor, Inc. - * Copyright 2020 NXP + * Copyright 2020, 2024 NXP * */ @@ -84,6 +84,7 @@ #define IMX_I2C_REGSHIFT 2 #define VF610_I2C_REGSHIFT 0 +#define S32G_I2C_REGSHIFT 0 /* Bits of IMX I2C registers */ #define I2SR_RXAK 0x01 @@ -165,10 +166,35 @@ static struct imx_i2c_clk_pair vf610_i2c_clk_div[] = { { 3840, 0x3F }, { 4096, 0x7B }, { 5120, 0x7D }, { 6144, 0x7E }, }; +/* S32G2/S32G3 clock divider, register value pairs */ +static struct imx_i2c_clk_pair s32g2_i2c_clk_div[] = { + { 34, 0x00 }, { 36, 0x01 }, { 38, 0x02 }, { 40, 0x03 }, + { 42, 0x04 }, { 44, 0x05 }, { 46, 0x06 }, { 48, 0x09 }, + { 52, 0x0A }, { 54, 0x07 }, { 56, 0x0B }, { 60, 0x0C }, + { 64, 0x0D }, { 68, 0x40 }, { 72, 0x0E }, { 76, 0x42 }, + { 80, 0x12 }, { 84, 0x0F }, { 88, 0x13 }, { 96, 0x14 }, + { 104, 0x15 }, { 108, 0x47 }, { 112, 0x19 }, { 120, 0x16 }, + { 128, 0x1A }, { 136, 0x80 }, { 144, 0x17 }, { 152, 0x82 }, + { 160, 0x1C }, { 168, 0x84 }, { 176, 0x1D }, { 192, 0x21 }, + { 208, 0x1E }, { 216, 0x87 }, { 224, 0x22 }, { 240, 0x56 }, + { 256, 0x1F }, { 288, 0x24 }, { 320, 0x25 }, { 336, 0x8F }, + { 352, 0x93 }, { 356, 0x5D }, { 358, 0x98 }, { 384, 0x26 }, + { 416, 0x56 }, { 448, 0x2A }, { 480, 0x27 }, { 512, 0x2B }, + { 576, 0x2C }, { 640, 0x2D }, { 704, 0x9D }, { 768, 0x2E }, + { 832, 0x9D }, { 896, 0x32 }, { 960, 0x2F }, { 1024, 0x33 }, + { 1152, 0x34 }, { 1280, 0x35 }, { 1536, 0x36 }, { 1792, 0x3A }, + { 1920, 0x37 }, { 2048, 0x3B }, { 2304, 0x74 }, { 2560, 0x3D }, + { 3072, 0x3E }, { 3584, 0x7A }, { 3840, 0x3F }, { 4096, 0x7B }, + { 4608, 0x7C }, { 5120, 0x7D }, { 6144, 0x7E }, { 7168, 0xBA }, + { 7680, 0x7F }, { 8192, 0xBB }, { 9216, 0xBC }, { 10240, 0xBD }, + { 12288, 0xBE }, { 15360, 0xBF }, +}; + enum imx_i2c_type { IMX1_I2C, IMX21_I2C, VF610_I2C, + S32G_I2C, }; struct imx_i2c_hwdata { @@ -258,7 +284,15 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), .i2sr_clr_opcode = I2SR_CLR_OPCODE_W1C, .i2cr_ien_opcode = I2CR_IEN_OPCODE_0, +}; +static const struct imx_i2c_hwdata s32g2_i2c_hwdata = { + .devtype = S32G_I2C, + .regshift = S32G_I2C_REGSHIFT, + .clk_div = s32g2_i2c_clk_div, + .ndivs = ARRAY_SIZE(s32g2_i2c_clk_div), + .i2sr_clr_opcode = I2SR_CLR_OPCODE_W1C, + .i2cr_ien_opcode = I2CR_IEN_OPCODE_0, }; static const struct platform_device_id imx_i2c_devtype[] = { @@ -288,6 +322,7 @@ static const struct of_device_id i2c_imx_dt_ids[] = { { .compatible = "fsl,imx8mp-i2c", .data = &imx6_i2c_hwdata, }, { .compatible = "fsl,imx8mq-i2c", .data = &imx6_i2c_hwdata, }, { .compatible = "fsl,vf610-i2c", .data = &vf610_i2c_hwdata, }, + { .compatible = "nxp,s32g2-i2c", .data = &s32g2_i2c_hwdata, }, { /* sentinel */ } }; MODULE_DEVICE_TABLE(of, i2c_imx_dt_ids); -- 2.45.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] i2c: imx: add support for S32G2/S32G3 SoCs 2024-11-04 10:00 ` [PATCH 2/2] i2c: imx: add support for S32G2/S32G3 SoCs Ciprian Costea @ 2024-11-04 16:42 ` Frank Li 0 siblings, 0 replies; 7+ messages in thread From: Frank Li @ 2024-11-04 16:42 UTC (permalink / raw) To: Ciprian Costea Cc: Oleksij Rempel, Pengutronix Kernel Team, Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel, Christophe Lizzi, Alberto Ruiz, Enric Balletbo, Ionut Vicovan On Mon, Nov 04, 2024 at 12:00:44PM +0200, Ciprian Costea wrote: > From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> > > Some S32G2/S32G3 SoC I2C particularities exist > such as different <clock divider, register value> pairs. > Those are addressed by adding specific S32G2 and S32G3 > compatible strings. Add S32G2 and S32G3 support. The I2C in S32G2/S32G3 have different <clock divider, register value> pairs. with fix below nit: Reviewed-by: Frank Li <Frank.Li@nxp.com > > > Co-developed-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> > Signed-off-by: Ionut Vicovan <Ionut.Vicovan@nxp.com> > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> > --- > drivers/i2c/busses/Kconfig | 7 ++++--- > drivers/i2c/busses/i2c-imx.c | 37 +++++++++++++++++++++++++++++++++++- > 2 files changed, 40 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 6b3ba7e5723a..45ea214e4b0e 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -741,13 +741,14 @@ config I2C_IMG > > config I2C_IMX > tristate "IMX I2C interface" > - depends on ARCH_MXC || ARCH_LAYERSCAPE || COLDFIRE || COMPILE_TEST > + depends on ARCH_MXC || ARCH_LAYERSCAPE || ARCH_S32 || COLDFIRE \ > + || COMPILE_TEST > select I2C_SLAVE > help > Say Y here if you want to use the IIC bus controller on > - the Freescale i.MX/MXC, Layerscape or ColdFire processors. > + the Freescale i.MX/MXC/S32G, Layerscape or ColdFire processors. > > - This driver can also be built as a module. If so, the module > + This driver can also be built as a module. If so, the module > will be called i2c-imx. > > config I2C_IMX_LPI2C > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index 98539313cbc9..3509c37c89ab 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -17,7 +17,7 @@ > * Copyright (C) 2008 Darius Augulis <darius.augulis at teltonika.lt> > * > * Copyright 2013 Freescale Semiconductor, Inc. > - * Copyright 2020 NXP > + * Copyright 2020, 2024 NXP > * > */ > > @@ -84,6 +84,7 @@ > > #define IMX_I2C_REGSHIFT 2 > #define VF610_I2C_REGSHIFT 0 > +#define S32G_I2C_REGSHIFT 0 > > /* Bits of IMX I2C registers */ > #define I2SR_RXAK 0x01 > @@ -165,10 +166,35 @@ static struct imx_i2c_clk_pair vf610_i2c_clk_div[] = { > { 3840, 0x3F }, { 4096, 0x7B }, { 5120, 0x7D }, { 6144, 0x7E }, > }; > > +/* S32G2/S32G3 clock divider, register value pairs */ > +static struct imx_i2c_clk_pair s32g2_i2c_clk_div[] = { > + { 34, 0x00 }, { 36, 0x01 }, { 38, 0x02 }, { 40, 0x03 }, > + { 42, 0x04 }, { 44, 0x05 }, { 46, 0x06 }, { 48, 0x09 }, > + { 52, 0x0A }, { 54, 0x07 }, { 56, 0x0B }, { 60, 0x0C }, > + { 64, 0x0D }, { 68, 0x40 }, { 72, 0x0E }, { 76, 0x42 }, > + { 80, 0x12 }, { 84, 0x0F }, { 88, 0x13 }, { 96, 0x14 }, > + { 104, 0x15 }, { 108, 0x47 }, { 112, 0x19 }, { 120, 0x16 }, > + { 128, 0x1A }, { 136, 0x80 }, { 144, 0x17 }, { 152, 0x82 }, > + { 160, 0x1C }, { 168, 0x84 }, { 176, 0x1D }, { 192, 0x21 }, > + { 208, 0x1E }, { 216, 0x87 }, { 224, 0x22 }, { 240, 0x56 }, > + { 256, 0x1F }, { 288, 0x24 }, { 320, 0x25 }, { 336, 0x8F }, > + { 352, 0x93 }, { 356, 0x5D }, { 358, 0x98 }, { 384, 0x26 }, > + { 416, 0x56 }, { 448, 0x2A }, { 480, 0x27 }, { 512, 0x2B }, > + { 576, 0x2C }, { 640, 0x2D }, { 704, 0x9D }, { 768, 0x2E }, > + { 832, 0x9D }, { 896, 0x32 }, { 960, 0x2F }, { 1024, 0x33 }, > + { 1152, 0x34 }, { 1280, 0x35 }, { 1536, 0x36 }, { 1792, 0x3A }, > + { 1920, 0x37 }, { 2048, 0x3B }, { 2304, 0x74 }, { 2560, 0x3D }, > + { 3072, 0x3E }, { 3584, 0x7A }, { 3840, 0x3F }, { 4096, 0x7B }, > + { 4608, 0x7C }, { 5120, 0x7D }, { 6144, 0x7E }, { 7168, 0xBA }, > + { 7680, 0x7F }, { 8192, 0xBB }, { 9216, 0xBC }, { 10240, 0xBD }, > + { 12288, 0xBE }, { 15360, 0xBF }, > +}; > + > enum imx_i2c_type { > IMX1_I2C, > IMX21_I2C, > VF610_I2C, > + S32G_I2C, Nit: please order by alphabet. > }; > > struct imx_i2c_hwdata { > @@ -258,7 +284,15 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > .i2sr_clr_opcode = I2SR_CLR_OPCODE_W1C, > .i2cr_ien_opcode = I2CR_IEN_OPCODE_0, > +}; > > +static const struct imx_i2c_hwdata s32g2_i2c_hwdata = { > + .devtype = S32G_I2C, > + .regshift = S32G_I2C_REGSHIFT, > + .clk_div = s32g2_i2c_clk_div, > + .ndivs = ARRAY_SIZE(s32g2_i2c_clk_div), > + .i2sr_clr_opcode = I2SR_CLR_OPCODE_W1C, > + .i2cr_ien_opcode = I2CR_IEN_OPCODE_0, > }; > > static const struct platform_device_id imx_i2c_devtype[] = { > @@ -288,6 +322,7 @@ static const struct of_device_id i2c_imx_dt_ids[] = { > { .compatible = "fsl,imx8mp-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,imx8mq-i2c", .data = &imx6_i2c_hwdata, }, > { .compatible = "fsl,vf610-i2c", .data = &vf610_i2c_hwdata, }, > + { .compatible = "nxp,s32g2-i2c", .data = &s32g2_i2c_hwdata, }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, i2c_imx_dt_ids); > -- > 2.45.2 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] add I2C support for S32G2/S32G3 SoCs 2024-11-04 10:00 [PATCH 0/2] add I2C support for S32G2/S32G3 SoCs Ciprian Costea 2024-11-04 10:00 ` [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G Ciprian Costea 2024-11-04 10:00 ` [PATCH 2/2] i2c: imx: add support for S32G2/S32G3 SoCs Ciprian Costea @ 2024-11-05 15:02 ` Andi Shyti 2 siblings, 0 replies; 7+ messages in thread From: Andi Shyti @ 2024-11-05 15:02 UTC (permalink / raw) To: Ciprian Costea Cc: Oleksij Rempel, Pengutronix Kernel Team, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-i2c, devicetree, imx, linux-arm-kernel, linux-kernel, Christophe Lizzi, Alberto Ruiz, Enric Balletbo Hi Ciprian, > Ciprian Marian Costea (2): > dt-bindings: i2c: imx: add SoC specific compatible strings for S32G > i2c: imx: add support for S32G2/S32G3 SoCs with the change proposed by Frank in patch 2, I merged this series in i2c/i2c-host. Thanks, Andi ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-11-05 15:06 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-04 10:00 [PATCH 0/2] add I2C support for S32G2/S32G3 SoCs Ciprian Costea 2024-11-04 10:00 ` [PATCH 1/2] dt-bindings: i2c: imx: add SoC specific compatible strings for S32G Ciprian Costea 2024-11-04 16:37 ` Frank Li 2024-11-04 18:44 ` Conor Dooley 2024-11-04 10:00 ` [PATCH 2/2] i2c: imx: add support for S32G2/S32G3 SoCs Ciprian Costea 2024-11-04 16:42 ` Frank Li 2024-11-05 15:02 ` [PATCH 0/2] add I2C " Andi Shyti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox