Re: [PATCH v3 3/5] hwmon: tmp108: Add helper function tmp108_common_probe() to prepare I3C support

[Frank Li <Frank.li@nxp.com>]

On Mon, Nov 11, 2024 at 11:44:08AM -0800, Guenter Roeck wrote:
> On 11/11/24 09:32, Frank Li wrote:
> > Add help function tmp108_common_probe() to pave road to support i3c for
> > P3T1085(NXP) chip.
> >
> > Use dev_err_probe() to simple code.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
>
> I applied the first two patches of the series, but I am holding back this
> and the subsequent patches since I don't know how the kernel handles having
> two drivers in a single module, and one of them fails to instantiate. I did
> not find a matching example elsewhere in the kernel. We may have to use
> the method used by the st_lsm6dsx driver - essentially splitting the driver
> into three parts (i2c, i3c, and common). That would be overkill; the alternative
> might be something like the approach used by module_i3c_i2c_driver(), but with
> a set of #ifdefs around (some of) the i3c code.

Thanks, let me think more about this.

>
> Guenter
>