public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Evgeniy Polyakov <zbr@ioremap.net>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: linux-imx@nxp.com, Li Yang <leoyang.li@nxp.com>,
	Denis Ciocca <denis.ciocca@st.com>,
	soc@kernel.org, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Stefan Wahren <stefan.wahren@chargebyte.com>
Subject: Re: [PATCH 7/8] ARM: dts: imx6ull: Add chargebyte Tarragon support
Date: Tue, 7 Mar 2023 18:25:23 +0100	[thread overview]
Message-ID: <a2a39419-86e9-2dff-644a-391248b51a0e@i2se.com> (raw)
In-Reply-To: <d77c2938-bcef-4586-77b5-1cb93b113eb5@linaro.org>

Hi Krzysztof,

Am 07.03.23 um 09:30 schrieb Krzysztof Kozlowski:
> On 06/03/2023 18:22, Stefan Wahren wrote:
>> From: Stefan Wahren <stefan.wahren@chargebyte.com>
>>
>> This adds the support for chargebyte Tarragon, which is an Electrical
>> Vehicle Supply Equipment (EVSE) for AC charging stations
>> (according to IEC 61851, ISO 15118).
>>
>> The Tarragon board is based on an i.MX6ULL SoC and is available in
>> 4 variants (Master, Slave, SlaveXT, Micro), which provide more or
>> less peripherals.
>>
>> Supported features:
>>    * 512 MB DDR RAM
>>    * eMMC
>>    * Debug UART
>>    * 100 Mbit Ethernet
>>    * USB 2.0 Host interface
>>    * Powerline communication (QCA700x)
>>    * 2x RS485
>>    * Digital in- and outputs (12 V)
>>    * One-Wire master for external temp sensors
>>    * 2x relay outputs
>>    * 2x motor interfaces
>>
>> Link: https://chargebyte.com/products/charging-station-communication/charge-control-c
>> Signed-off-by: Stefan Wahren <stefan.wahren@chargebyte.com>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>>   arch/arm/boot/dts/Makefile                    |   4 +
>>   .../arm/boot/dts/imx6ull-tarragon-common.dtsi | 858 ++++++++++++++++++
>>   arch/arm/boot/dts/imx6ull-tarragon-master.dts |  82 ++
>>   arch/arm/boot/dts/imx6ull-tarragon-micro.dts  |  10 +
>>   arch/arm/boot/dts/imx6ull-tarragon-slave.dts  |  32 +
>>   .../arm/boot/dts/imx6ull-tarragon-slavext.dts |  64 ++
>>   6 files changed, 1050 insertions(+)
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-master.dts
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-micro.dts
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-slave.dts
>>   create mode 100644 arch/arm/boot/dts/imx6ull-tarragon-slavext.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index efe4152e5846..aae52a6380bc 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -755,6 +755,10 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>>   	imx6ull-phytec-segin-lc-rdk-nand.dtb \
>>   	imx6ull-phytec-tauri-emmc.dtb \
>>   	imx6ull-phytec-tauri-nand.dtb \
>> +	imx6ull-tarragon-master.dtb \
>> +	imx6ull-tarragon-micro.dtb \
>> +	imx6ull-tarragon-slave.dtb \
>> +	imx6ull-tarragon-slavext.dtb \
>>   	imx6ull-tqma6ull2-mba6ulx.dtb \
>>   	imx6ull-tqma6ull2l-mba6ulx.dtb \
>>   	imx6ulz-14x14-evk.dtb \
>> diff --git a/arch/arm/boot/dts/imx6ull-tarragon-common.dtsi b/arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
>> new file mode 100644
>> index 000000000000..1099dd688e80
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/imx6ull-tarragon-common.dtsi
>> @@ -0,0 +1,858 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +//
>> +// Copyright (C) 2023 chargebyte GmbH
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/leds/common.h>
>> +#include <dt-bindings/pwm/pwm.h>
>> +#include "imx6ull.dtsi"
>> +
>> +/ {
>> +	aliases {
>> +		mmc0 = &usdhc2; /* eMMC */
>> +	};
>> +
>> +	chosen {
>> +		stdout-path = &uart4;
>> +	};
>> +
>> +	memory@80000000 {
>> +		device_type = "memory";
>> +		reg = <0x80000000 0x20000000>;
>> +	};
>> +
>> +	emmc_pwrseq: emmc-pwrseq {
>> +		compatible = "mmc-pwrseq-emmc";
>> +		pinctrl-0 = <&pinctrl_emmc_rst>;
>> +		pinctrl-names = "default";
>> +		reset-gpios = <&gpio4 10 GPIO_ACTIVE_LOW>;
>> +	};
>> +
>> +	reg_dcdc_3v3: regulator-dcdc-3v3 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "dcdc-3v3";
>> +		regulator-min-microvolt = <3300000>;
>> +		regulator-max-microvolt = <3300000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	reg_1v8: regulator-1v8 {
>> +		compatible = "regulator-fixed";
>> +		regulator-name = "ldo-1v8";
>> +		regulator-min-microvolt = <1800000>;
>> +		regulator-max-microvolt = <1800000>;
>> +		regulator-boot-on;
>> +		regulator-always-on;
>> +	};
>> +
>> +	leds {
>> +		compatible = "gpio-leds";
>> +		pinctrl-names = "default";
>> +		pinctrl-0 = <&pinctrl_status_leds>;
>> +
>> +		led1 {
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).

I ran make dtbs_check before sending this series. All of these issues in 
the included dtsi files makes it hard to spot DTS specific issues. This 
is the output of make dtbs_check:

   DTC_CHK arch/arm/boot/dts/imx6ull-tarragon-master.dtb
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
nand-controller@1806000: #size-cells:0:0: 0 was expected
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/mtd/nand-controller.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
nand-controller@1806000: #size-cells:0:0: 0 was expected
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/mtd/gpmi-nand.yaml
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/spba-bus@2000000/spi@200c000/ethernet@0: failed to 
match any schema with compatible: ['qca,qca7000']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/spba-bus@2000000/spi@2014000/ethernet@0: failed to 
match any schema with compatible: ['qca,qca7000']
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial@2018000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial@2020000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/spba-bus@2000000/asrc@2034000: failed to match any 
schema with compatible: ['fsl,imx6ul-asrc', 'fsl,imx53-asrc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/spba-bus@2000000/asrc@2034000: failed to match any 
schema with compatible: ['fsl,imx6ul-asrc', 'fsl,imx53-asrc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/tsc@2040000: failed to match any schema with 
compatible: ['fsl,imx6ul-tsc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/anatop@20c8000: failed to match any schema with 
compatible: ['fsl,imx6ul-anatop', 'fsl,imx6q-anatop', 'syscon', 
'simple-mfd']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/anatop@20c8000: failed to match any schema with 
compatible: ['fsl,imx6ul-anatop', 'fsl,imx6q-anatop', 'syscon', 
'simple-mfd']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/usbphy@20c9000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/usbphy@20c9000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/usbphy@20ca000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/usbphy@20ca000: failed to match any schema with 
compatible: ['fsl,imx6ul-usbphy', 'fsl,imx23-usbphy']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/snvs@20cc000: failed to match any schema with 
compatible: ['fsl,sec-v4.0-mon', 'syscon', 'simple-mfd']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/snvs@20cc000/snvs-rtc-lp: failed to match any schema 
with compatible: ['fsl,sec-v4.0-mon-rtc-lp']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/snvs@20cc000/snvs-powerkey: failed to match any schema 
with compatible: ['fsl,sec-v4.0-pwrkey']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/pinctrl@20e0000: failed to match any schema with 
compatible: ['fsl,imx6ul-iomuxc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/iomuxc-gpr@20e4000: failed to match any schema with 
compatible: ['fsl,imx6ul-iomuxc-gpr', 'fsl,imx6q-iomuxc-gpr', 'syscon']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2000000/iomuxc-gpr@20e4000: failed to match any schema with 
compatible: ['fsl,imx6ul-iomuxc-gpr', 'fsl,imx6q-iomuxc-gpr', 'syscon']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/usb@2184000: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/usb@2184000: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/usb@2184200: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/usb@2184200: failed to match any schema with 
compatible: ['fsl,imx6ul-usb', 'fsl,imx27-usb']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/usbmisc@2184800: failed to match any schema with 
compatible: ['fsl,imx6ul-usbmisc', 'fsl,imx6q-usbmisc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/usbmisc@2184800: failed to match any schema with 
compatible: ['fsl,imx6ul-usbmisc', 'fsl,imx6q-usbmisc']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/weim@21b8000: failed to match any schema with 
compatible: ['fsl,imx6ul-weim', 'fsl,imx6q-weim']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2100000/weim@21b8000: failed to match any schema with 
compatible: ['fsl,imx6ul-weim', 'fsl,imx6q-weim']
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial@21f0000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial@21f4000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
/home/stefanw/mainline/arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
serial@21fc000: Unevaluated properties are not allowed ('clock-names', 
'clocks' were unexpected)
     From schema: 
/home/stefanw/mainline/Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: 
/soc/bus@2200000/iomuxc-snvs@2290000: failed to match any schema with 
compatible: ['fsl,imx6ull-iomuxc-snvs']
arch/arm/boot/dts/imx6ull-tarragon-master.dtb: /pwm-fan: failed to match 
any schema with compatible: ['pwm-fan']

Can you please point me, what is wrong or did you refer just to the 
deprecated "label" property which doesn't throw a warning in my case?

Did i missed a parameter?

Best regards


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-07 17:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 17:22 [PATCH 0/8] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-06 17:22 ` [PATCH 1/8] dt-bindings: vendor-prefixes: add chargebyte Stefan Wahren
2023-03-07  8:21   ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 2/8] dt-bindings: Add DS2482/DS2484 as trivial device Stefan Wahren
2023-03-07  8:21   ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 3/8] w1: ds2482: add i2c id for ds2484 Stefan Wahren
2023-03-06 17:22 ` [PATCH 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer Stefan Wahren
2023-03-07  8:23   ` Krzysztof Kozlowski
2023-03-07 17:27     ` Stefan Wahren
2023-03-11 18:06       ` Jonathan Cameron
2023-03-06 17:22 ` [PATCH 5/8] iio: accel: add support for IIS328DQ variant Stefan Wahren
2023-03-11 18:08   ` Jonathan Cameron
2023-03-06 17:22 ` [PATCH 6/8] dt-bindings: ARM: fsl: Add chargebyte Tarragon Stefan Wahren
2023-03-07  8:24   ` Krzysztof Kozlowski
2023-03-10 10:08     ` Stefan Wahren
2023-03-10 10:46       ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 7/8] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-07  8:30   ` Krzysztof Kozlowski
2023-03-07 17:25     ` Stefan Wahren [this message]
2023-03-08  8:44       ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 8/8] ARM: imx_v6_v7_defconfig: Enable Tarragon peripheral drivers Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a2a39419-86e9-2dff-644a-391248b51a0e@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=arnd@arndb.de \
    --cc=denis.ciocca@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=soc@kernel.org \
    --cc=stefan.wahren@chargebyte.com \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox