From: Jonathan Cameron <jic23@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Evgeniy Polyakov <zbr@ioremap.net>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
linux-imx@nxp.com, Li Yang <leoyang.li@nxp.com>,
Denis Ciocca <denis.ciocca@st.com>,
soc@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Stefan Wahren <stefan.wahren@chargebyte.com>
Subject: Re: [PATCH 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer
Date: Sat, 11 Mar 2023 18:06:40 +0000 [thread overview]
Message-ID: <20230311180640.4f975f78@jic23-huawei> (raw)
In-Reply-To: <9c2d0ca3-660e-72d2-d158-5c921cd9d607@i2se.com>
On Tue, 7 Mar 2023 18:27:53 +0100
Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi Krzysztof,
>
> Am 07.03.23 um 09:23 schrieb Krzysztof Kozlowski:
> > On 06/03/2023 18:22, Stefan Wahren wrote:
> >> From: Stefan Wahren <stefan.wahren@chargebyte.com>
> >>
> >> The ST IIS328DQ is an accelerometer sensor compatible with
> >> the existing ST sensor binding.
> > If it is compatible with existing binding, then make it compatible.
> > Although your driver change suggests it is not compatible...
> since the policy is to make the compatible so specific as possible, i
> will fix the wording here.
Driver changes are naming only - which we do want as that isn't discoverable
from the device but it will 'work' fine with a fallback compatible of
st,h3lis331dl-accel be it with wrong device naming exposed to userspace.
Hmm. That shouldn't have the postfix as it's not a multi device package
(which are the cases where we need postfix as they have multiple drivers
binding to different independent things in the one package / part number)
If someone wants to add a compatible of st,h3lis331dl and deprecate
the accel variant that would be fine, but wouldn't help us much here
for a fallback compatible and it's probably not worth the effort.
Historically we've not been doing fallback compatibles right in this
driver but it's probably not worth 'fixing' that for old devices
as the only real benefit would be things working nicely with old kernels.
Nice to not make it worse though.
So I'd like to see this fallback to st,h3lis331dl-accel
Jonathan
> >
> > Best regards,
> > Krzysztof
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-11 18:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 17:22 [PATCH 0/8] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-06 17:22 ` [PATCH 1/8] dt-bindings: vendor-prefixes: add chargebyte Stefan Wahren
2023-03-07 8:21 ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 2/8] dt-bindings: Add DS2482/DS2484 as trivial device Stefan Wahren
2023-03-07 8:21 ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 3/8] w1: ds2482: add i2c id for ds2484 Stefan Wahren
2023-03-06 17:22 ` [PATCH 4/8] dt-bindings: iio: st-sensors: Add IIS328DQ accelerometer Stefan Wahren
2023-03-07 8:23 ` Krzysztof Kozlowski
2023-03-07 17:27 ` Stefan Wahren
2023-03-11 18:06 ` Jonathan Cameron [this message]
2023-03-06 17:22 ` [PATCH 5/8] iio: accel: add support for IIS328DQ variant Stefan Wahren
2023-03-11 18:08 ` Jonathan Cameron
2023-03-06 17:22 ` [PATCH 6/8] dt-bindings: ARM: fsl: Add chargebyte Tarragon Stefan Wahren
2023-03-07 8:24 ` Krzysztof Kozlowski
2023-03-10 10:08 ` Stefan Wahren
2023-03-10 10:46 ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 7/8] ARM: dts: imx6ull: Add chargebyte Tarragon support Stefan Wahren
2023-03-07 8:30 ` Krzysztof Kozlowski
2023-03-07 17:25 ` Stefan Wahren
2023-03-08 8:44 ` Krzysztof Kozlowski
2023-03-06 17:22 ` [PATCH 8/8] ARM: imx_v6_v7_defconfig: Enable Tarragon peripheral drivers Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230311180640.4f975f78@jic23-huawei \
--to=jic23@kernel.org \
--cc=arnd@arndb.de \
--cc=denis.ciocca@st.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=stefan.wahren@chargebyte.com \
--cc=stefan.wahren@i2se.com \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox