From: Alexandre Mergnat <amergnat@baylibre.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: Guillaume La Roque <glaroque@baylibre.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support
Date: Wed, 12 Jul 2023 10:01:58 +0200 [thread overview]
Message-ID: <a335efdc-2ecb-c25a-7507-5ef2e19c5ca1@baylibre.com> (raw)
In-Reply-To: <14bed951-22ae-4aa8-5fcb-b2cd92ebdbef@linaro.org>
Hi Krzysztof,
Thanks for your review
On 12/07/2023 07:32, Krzysztof Kozlowski wrote:
> On 11/07/2023 17:36, Alexandre Mergnat wrote:
>> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution
snip
>> +
>> + dcdc-gpios: true
>
> From where does this come? Which schema defines it?
It's a miss. I will fix it and reset-gpios too by adding a maxItems and
a description.
>> +
>> + height-mm:
>> + const: 151
>> +
>> + iovcc-supply:
>> + description: Reference to the regulator powering the panel IO pins.
>> +
>> + reg:
>> + maxItems: 1
>> + description: DSI virtual channel
>> +
>> + reset-gpios: true
>> +
>> + port: true
>> +
>> + power-supply: true
>> +
>> + width-mm:
>> + const: 95
>> +
>> +additionalProperties: false
>> +
>> +required:
>> + - compatible
>> + - dcdc-gpios
>> + - iovcc-supply
>> + - reg
>> + - reset-gpios
>> + - port
>> + - power-supply
>
> Missing example.
I will add it.
--
Regards,
Alexandre
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-12 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 15:36 [PATCH 0/3] Add startek-kd070fhfid015 display support Alexandre Mergnat
2023-07-11 15:36 ` [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support Alexandre Mergnat
2023-07-11 18:24 ` Conor Dooley
2023-07-12 5:32 ` Krzysztof Kozlowski
2023-07-12 8:01 ` Alexandre Mergnat [this message]
2023-07-12 8:23 ` Krzysztof Kozlowski
2023-07-11 15:36 ` [PATCH 2/3] drm/panel: Support for startek-kd070fhfid015 MIPI-DSI panel amergnat
2023-07-11 15:36 ` [PATCH 3/3] arm64: defconfig: enable STARTEK KD070FHFID015 panel Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a335efdc-2ecb-c25a-7507-5ef2e19c5ca1@baylibre.com \
--to=amergnat@baylibre.com \
--cc=airlied@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=glaroque@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox