Re: [PATCH 1/2] dt-bindings: iommu: arm,smmu: Document optional interconnects property

[Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>]

On 5/18/2026 6:03 PM, Krzysztof Kozlowski wrote:
> On Sat, May 16, 2026 at 06:04:03PM +0530, Bibek Kumar Patro wrote:
>> Some SoC implementations require a bandwidth vote on an interconnect
> 
> Then this should be disallowed for other devices in "allOf:".
> 

As of now, we still are checking which all SoCs do not need this 
interconnects field. So would we need to add the allOf here for now?

>> path before the SMMU register space is accessible. Add the optional
>> 'interconnects' property to the binding to allow platform DT nodes
>> to describe this path.
>>
>> The arm-smmu driver uses these properties to vote for bandwidth before
>> accessing any SMMU registers and releases the vote on runtime suspend.
>>
>> Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
>> ---
>>   Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> index 06fb5c8e7547cb7a92823adc2772b94f747376a6..5cbf944f2d3e178b3723d4dbaa19ee0d33446979 100644
>> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
>> @@ -243,6 +243,15 @@ properties:
>>       minItems: 1
>>       maxItems: 3
>>   
>> +  interconnects:
>> +    maxItems: 1
>> +    description:
>> +      Optional interconnect path to the SMMU register space. On some SoCs
>> +      the SMMU registers are only accessible after a bandwidth vote has been
> 
> Drivers are irrelevant here, drop. Also first sentence is redundant.
> Schema says what is and what is not optional.
> 

Sure, got it. I will remove the "driver" quotation and "optional"
wording from both binding description and commit text.

Thanks & regards,
Bibek

> Best regards,
> Krzysztof
>