From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
kernel@collabora.com, Chen-Yu Tsai <wenst@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 14/19] arm64: dts: mediatek: asurada: Enable PCIe and add WiFi
Date: Mon, 6 Jan 2025 16:10:32 -0300 [thread overview]
Message-ID: <a58d5fa4-0d00-4ca1-941b-3ad69e65de80@notapiano> (raw)
In-Reply-To: <20250103211446.GA4063@bhelgaas>
On Fri, Jan 03, 2025 at 03:14:46PM -0600, Bjorn Helgaas wrote:
> On Wed, Jun 29, 2022 at 11:59:51AM -0400, Nícolas F. R. A. Prado wrote:
> > Enable MT8192's PCIe controller and add support for the MT7921e WiFi
> > card that is present on that bus for the Asurada platform.
>
> > +&pcie {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pcie_pins>;
> > +
> > + pcie0: pcie@0,0 {
> > + device_type = "pci";
> > + reg = <0x0000 0 0 0 0>;
> > + num-lanes = <1>;
> > + bus-range = <0x1 0x1>;
>
> Hi Nícolas, what's the purpose of this bus-range? IIUC this describes
> a Root Port, where we can read and configure the secondary/subordinate
> bus numbers from the RP config space, so it seems like we don't need
> to describe them here.
Hi Bjorn,
that was carried over from the downstream sources. I just tried removing it and
indeed I don't see any difference in the PCI log messages, or the bus number,
and the wifi works just fine. I can send a follow up patch removing it.
Thanks,
Nícolas
next prev parent reply other threads:[~2025-01-06 19:12 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 15:59 [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 01/19] dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 02/19] dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 03/19] arm64: dts: mediatek: Introduce MT8192-based Asurada board family Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 04/19] arm64: dts: mediatek: asurada: Document GPIO names Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 05/19] arm64: dts: mediatek: asurada: Add system-wide power supplies Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 06/19] arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 07/19] arm64: dts: mediatek: asurada: Add ChromeOS EC Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 08/19] arm64: dts: mediatek: asurada: Add keyboard mapping for the top row Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 09/19] arm64: dts: mediatek: asurada: Add Cr50 TPM Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 10/19] arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 11/19] arm64: dts: mediatek: asurada: Add I2C touchscreen Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 12/19] arm64: dts: mediatek: spherion: Add keyboard backlight Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 13/19] arm64: dts: mediatek: asurada: Enable XHCI Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 14/19] arm64: dts: mediatek: asurada: Enable PCIe and add WiFi Nícolas F. R. A. Prado
2025-01-03 21:14 ` Bjorn Helgaas
2025-01-06 19:10 ` Nícolas F. R. A. Prado [this message]
2025-01-06 20:56 ` Bjorn Helgaas
2025-01-07 12:04 ` Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 15/19] arm64: dts: mediatek: asurada: Add MT6359 PMIC Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 16/19] arm64: dts: mediatek: asurada: Add SPMI regulators Nícolas F. R. A. Prado
2022-06-29 15:59 ` [PATCH v4 17/19] arm64: dts: mediatek: asurada: Enable MMC Nícolas F. R. A. Prado
2022-07-01 10:38 ` Chen-Yu Tsai
2022-06-29 15:59 ` [PATCH v4 18/19] arm64: dts: mediatek: asurada: Enable SCP Nícolas F. R. A. Prado
2022-07-01 10:39 ` Chen-Yu Tsai
2022-06-29 15:59 ` [PATCH v4 19/19] arm64: dts: mediatek: asurada: Add SPI NOR flash memory Nícolas F. R. A. Prado
2022-07-01 10:39 ` Chen-Yu Tsai
2022-07-01 12:44 ` [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Chen-Yu Tsai
2022-07-01 15:01 ` Nícolas F. R. A. Prado
2022-07-05 4:03 ` Chen-Yu Tsai
2022-07-05 13:56 ` Nícolas F. R. A. Prado
2022-07-05 15:01 ` AngeloGioacchino Del Regno
2022-07-07 14:40 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a58d5fa4-0d00-4ca1-941b-3ad69e65de80@notapiano \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=helgaas@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox