From: Suman Anna <s-anna@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: devicetree@vger.kernel.org,
Grzegorz Jaszczyk <grzegorz.jaszczyk@linaro.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Roger Quadros <rogerq@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG nodes
Date: Thu, 21 Jan 2021 09:43:06 -0600 [thread overview]
Message-ID: <a664de6c-3018-c383-d82a-b84bdfb39102@ti.com> (raw)
In-Reply-To: <20210121153757.kuknwzrzc3xmnase@machine>
On 1/21/21 9:37 AM, Nishanth Menon wrote:
> On 13:48-20210114, Suman Anna wrote:
> [...]
>
>> +
>> + icssg1_intc: interrupt-controller@20000 {
>> + compatible = "ti,icssg-intc";
>> + reg = <0x20000 0x2000>;
>> + interrupt-controller;
>> + #interrupt-cells = <3>;
>> + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>;
>> + interrupt-names = "host_intr0", "host_intr1",
>> + "host_intr2", "host_intr3",
>> + "host_intr4", "host_intr5",
>> + "host_intr6", "host_intr7";
>
>
> Could you look at https://pastebin.ubuntu.com/p/rbZrv3sDFk/
>
Yes, I am aware of these, and I have already noted it in my cover-letter.
"Note that the interrupt nodes will generate a warning about missing
'#address-cells' when compiled using W=2, but adding that currently
fails the dtbs_check, so going with the dt binding compliance."
I have submitted two incremental patches, one against the binding [1] and
another against dts [2].
regards
Suman
[1]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115205819.19426-1-s-anna@ti.com/
[2]
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115210625.20427-1-s-anna@ti.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-21 15:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 19:48 [PATCH 0/2] Add ICSSG nodes on AM65x & J721E SoCs Suman Anna
2021-01-14 19:48 ` [PATCH 1/2] arm64: dts: ti: k3-am65-main: Add ICSSG nodes Suman Anna
2021-01-21 15:37 ` Nishanth Menon
2021-01-21 15:43 ` Suman Anna [this message]
2021-01-21 15:50 ` Nishanth Menon
2021-03-04 8:14 ` Vignesh Raghavendra
2021-01-14 19:48 ` [PATCH 2/2] arm64: dts: ti: k3-j721e-main: " Suman Anna
2021-01-21 15:38 ` Nishanth Menon
2021-01-21 15:43 ` Suman Anna
2021-03-04 8:27 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a664de6c-3018-c383-d82a-b84bdfb39102@ti.com \
--to=s-anna@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grzegorz.jaszczyk@linaro.org \
--cc=jan.kiszka@siemens.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=rogerq@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox