Re: [PATCH v2] SoC: mediatek: mt8188-mt6359: clean up a return in codec_init

["Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>]

On Wed, 2023-06-07 at 17:57 +0300, Dan Carpenter wrote:
>  This code triggers a Smatch static checker warning and does sort of
> look like an error path.
> 
> sound/soc/mediatek/mt8188/mt8188-mt6359.c:597
> mt8188_max98390_codec_init() warn: missing error code? 'ret'
> 
> However, returning 0 is intentional.  Make that explicit.

Hi Dan,

There are several similar instances in this file. If using 'return
ret;' is not recommended, should we update all of them simultaneously?

For instance, the value of 'ret' at the end of this function should
also be zero.

Thanks,
Trevor

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> v2: At first I thought this was an error path but it is a not.
> 
>  sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> index bc4b74970a46..5ad8d2a5bbc4 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> @@ -594,7 +594,7 @@ static int mt8188_max98390_codec_init(struct
> snd_soc_pcm_runtime *rtd)
>  }
>  
>  if (rtd->dai_link->num_codecs <= 2)
> -return ret;
> +return 0;
>  
>  /* add widgets/controls/dapm for rear speakers */
>  ret = snd_soc_dapm_new_controls(&card->dapm,
> mt8188_rear_spk_widgets,
> -- 
> 2.39.2
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel