Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Rosen Penev" <rosenp@gmail.com>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	"Rafał Miłecki" <zajec5@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>
Cc: "Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 00/17] ARM: dts: BCM5301X: describe switches and use gmac2 as the CPU port
Date: Wed, 18 Nov 2026 10:36:34 -0800	[thread overview]
Message-ID: <a97169fe-b537-4f1f-aa48-4e74f7e7195a@broadcom.com> (raw)
In-Reply-To: <20261118054758.132233-1-rosenp@gmail.com>

On 11/17/26 21:47, Rosen Penev wrote:
> This series describes the switch on six more BCM5301X boards, makes
> switch port 8 / gmac2 the CPU port on every board that has a single CPU
> port, and disables the GMACs that a board does not use.
> 
> Patches 1-8 describe the switch ports on the RT-AC56U, RT-AC68U, RT-N18U,
> R7000, EA6300 and Phicomm K3. They also set the WAN MAC address from
> nvram, so userspace doesn't have to. The EA6300 and K3 get an nvram node
> for that. The port mappings come from OpenWrt.
> 
> Patches 9-16 move the CPU port from port 5 (gmac0), or port 7 (gmac1) on
> the RT-AC87U, to port 8 (gmac2). Port 8 is the switch's IMP port, and
> gmac2 is present on all Northstar SoCs. The nvram MAC address moves to
> gmac2 as well. Patch 11 is a fix: on the DIR-885L the MAC address has been
> on gmac0 since port 8 became its only CPU port.
> 
> Patch 17 disables all GMACs in bcm-ns.dtsi and enables only the ones each
> board uses. Boards with a switch node enable the GMACs behind their CPU
> ports. Boards without one enable gmac2. Boards with several CPU ports
> (RT-AC3100, RT-AC3200, RT-AC5300, RT-AC88U, WXR-1750DHP) keep them all.
> 
> Compile-tested only. Every patch builds, and dtbs_check output for all
> BCM5301X boards is unchanged by the series.
> 
> An AI coding assistant (Claude Code, Claude Opus 5.5) was used to review
> the series, write patches 11-16 and parts of 17, check the board
> descriptions against OpenWrt, and draft the commit messages and this
> cover letter.

Thanks for doing that work, I reviewed it and it looks good to me, I do 
wonder whether we don't want to just switch all of the devices into a 
single commit because there is not much point to do it on a board by 
board basis, it's easier for review, but not necessarily to manage a as 
a prerequisite for additional work (e.g.: flow accelerator support, or 
preferred CPU port election with b53).
-- 
Florian


      parent reply	other threads:[~2026-11-18 18:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  5:47 [PATCH 00/17] ARM: dts: BCM5301X: describe switches and use gmac2 as the CPU port Rosen Penev
2026-11-18  5:47 ` [PATCH 01/17] ARM: dts: BCM5301X: AC56U: specify switch Rosen Penev
2026-11-18  5:47 ` [PATCH 02/17] ARM: dts: BCM5301X: AC68U: " Rosen Penev
2026-11-18  5:47 ` [PATCH 03/17] ARM: dts: BCM5301X: N18U: " Rosen Penev
2026-11-18  5:47 ` [PATCH 04/17] ARM: dts: BCM5301X: R7000: " Rosen Penev
2026-11-18  5:47 ` [PATCH 05/17] ARM: dts: BCM5301X: EA6300: set gmac2 MAC address from nvram Rosen Penev
2026-11-18  5:47 ` [PATCH 06/17] ARM: dts: BCM5301X: EA6300: specify switch Rosen Penev
2026-11-18  5:47 ` [PATCH 07/17] ARM: dts: BCM5301X: phicomm-k3: add nvram node Rosen Penev
2026-11-18  5:47 ` [PATCH 08/17] ARM: dts: BCM5301X: phicomm-k3: specify switch Rosen Penev
2026-11-18  5:47 ` [PATCH 09/17] ARM: dts: BCM5301X: AC87U: use gmac2 Rosen Penev
2026-11-18  5:47 ` [PATCH 10/17] ARM: dts: BCM5301X: SR400AC: " Rosen Penev
2026-11-18  5:47 ` [PATCH 11/17] ARM: dts: BCM5301X: DIR-885L: " Rosen Penev
2026-11-18  5:47 ` [PATCH 12/17] ARM: dts: BCM5301X: Luxul: " Rosen Penev
2026-11-18  5:47 ` [PATCH 13/17] ARM: dts: BCM5301X: Buffalo: " Rosen Penev
2026-11-18  5:47 ` [PATCH 14/17] ARM: dts: BCM5301X: R6250: " Rosen Penev
2026-11-18  5:47 ` [PATCH 15/17] ARM: dts: BCM5301X: Meraki MR26/MR32: " Rosen Penev
2026-11-18  5:47 ` [PATCH 16/17] ARM: dts: BCM5301X: BCM953012ER: " Rosen Penev
2026-11-18  5:47 ` [PATCH 17/17] ARM: dts: BCM5301X: enable GMACs in boards that use them Rosen Penev
2026-11-18 18:36 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a97169fe-b537-4f1f-aa48-4e74f7e7195a@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rafal@milecki.pl \
    --cc=robh@kernel.org \
    --cc=rosenp@gmail.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox