From: Mark Rutland <mark.rutland@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
daniel.kiss@arm.com, david.spickett@arm.com,
luis.machado@arm.com, maz@kernel.org, richard.sandiford@arm.com,
sander.desmalen@arm.com, tabba@google.com, tamas.petz@arm.com,
tkjos@google.com, will@kernel.org, yury.khrustalev@arm.com
Subject: Re: [PATCH 00/20] arm64: FPSIMD/SVE/SME fixes + re-eanble SME
Date: Wed, 7 May 2025 10:56:54 +0100 [thread overview]
Message-ID: <aBstn-9GClsAmlXC@J2N7QTR9R3> (raw)
In-Reply-To: <aBq7-_VhS8DXFgYL@finisterre.sirena.org.uk>
On Wed, May 07, 2025 at 10:48:43AM +0900, Mark Brown wrote:
> On Tue, May 06, 2025 at 04:25:03PM +0100, Mark Rutland wrote:
> > Hi all,
> >
> > These patches fix a number of problems in the FPSIMD/SVE/SME code, and
> > finally re-enable SME support.
>
> I've given everything a first pass and aside from previously noted
> changelog nit on patch 17 which don't affect the resulting change this
> all looks good.
Thanks.
Since you haven't commented on patch 17 here, and this is the first
version of that patch, I assume that by "previously noted" you're
referring to the ptrace ABI discussion we had when I posted the
preparatory fixes, i.e.
https://lore.kernel.org/linux-arm-kernel/20250404174435.3288106-1-mark.rutland@arm.com/
https://lore.kernel.org/linux-arm-kernel/45cb5ce9-39af-4c42-b68d-fa506b67bc55@sirena.org.uk/
https://lore.kernel.org/linux-arm-kernel/Z_VS5wvn0C7tdjbo@J2N7QTR9R3.cambridge.arm.com/
https://lore.kernel.org/linux-arm-kernel/879811da-d0f0-4b0b-bca4-df68ff9bf394@sirena.org.uk/#t
If you have a specific objection, I can consider massaging the wording,
but as it stands I don't see any problem with the commit message on
patch 17. There clearly was an incorrect assumption during development,
as indicated by the code, the comments, and the documentation. Providing
that context makes review *much* easier.
> I'm on holiday for a week and a bit more so probably
> won't have time to review properly, other than a couple of the smaller
> patches.
No problem. If it's possible to throw any automated testing at this,
that'd be much appreciated.
Mark.
next prev parent reply other threads:[~2025-05-07 10:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 15:25 [PATCH 00/20] arm64: FPSIMD/SVE/SME fixes + re-eanble SME Mark Rutland
2025-05-06 15:25 ` [PATCH 01/20] kselftest/arm64: fp-ptrace: Fix expected FPMR value when PSTATE.SM is changed Mark Rutland
2025-05-06 15:25 ` [PATCH 02/20] arm64/fpsimd: Do not discard modified SVE state Mark Rutland
2025-05-06 15:25 ` [PATCH 03/20] arm64/fpsimd: signal: Clear PSTATE.SM when restoring FPSIMD frame only Mark Rutland
2025-05-07 12:46 ` Will Deacon
2025-05-07 14:01 ` Mark Rutland
2025-05-07 14:39 ` Will Deacon
2025-05-06 15:25 ` [PATCH 04/20] arm64/fpsimd: signal: Mandate SVE payload for streaming-mode state Mark Rutland
2025-05-07 0:59 ` Mark Brown
2025-05-07 12:59 ` Will Deacon
2025-05-07 14:21 ` Mark Rutland
2025-05-07 14:29 ` Will Deacon
2025-05-07 15:02 ` Mark Rutland
2025-05-07 16:14 ` Will Deacon
2025-05-06 15:25 ` [PATCH 05/20] arm64/fpsimd: ptrace: Consistently handle partial writes to NT_ARM_(S)SVE Mark Rutland
2025-05-06 15:25 ` [PATCH 06/20] arm64/fpsimd: Clarify sve_sync_*() functions Mark Rutland
2025-05-06 15:25 ` [PATCH 07/20] arm64/fpsimd: Factor out {sve,sme}_state_size() helpers Mark Rutland
2025-05-06 15:25 ` [PATCH 08/20] arm64/fpsimd: Add task_smstop_sm() Mark Rutland
2025-05-06 15:25 ` [PATCH 09/20] arm64/fpsimd: signal: Use SMSTOP behaviour in setup_return() Mark Rutland
2025-05-06 15:25 ` [PATCH 10/20] arm64/fpsimd: Remove redundant task->mm check Mark Rutland
2025-05-06 15:25 ` [PATCH 11/20] arm64/fpsimd: Consistently preserve FPSIMD state during clone() Mark Rutland
2025-05-06 15:25 ` [PATCH 12/20] arm64/fpsimd: Clear PSTATE.SM " Mark Rutland
2025-05-06 15:25 ` [PATCH 13/20] arm64/fpsimd: Make clone() compatible with ZA lazy saving Mark Rutland
2025-05-07 14:58 ` Will Deacon
2025-05-07 15:22 ` Mark Rutland
2025-05-07 16:11 ` Will Deacon
2025-05-07 17:21 ` Mark Rutland
2025-05-07 15:57 ` Yury Khrustalev
2025-05-06 15:25 ` [PATCH 14/20] arm64/fpsimd: ptrace/prctl: Ensure VL changes do not resurrect stale data Mark Rutland
2025-05-06 15:25 ` [PATCH 15/20] arm64/fpsimd: ptrace/prctl: Ensure VL changes leave task in a valid state Mark Rutland
2025-05-07 16:12 ` Will Deacon
2025-05-07 17:10 ` Mark Rutland
2025-05-08 10:31 ` Will Deacon
2025-05-06 15:25 ` [PATCH 16/20] arm64/fpsimd: ptrace: Save task state before generating SVE header Mark Rutland
2025-05-06 15:25 ` [PATCH 17/20] arm64/fpsimd: ptrace: Do not present register data for inactive mode Mark Rutland
2025-05-06 15:25 ` [PATCH 18/20] arm64/fpsimd: ptrace: Mandate SVE payload for streaming-mode state Mark Rutland
2025-05-07 1:09 ` Mark Brown
2025-05-06 15:25 ` [PATCH 19/20] arm64/fpsimd: ptrace: Gracefully handle errors Mark Rutland
2025-05-07 16:32 ` Will Deacon
2025-05-08 12:12 ` Mark Rutland
2025-05-06 15:25 ` [PATCH 20/20] arm64/fpsimd: Allow CONFIG_ARM64_SME to be selected Mark Rutland
2025-05-07 1:48 ` [PATCH 00/20] arm64: FPSIMD/SVE/SME fixes + re-eanble SME Mark Brown
2025-05-07 9:56 ` Mark Rutland [this message]
2025-05-07 11:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBstn-9GClsAmlXC@J2N7QTR9R3 \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.kiss@arm.com \
--cc=david.spickett@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=luis.machado@arm.com \
--cc=maz@kernel.org \
--cc=richard.sandiford@arm.com \
--cc=sander.desmalen@arm.com \
--cc=tabba@google.com \
--cc=tamas.petz@arm.com \
--cc=tkjos@google.com \
--cc=will@kernel.org \
--cc=yury.khrustalev@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox