public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Yeoreum Yun <yeoreum.yun@arm.com>
Cc: catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org,
	oliver.upton@linux.dev, ardb@kernel.org, frederic@kernel.org,
	james.morse@arm.com, joey.gouly@arm.com,
	scott@os.amperecomputing.com, maz@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/7] arm64/Kconfig: add LSUI Kconfig
Date: Mon, 21 Jul 2025 11:52:16 +0100	[thread overview]
Message-ID: <aH4b4G2DSxG5FnHb@J2N7QTR9R3> (raw)
In-Reply-To: <20250721083618.2743569-4-yeoreum.yun@arm.com>

On Mon, Jul 21, 2025 at 09:36:14AM +0100, Yeoreum Yun wrote:
> Since Armv9.6, FEAT_LSUI supplies the load/store instructions for
> previleged level to access to access user memory without clearing
> PSTATE.PAN bit.
> It's enough to add CONFIG_AS_HAS_LSUI only because the code for LUSI uses

Nit: s/LUSI/LSUI/

> indiviual `.arch_extension` entries.

Nit: s/indiviual/individual/

> 
> Signed-off-by: Yeoreum Yun <yeoreum.yun@arm.com>
> ---
>  arch/arm64/Kconfig | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 393d71124f5d..c0beb44ed5b8 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -2238,6 +2238,15 @@ config ARM64_GCS
>  
>  endmenu # "v9.4 architectural features"
>  
> +config AS_HAS_LSUI
> +	def_bool $(as-instr,.arch_extension lsui)
> +	help
> +	 Unprivileged Load Store is an extension to introduce unprivileged
> +	 variants of load and store instructions so that clearing PSTATE.PAN
> +	 is never required in privileged mode.
> +	 This feature is available with clang version 20 and later and not yet
> +	 supported by gcc.

I don't think we need to describe the feature in detail for the AS_HAS_*
config symbol; I think all we need to say is:

	Supported by LLVM 20 and later, not yet supported by GNU AS.

Otherwise this looks fine.

Mark.

> +
>  config ARM64_SVE
>  	bool "ARM Scalable Vector Extension support"
>  	default y
> -- 
> LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}
> 
> 


  reply	other threads:[~2025-07-21 12:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21  8:36 [PATCH v4 0/7] support FEAT_LSUI and apply it on futex atomic ops Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 1/7] arm64: cpufeature: add FEAT_LSUI Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 2/7] KVM/arm64: expose FEAT_LSUI to guest Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 3/7] arm64/Kconfig: add LSUI Kconfig Yeoreum Yun
2025-07-21 10:52   ` Mark Rutland [this message]
2025-07-22  8:17     ` Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 4/7] arm64/futex: move futex atomic logic with clearing PAN bit Yeoreum Yun
2025-07-21 10:56   ` Mark Rutland
2025-07-22  8:21     ` Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 5/7] arm64/futex: add futex atomic operation with FEAT_LSUI Yeoreum Yun
2025-07-21 11:03   ` Mark Rutland
2025-07-22  8:34     ` Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 6/7] arm64/asm: introduce lsui.h Yeoreum Yun
2025-07-21  8:36 ` [PATCH v4 7/7] arm64/futex: support futex with FEAT_LSUI Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH4b4G2DSxG5FnHb@J2N7QTR9R3 \
    --to=mark.rutland@arm.com \
    --cc=ardb@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=frederic@kernel.org \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=scott@os.amperecomputing.com \
    --cc=will@kernel.org \
    --cc=yeoreum.yun@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox