Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Isaac Scott <isaac.scott@ideasonboard.com>
Cc: laurent.pinchart@ideasonboard.com, rmfrfs@gmail.com,
	martink@posteo.de, kernel@puri.sm, mchehab@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	linux-media@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, hverkuil@kernel.org,
	nicolas.dufresne@collabora.com, sakari.ailus@linux.intel.com,
	tomi.valkeinen@ideasonboard.com, jonas@kwiboo.se,
	dan.scally+renesas@ideasonboard.com, m.szyprowski@samsung.com,
	mehdi.djait@linux.intel.com,
	niklas.soderlund+renesas@ragnatech.se
Subject: Re: [PATCH v2 3/3] media: imx-mipi-csis: Get number of active lanes via mbus_config
Date: Wed, 3 Sep 2025 11:35:16 -0400	[thread overview]
Message-ID: <aLhgNP0UMAj3Cpzi@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20250903102243.1563527-4-isaac.scott@ideasonboard.com>

On Wed, Sep 03, 2025 at 11:22:42AM +0100, Isaac Scott wrote:
> The number of lanes actively used by a MIPI CSI transmitter may differ
> from that which is defined in device tree. As such, call on
> v4l2_get_active_data_lanes to check if the driver reports a

function need (), v4l2_get_active_data_lanes()

> differing number of lanes to device tree, and use that number of active
> lanes.
>
> If the number of active data lanes is invalid, or the op is not
> supported, it will use the number of lanes defined in device tree.

remove "it will" to keep simple.

Frank
>
> Signed-off-by: Isaac Scott <isaac.scott@ideasonboard.com>
> ---
>  drivers/media/platform/nxp/imx-mipi-csis.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c
> index fc89325f2f94..985be511bcd0 100644
> --- a/drivers/media/platform/nxp/imx-mipi-csis.c
> +++ b/drivers/media/platform/nxp/imx-mipi-csis.c
> @@ -967,6 +967,9 @@ static int mipi_csis_s_stream(struct v4l2_subdev *sd, int enable)
>  	format = v4l2_subdev_state_get_format(state, CSIS_PAD_SINK);
>  	csis_fmt = find_csis_format(format->code);
>
> +	csis->bus.num_data_lanes = v4l2_get_active_data_lanes(csis->source.pad,
> +							      csis->max_data_lanes);
> +
>  	ret = mipi_csis_calculate_params(csis, csis_fmt);
>  	if (ret < 0)
>  		goto err_unlock;
> --
> 2.43.0
>


  reply	other threads:[~2025-09-03 22:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-03 10:22 [PATCH v2 0/3] media: imx-mipi-csis: Get the number of active lanes from mbus_config Isaac Scott
2025-09-03 10:22 ` [PATCH v2 1/3] media: v4l: Add helper to get number of active lanes via a pad Isaac Scott
2025-09-03 15:30   ` Frank Li
2025-09-04  8:33   ` Niklas Söderlund
2025-09-04  8:44   ` Sakari Ailus
2025-09-04 15:07     ` Laurent Pinchart
2025-09-15  9:28     ` Isaac Scott
2025-09-03 10:22 ` [PATCH v2 2/3] media: imx-mipi-csis: Store the number of data_lanes configured in dt Isaac Scott
2025-09-03 15:33   ` Frank Li
2025-09-04 15:01     ` Laurent Pinchart
2025-09-15  9:24       ` Isaac Scott
2025-09-03 10:22 ` [PATCH v2 3/3] media: imx-mipi-csis: Get number of active lanes via mbus_config Isaac Scott
2025-09-03 15:35   ` Frank Li [this message]
2025-09-15  9:26     ` Isaac Scott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aLhgNP0UMAj3Cpzi@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=dan.scally+renesas@ideasonboard.com \
    --cc=festevam@gmail.com \
    --cc=hverkuil@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=isaac.scott@ideasonboard.com \
    --cc=jonas@kwiboo.se \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=martink@posteo.de \
    --cc=mchehab@kernel.org \
    --cc=mehdi.djait@linux.intel.com \
    --cc=nicolas.dufresne@collabora.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=rmfrfs@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    --cc=tomi.valkeinen@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox