Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Frank Li <Frank.li@nxp.com>
To: Yannic Moog <y.moog@phytec.de>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	upstream@lists.phytec.de, devicetree@vger.kernel.org,
	imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Stefan Riedmueller <s.riedmueller@phytec.de>,
	Teresa Remmet <t.remmet@phytec.de>
Subject: Re: [PATCH 3/4] arm64: dts: imx8mp-phyboard-pollux: Enable i2c3
Date: Mon, 20 Oct 2025 11:38:16 -0400	[thread overview]
Message-ID: <aPZXaC8HL+Rg7rax@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20251020-imx8mp-dts-additions-v1-3-ea9ac5652b8b@phytec.de>

On Mon, Oct 20, 2025 at 03:11:24PM +0200, Yannic Moog wrote:
> From: Stefan Riedmueller <s.riedmueller@phytec.de>
>
> On the phyBOARD-Pollux the i2c3 node is used on the CSI1 interface to
> connect to imaging sensors. Thus define it so it can be easily enabled if
> required.
Nit:

The i2c3 of the phyBOARD-Pollux is used ...

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> Signed-off-by: Yannic Moog <y.moog@phytec.de>
> ---
>  .../dts/freescale/imx8mp-phyboard-pollux-rdk.dts   | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> index 6203e39bc01be476f16f5ac80b6365bce150ae37..7d34b820e3213a3832c5be47444d4e9c636a6202 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-rdk.dts
> @@ -228,6 +228,15 @@ led-3 {
>  	};
>  };
>
> +&i2c3 {
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default", "gpio";
> +	pinctrl-0 = <&pinctrl_i2c3>;
> +	pinctrl-1 = <&pinctrl_i2c3_gpio>;
> +	sda-gpios = <&gpio5 18 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +	scl-gpios = <&gpio5 19 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> +};
> +
>  &ldb_lvds_ch1 {
>  	remote-endpoint = <&panel1_in>;
>  };
> @@ -442,6 +451,20 @@ MX8MP_IOMUXC_I2C2_SDA__GPIO5_IO17	0x1e2
>  		>;
>  	};
>
> +	pinctrl_i2c3: i2c3grp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_I2C3_SCL__I2C3_SCL		0x400001c2
> +			MX8MP_IOMUXC_I2C3_SDA__I2C3_SDA		0x400001c2
> +		>;
> +	};
> +
> +	pinctrl_i2c3_gpio: i2c3gpiogrp {
> +		fsl,pins = <
> +			MX8MP_IOMUXC_I2C3_SCL__GPIO5_IO18	0x1e2
> +			MX8MP_IOMUXC_I2C3_SDA__GPIO5_IO19	0x1e2
> +		>;
> +	};
> +
>  	pinctrl_lvds1: lvds1grp {
>  		fsl,pins = <
>  			MX8MP_IOMUXC_SD2_WP__GPIO2_IO20		0x12
>
> --
> 2.51.0
>


  reply	other threads:[~2025-10-20 15:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-20 13:11 [PATCH 0/4] arm64: dts: additions for phyboard-pollux Yannic Moog
2025-10-20 13:11 ` [PATCH 1/4] arm64: dts: imx8mp-phyboard-pollux: add fan-supply Yannic Moog
2025-10-20 15:35   ` Frank Li
2025-10-20 13:11 ` [PATCH 2/4] arm64: dts: imx8mp-phycore-som: add spi-nor supply vcc Yannic Moog
2025-10-20 15:36   ` Frank Li
2025-10-22  6:18     ` Yannic Moog
2025-10-20 13:11 ` [PATCH 3/4] arm64: dts: imx8mp-phyboard-pollux: Enable i2c3 Yannic Moog
2025-10-20 15:38   ` Frank Li [this message]
2025-10-22  6:20     ` Yannic Moog
2025-10-20 13:11 ` [PATCH 4/4] arm64: dts: imx8mp-phyboard-pollux: add PEB-WLBT-05 expansion board Yannic Moog
2025-10-20 15:40   ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPZXaC8HL+Rg7rax@lizhi-Precision-Tower-5810 \
    --to=frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.riedmueller@phytec.de \
    --cc=shawnguo@kernel.org \
    --cc=t.remmet@phytec.de \
    --cc=upstream@lists.phytec.de \
    --cc=y.moog@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox