Re: [PATCH 2/4] arm64: dts: imx8mp-phycore-som: add spi-nor supply vcc

[Yannic Moog <y.moog@phytec.de>]

On Mon, 2025-10-20 at 11:36 -0400, Frank Li wrote:
> On Mon, Oct 20, 2025 at 03:11:23PM +0200, Yannic Moog wrote:
> > The spi flash on the SoM is missing its vcc supply definition. Add
> > missing regulator which supplies the flash with 1.8V.
> > 
> > Signed-off-by: Yannic Moog <y.moog@phytec.de>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > index 88831c0fbb7be3db18910385e4e15691b1c74ef2..d370e2a3a00c5e3e91a606ac0fbed30cf5e6f9b2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
> > @@ -28,6 +28,15 @@ reg_vdd_io: regulator-vdd-io {
> >  		regulator-min-microvolt = <3300000>;
> >  		regulator-name = "VDD_IO";
> >  	};
> > +
> > +	reg_vdd_1v8: regulator-vdd-1v8 {
> > +		compatible = "regulator-fixed";
> > +		regulator-always-on;
> > +		regulator-boot-on;
> 
> Needn't regulator-always-on and regulator-boot-on because it is refered
> by flash@0.

I added these properties to make it clear for the reader that this regulator is not Software
controlled and should not be disabled. Imo this is part of hardware description.
Should I remove the properties?

Yannic

> 
> Frank
> 
> > +		regulator-max-microvolt = <1800000>;
> > +		regulator-min-microvolt = <1800000>;
> > +		regulator-name = "VDD_1V8";
> > +	};
> >  };
> > 
> >  &A53_0 {
> > @@ -83,6 +92,7 @@ som_flash: flash@0 {
> >  		spi-max-frequency = <80000000>;
> >  		spi-rx-bus-width = <4>;
> >  		spi-tx-bus-width = <1>;
> > +		vcc-supply = <&reg_vdd_1v8>;
> >  	};
> >  };
> > 
> > 
> > --
> > 2.51.0
> >