public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ARM: multi_v7_defconfig: Enable RESET_GPIO driver
       [not found] <CGME20251103140555eucas1p16d2f5ab4ed02527da37afd1bd48553a2@eucas1p1.samsung.com>
@ 2025-11-03 14:05 ` Marek Szyprowski
  2025-11-03 14:52   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2025-11-03 14:05 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Marek Szyprowski, Russell King, Krzysztof Kozlowski,
	Arnd Bergmann, Wolfram Sang, Philipp Zabel, Bartosz Golaszewski

Commit 25d4d4604d01 ("reset: always bail out on missing RESET_GPIO
driver") reworked GPIO-based reset controller initialization, so now
RESET_GPIO driver is required to properly instantiate MMC device for
most of WLAN and SDIO chips.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 12f706e2ded5..5c6c4cecc54f 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -1200,6 +1200,7 @@ CONFIG_PWM_TEGRA=y
 CONFIG_PWM_TIECAP=m
 CONFIG_PWM_VT8500=y
 CONFIG_KEYSTONE_IRQ=y
+CONFIG_RESET_GPIO=y
 CONFIG_RESET_MCHP_SPARX5=y
 CONFIG_RESET_SCMI=y
 CONFIG_RESET_TI_SCI=m
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Enable RESET_GPIO driver
  2025-11-03 14:05 ` [PATCH] ARM: multi_v7_defconfig: Enable RESET_GPIO driver Marek Szyprowski
@ 2025-11-03 14:52   ` Krzysztof Kozlowski
  2025-11-03 17:12     ` Wolfram Sang
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-03 14:52 UTC (permalink / raw)
  To: Marek Szyprowski, linux-arm-kernel
  Cc: Russell King, Arnd Bergmann, Wolfram Sang, Philipp Zabel,
	Bartosz Golaszewski

On 03/11/2025 15:05, Marek Szyprowski wrote:
> Commit 25d4d4604d01 ("reset: always bail out on missing RESET_GPIO
> driver") reworked GPIO-based reset controller initialization, so now
> RESET_GPIO driver is required to properly instantiate MMC device for
> most of WLAN and SDIO chips.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

You should sent all this as one patchset, so we don't need to repeat
same objections to every email.

25d4d4604d01 is wrong and it breaks platforms. defconfig cannot fix that.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: multi_v7_defconfig: Enable RESET_GPIO driver
  2025-11-03 14:52   ` Krzysztof Kozlowski
@ 2025-11-03 17:12     ` Wolfram Sang
  0 siblings, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-11-03 17:12 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Marek Szyprowski, linux-arm-kernel, Russell King, Arnd Bergmann,
	Philipp Zabel, Bartosz Golaszewski

On Mon, Nov 03, 2025 at 03:52:33PM +0100, Krzysztof Kozlowski wrote:
> On 03/11/2025 15:05, Marek Szyprowski wrote:
> > Commit 25d4d4604d01 ("reset: always bail out on missing RESET_GPIO
> > driver") reworked GPIO-based reset controller initialization, so now
> > RESET_GPIO driver is required to properly instantiate MMC device for
> > most of WLAN and SDIO chips.
> > 
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> You should sent all this as one patchset, so we don't need to repeat
> same objections to every email.
> 
> 25d4d4604d01 is wrong and it breaks platforms. defconfig cannot fix that.

We are reverting the offending commits now, so these patches will not be
needed.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-03 17:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CGME20251103140555eucas1p16d2f5ab4ed02527da37afd1bd48553a2@eucas1p1.samsung.com>
2025-11-03 14:05 ` [PATCH] ARM: multi_v7_defconfig: Enable RESET_GPIO driver Marek Szyprowski
2025-11-03 14:52   ` Krzysztof Kozlowski
2025-11-03 17:12     ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox