From: Frank Li <Frank.li@nxp.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: chester62515@gmail.com, mbrugger@suse.com,
ghennadi.procopciuc@oss.nxp.com, s32@nxp.com,
bhelgaas@google.com, jingoohan1@gmail.com, lpieralisi@kernel.org,
kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, Ionut.Vicovan@nxp.com,
larisa.grigore@nxp.com, Ghennadi.Procopciuc@nxp.com,
ciprianmarian.costea@nxp.com, bogdan.hamciuc@nxp.com,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, cassel@kernel.org
Subject: Re: [PATCH 2/4 v5] PCI: dw: Add more registers and bitfield definition
Date: Tue, 18 Nov 2025 11:54:37 -0500 [thread overview]
Message-ID: <aRykzbnsMFFb1Kbo@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <20251118160238.26265-3-vincent.guittot@linaro.org>
On Tue, Nov 18, 2025 at 05:02:36PM +0100, Vincent Guittot wrote:
> Add new registers and bitfield definition:
> - GEN3_RELATED_OFF_EQ_PHASE_2_3 field of GEN3_RELATED_OFF
> - 3 Coherency control registers
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
> drivers/pci/controller/dwc/pcie-designware.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> index e995f692a1ec..e60b77f1b5e6 100644
> --- a/drivers/pci/controller/dwc/pcie-designware.h
> +++ b/drivers/pci/controller/dwc/pcie-designware.h
> @@ -121,6 +121,7 @@
>
> #define GEN3_RELATED_OFF 0x890
> #define GEN3_RELATED_OFF_GEN3_ZRXDC_NONCOMPL BIT(0)
> +#define GEN3_RELATED_OFF_EQ_PHASE_2_3 BIT(9)
> #define GEN3_RELATED_OFF_RXEQ_RGRDLESS_RXTS BIT(13)
> #define GEN3_RELATED_OFF_GEN3_EQ_DISABLE BIT(16)
> #define GEN3_RELATED_OFF_RATE_SHADOW_SEL_SHIFT 24
> @@ -138,6 +139,13 @@
> #define GEN3_EQ_FMDC_MAX_PRE_CURSOR_DELTA GENMASK(13, 10)
> #define GEN3_EQ_FMDC_MAX_POST_CURSOR_DELTA GENMASK(17, 14)
>
> +#define COHERENCY_CONTROL_1_OFF 0x8E0
> +#define CFG_MEMTYPE_BOUNDARY_LOW_ADDR_MASK GENMASK(31, 2)
> +#define CFG_MEMTYPE_VALUE BIT(0)
> +
> +#define COHERENCY_CONTROL_2_OFF 0x8E4
> +#define COHERENCY_CONTROL_3_OFF 0x8E8
> +
> #define PCIE_PORT_MULTI_LANE_CTRL 0x8C0
> #define PORT_MLTI_UPCFG_SUPPORT BIT(7)
>
> --
> 2.43.0
>
next prev parent reply other threads:[~2025-11-18 16:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 16:02 [PATCH 0/4 v5] PCI: s32g: Add support for PCIe controller Vincent Guittot
2025-11-18 16:02 ` [PATCH 1/4 v5] dt-bindings: PCI: s32g: Add NXP " Vincent Guittot
2025-11-18 16:52 ` Frank Li
2025-11-20 11:27 ` Manivannan Sadhasivam
2025-11-20 15:23 ` Rob Herring (Arm)
2025-11-18 16:02 ` [PATCH 2/4 v5] PCI: dw: Add more registers and bitfield definition Vincent Guittot
2025-11-18 16:54 ` Frank Li [this message]
2025-11-18 16:02 ` [PATCH 3/4 v5] PCI: s32g: Add initial PCIe support (RC) Vincent Guittot
2025-11-18 17:01 ` Frank Li
2025-11-20 7:25 ` Vincent Guittot
2025-11-20 8:22 ` Manivannan Sadhasivam
2025-11-20 9:06 ` Vincent Guittot
2025-11-20 10:25 ` Manivannan Sadhasivam
2025-11-20 17:57 ` Vincent Guittot
2025-11-18 16:02 ` [PATCH 4/4 v5] MAINTAINERS: Add MAINTAINER for NXP S32G PCIe driver Vincent Guittot
2025-11-26 19:42 ` Ghennadi Procopciuc
2025-11-26 20:17 ` Ciprian Marian Costea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRykzbnsMFFb1Kbo@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=Ionut.Vicovan@nxp.com \
--cc=bhelgaas@google.com \
--cc=bogdan.hamciuc@nxp.com \
--cc=cassel@kernel.org \
--cc=chester62515@gmail.com \
--cc=ciprianmarian.costea@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=mbrugger@suse.com \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox