public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/2] crypto: atmel-ecc - add support for atecc608b
@ 2026-03-30 10:08 Thorsten Blum
  2026-04-12  5:51 ` Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Thorsten Blum @ 2026-03-30 10:08 UTC (permalink / raw)
  To: Herbert Xu, David S. Miller, Nicolas Ferre, Alexandre Belloni,
	Claudiu Beznea
  Cc: Thorsten Blum, linux-crypto, linux-arm-kernel, linux-kernel

Tested on hardware with an ATECC608B at 0x60. The device binds
successfully, passes the driver's sanity check, and registers the
ecdh-nist-p256 KPP algorithm.

The hardware ECDH path was also exercised using a minimal KPP test
module, covering private key generation, public key derivation, and
shared secret computation.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/crypto/atmel-ecc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index b6a77c8d439c..5793e0c44113 100644
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -371,6 +371,8 @@ static void atmel_ecc_remove(struct i2c_client *client)
 static const struct of_device_id atmel_ecc_dt_ids[] = {
 	{
 		.compatible = "atmel,atecc508a",
+	}, {
+		.compatible = "atmel,atecc608b",
 	}, {
 		/* sentinel */
 	}
@@ -380,6 +382,7 @@ MODULE_DEVICE_TABLE(of, atmel_ecc_dt_ids);
 
 static const struct i2c_device_id atmel_ecc_id[] = {
 	{ "atecc508a" },
+	{ "atecc608b" },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, atmel_ecc_id);


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] crypto: atmel-ecc - add support for atecc608b
  2026-03-30 10:08 [PATCH 1/2] crypto: atmel-ecc - add support for atecc608b Thorsten Blum
@ 2026-04-12  5:51 ` Herbert Xu
  2026-04-12  7:18   ` Thorsten Blum
  0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2026-04-12  5:51 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: David S. Miller, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
	linux-crypto, linux-arm-kernel, linux-kernel

On Mon, Mar 30, 2026 at 12:08:00PM +0200, Thorsten Blum wrote:
> Tested on hardware with an ATECC608B at 0x60. The device binds
> successfully, passes the driver's sanity check, and registers the
> ecdh-nist-p256 KPP algorithm.
> 
> The hardware ECDH path was also exercised using a minimal KPP test
> module, covering private key generation, public key derivation, and
> shared secret computation.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/crypto/atmel-ecc.c | 3 +++
>  1 file changed, 3 insertions(+)

Is there supposed to be a 2/2 or should I apply this patch on its
own?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] crypto: atmel-ecc - add support for atecc608b
  2026-04-12  5:51 ` Herbert Xu
@ 2026-04-12  7:18   ` Thorsten Blum
  2026-04-12  8:37     ` Herbert Xu
  0 siblings, 1 reply; 4+ messages in thread
From: Thorsten Blum @ 2026-04-12  7:18 UTC (permalink / raw)
  To: Herbert Xu
  Cc: David S. Miller, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
	linux-crypto, linux-arm-kernel, linux-kernel

On Sun, Apr 12, 2026 at 01:51:10PM +0800, Herbert Xu wrote:
> On Mon, Mar 30, 2026 at 12:08:00PM +0200, Thorsten Blum wrote:
> > Tested on hardware with an ATECC608B at 0x60. The device binds
> > successfully, passes the driver's sanity check, and registers the
> > ecdh-nist-p256 KPP algorithm.
> > 
> > The hardware ECDH path was also exercised using a minimal KPP test
> > module, covering private key generation, public key derivation, and
> > shared secret computation.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> > ---
> >  drivers/crypto/atmel-ecc.c | 3 +++
> >  1 file changed, 3 insertions(+)
> 
> Is there supposed to be a 2/2 or should I apply this patch on its
> own?

Patch 2/2 is here:

https://lore.kernel.org/lkml/20260330100800.389042-4-thorsten.blum@linux.dev/

Thanks,
Thorsten


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] crypto: atmel-ecc - add support for atecc608b
  2026-04-12  7:18   ` Thorsten Blum
@ 2026-04-12  8:37     ` Herbert Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2026-04-12  8:37 UTC (permalink / raw)
  To: Thorsten Blum
  Cc: David S. Miller, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
	linux-crypto, linux-arm-kernel, linux-kernel

On Sun, Apr 12, 2026 at 09:18:13AM +0200, Thorsten Blum wrote:
>
> Patch 2/2 is here:
> 
> https://lore.kernel.org/lkml/20260330100800.389042-4-thorsten.blum@linux.dev/

Please repost 2/2 to linux-crypto with Rob's ack.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-04-12  8:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-30 10:08 [PATCH 1/2] crypto: atmel-ecc - add support for atecc608b Thorsten Blum
2026-04-12  5:51 ` Herbert Xu
2026-04-12  7:18   ` Thorsten Blum
2026-04-12  8:37     ` Herbert Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox