From: Mark Brown <broonie@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
Thierry Reding <treding@nvidia.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH 2/3] ASoC: pxa2xx: push gpio usage into arch code
Date: Tue, 28 Apr 2026 10:17:54 +0900 [thread overview]
Message-ID: <afAKwpgvUjlB6dI2@sirena.co.uk> (raw)
In-Reply-To: <20260427144658.3609647-2-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
On Mon, Apr 27, 2026 at 04:46:30PM +0200, Arnd Bergmann wrote:
> + if (cpu_is_pxa27x()) {
> /* Assert reset using GPIOD_OUT_HIGH, because reset is GPIO_ACTIVE_LOW */
> rst_gpio = devm_gpiod_get(&dev->dev, "reset", GPIOD_OUT_HIGH);
> - if (IS_ERR(rst_gpio)) {
> - ret = PTR_ERR(rst_gpio);
> - if (ret == -ENOENT)
> - reset_gpio = -1;
> - else if (ret)
> - return ret;
> - } else {
> - reset_gpio = desc_to_gpio(rst_gpio);
> - }
> - } else {
> - if (cpu_is_pxa27x())
> - reset_gpio = 113;
> - }
> + if (IS_ERR(rst_gpio))
> + rst_gpio = NULL;
Unlikely to actually fire but this now squashes -EPROBE_DEFER - the
earlier code propagated any error other than -ENOENT.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-28 1:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 14:46 [PATCH 1/3] ASoC: arm: pxa2xx: remove platform_data processing Arnd Bergmann
2026-04-27 14:46 ` [PATCH 2/3] ASoC: pxa2xx: push gpio usage into arch code Arnd Bergmann
2026-04-27 15:58 ` Andy Shevchenko
2026-04-28 1:17 ` Mark Brown [this message]
2026-04-27 14:46 ` [PATCH 3/3] ASoC: pxa: integrate sound/arm/pxa2xx into sound/soc/pxa2xx Arnd Bergmann
2026-04-27 15:52 ` Andy Shevchenko
2026-04-27 15:58 ` Arnd Bergmann
2026-04-27 17:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afAKwpgvUjlB6dI2@sirena.co.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=tiwai@suse.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox