* [PATCH 1/5] powercap: arm_scmi_powercap: Log number of powercap domains
2026-05-13 16:44 [PATCH 0/5] scmi: Log client subsystem entity counts Alex Tran
@ 2026-05-13 16:44 ` Alex Tran
2026-05-13 16:44 ` [PATCH 2/5] cpufreq: scmi-cpufreq: Log number of perf domains Alex Tran
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Alex Tran @ 2026-05-13 16:44 UTC (permalink / raw)
To: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, Guenter Roeck
Cc: linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon, Alex Tran
The SCMI powercap driver does not currently report how many powercap
domains were discovered from firmware during probe. This makes it harder
to confirm the firmware exposed powercap resources during debugging.
Log the powercap domain count after a successful probe, aligning the
driver with the existing SCMI client driver logging pattern.
Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
---
drivers/powercap/arm_scmi_powercap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c
index ab66e9a3b1e2..48d721385f94 100644
--- a/drivers/powercap/arm_scmi_powercap.c
+++ b/drivers/powercap/arm_scmi_powercap.c
@@ -496,6 +496,7 @@ static int scmi_powercap_probe(struct scmi_device *sdev)
return ret;
dev_set_drvdata(dev, pr);
+ dev_info(dev, "Initialized %d powercap domains\n", pr->num_zones);
return ret;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/5] cpufreq: scmi-cpufreq: Log number of perf domains
2026-05-13 16:44 [PATCH 0/5] scmi: Log client subsystem entity counts Alex Tran
2026-05-13 16:44 ` [PATCH 1/5] powercap: arm_scmi_powercap: Log number of powercap domains Alex Tran
@ 2026-05-13 16:44 ` Alex Tran
2026-05-13 16:44 ` [PATCH 3/5] hwmon: scmi-hwmon: Log number of sensors Alex Tran
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Alex Tran @ 2026-05-13 16:44 UTC (permalink / raw)
To: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, Guenter Roeck
Cc: linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon, Alex Tran
The SCMI cpufreq driver does not currently log the number of performance
domains discovered from firmware. This information is useful for
confirming the firmware exposed performance domains during debugging.
Log the domain count after a successful probe to align with the existing
SCMI client driver logging pattern.
Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
---
drivers/cpufreq/scmi-cpufreq.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index 4edb4f7a8aa9..d5c33eea2477 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -468,9 +468,12 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev)
if (ret) {
dev_err(dev, "%s: registering cpufreq failed, err: %d\n",
__func__, ret);
+ return ret;
}
- return ret;
+ dev_info(dev, "Initialized %d performance domains\n",
+ perf_ops->num_domains_get(ph));
+ return 0;
}
static void scmi_cpufreq_remove(struct scmi_device *sdev)
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 3/5] hwmon: scmi-hwmon: Log number of sensors
2026-05-13 16:44 [PATCH 0/5] scmi: Log client subsystem entity counts Alex Tran
2026-05-13 16:44 ` [PATCH 1/5] powercap: arm_scmi_powercap: Log number of powercap domains Alex Tran
2026-05-13 16:44 ` [PATCH 2/5] cpufreq: scmi-cpufreq: Log number of perf domains Alex Tran
@ 2026-05-13 16:44 ` Alex Tran
2026-05-13 16:47 ` Guenter Roeck
2026-05-13 16:44 ` [PATCH 4/5] reset: reset-scmi: Log number of reset domains Alex Tran
` (2 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Alex Tran @ 2026-05-13 16:44 UTC (permalink / raw)
To: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, Guenter Roeck
Cc: linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon, Alex Tran
The SCMI hwmon driver does not currently report how many sensors were
discovered from firmware during probe. This makes it harder to confirm
the firmware exposed sensor resources during debugging.
Log the sensor count after a successful probe, aligning the driver with
the existing SCMI client driver logging pattern.
Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
---
drivers/hwmon/scmi-hwmon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
index eec223d174c0..6f1b0559d5c2 100644
--- a/drivers/hwmon/scmi-hwmon.c
+++ b/drivers/hwmon/scmi-hwmon.c
@@ -362,6 +362,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
}
}
+ dev_info(dev, "Initialized %d sensors\n", nr_sensors);
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 3/5] hwmon: scmi-hwmon: Log number of sensors
2026-05-13 16:44 ` [PATCH 3/5] hwmon: scmi-hwmon: Log number of sensors Alex Tran
@ 2026-05-13 16:47 ` Guenter Roeck
0 siblings, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2026-05-13 16:47 UTC (permalink / raw)
To: Alex Tran, Jyoti Bhayana, Jonathan Cameron, David Lechner,
Nuno Sá, Andy Shevchenko, Sudeep Holla, Cristian Marussi,
Linus Walleij, Rafael J. Wysocki, Philipp Zabel, Viresh Kumar
Cc: linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon
On 5/13/26 09:44, Alex Tran wrote:
> The SCMI hwmon driver does not currently report how many sensors were
> discovered from firmware during probe. This makes it harder to confirm
> the firmware exposed sensor resources during debugging.
^^^^^^^^^^^^^^^^
Then please use dev_dbg().
Thanks,
Guenter
>
> Log the sensor count after a successful probe, aligning the driver with
> the existing SCMI client driver logging pattern.
>
> Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
> ---
> drivers/hwmon/scmi-hwmon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index eec223d174c0..6f1b0559d5c2 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -362,6 +362,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
> }
> }
>
> + dev_info(dev, "Initialized %d sensors\n", nr_sensors);
> return 0;
> }
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/5] reset: reset-scmi: Log number of reset domains
2026-05-13 16:44 [PATCH 0/5] scmi: Log client subsystem entity counts Alex Tran
` (2 preceding siblings ...)
2026-05-13 16:44 ` [PATCH 3/5] hwmon: scmi-hwmon: Log number of sensors Alex Tran
@ 2026-05-13 16:44 ` Alex Tran
2026-05-13 16:44 ` [PATCH 5/5] pinctrl: pinctrl-scmi: Log number of pins, groups, functions Alex Tran
2026-05-13 18:02 ` [PATCH 0/5] scmi: Log client subsystem entity counts Andy Shevchenko
5 siblings, 0 replies; 9+ messages in thread
From: Alex Tran @ 2026-05-13 16:44 UTC (permalink / raw)
To: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, Guenter Roeck
Cc: linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon, Alex Tran
The SCMI reset driver does not currently report how many reset domains
were discovered from firmware during probe. This makes it harder to
confirm the firmware reset resources during debugging.
Log the reset domain count after a successful probe, aligning the driver
with the existing SCMI client driver logging pattern.
Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
---
drivers/reset/reset-scmi.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/reset/reset-scmi.c b/drivers/reset/reset-scmi.c
index 4335811e0cfa..f26fad0dc726 100644
--- a/drivers/reset/reset-scmi.c
+++ b/drivers/reset/reset-scmi.c
@@ -93,6 +93,7 @@ static int scmi_reset_probe(struct scmi_device *sdev)
struct device_node *np = dev->of_node;
const struct scmi_handle *handle = sdev->handle;
struct scmi_protocol_handle *ph;
+ int ret;
if (!handle)
return -ENODEV;
@@ -111,7 +112,12 @@ static int scmi_reset_probe(struct scmi_device *sdev)
data->rcdev.nr_resets = reset_ops->num_domains_get(ph);
data->ph = ph;
- return devm_reset_controller_register(dev, &data->rcdev);
+ ret = devm_reset_controller_register(dev, &data->rcdev);
+ if (ret)
+ return ret;
+
+ dev_info(dev, "Initialized %d reset domains\n", data->rcdev.nr_resets);
+ return 0;
}
static const struct scmi_device_id scmi_id_table[] = {
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 5/5] pinctrl: pinctrl-scmi: Log number of pins, groups, functions
2026-05-13 16:44 [PATCH 0/5] scmi: Log client subsystem entity counts Alex Tran
` (3 preceding siblings ...)
2026-05-13 16:44 ` [PATCH 4/5] reset: reset-scmi: Log number of reset domains Alex Tran
@ 2026-05-13 16:44 ` Alex Tran
2026-05-13 18:02 ` [PATCH 0/5] scmi: Log client subsystem entity counts Andy Shevchenko
5 siblings, 0 replies; 9+ messages in thread
From: Alex Tran @ 2026-05-13 16:44 UTC (permalink / raw)
To: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, Guenter Roeck
Cc: linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon, Alex Tran
The SCMI pinctrl driver does not currently log the number of pins,
groups, and functions discovered from firmware. This information is
useful for confirming the firmware exposed pinctrl resources during
debugging.
Log these counts after a successful probe to align with the existing
SCMI client driver logging pattern.
Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
---
drivers/pinctrl/pinctrl-scmi.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c
index f22be6b7b82a..abc90a3a7eaf 100644
--- a/drivers/pinctrl/pinctrl-scmi.c
+++ b/drivers/pinctrl/pinctrl-scmi.c
@@ -40,6 +40,7 @@ struct scmi_pinctrl {
struct pinctrl_desc pctl_desc;
struct pinfunction *functions;
unsigned int nr_functions;
+ unsigned int nr_groups;
};
static int pinctrl_scmi_get_groups_count(struct pinctrl_dev *pctldev)
@@ -578,7 +579,15 @@ static int scmi_pinctrl_probe(struct scmi_device *sdev)
if (!pmx->functions)
return -ENOMEM;
- return pinctrl_enable(pmx->pctldev);
+ pmx->nr_groups = pinctrl_scmi_get_groups_count(pmx->pctldev);
+
+ ret = pinctrl_enable(pmx->pctldev);
+ if (ret)
+ return ret;
+
+ dev_info(dev, "Initialized %d pins, %d groups, %d functions\n",
+ pmx->pctl_desc.npins, pmx->nr_groups, pmx->nr_functions);
+ return 0;
}
static const struct scmi_device_id scmi_id_table[] = {
--
2.43.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] scmi: Log client subsystem entity counts
2026-05-13 16:44 [PATCH 0/5] scmi: Log client subsystem entity counts Alex Tran
` (4 preceding siblings ...)
2026-05-13 16:44 ` [PATCH 5/5] pinctrl: pinctrl-scmi: Log number of pins, groups, functions Alex Tran
@ 2026-05-13 18:02 ` Andy Shevchenko
2026-05-13 18:27 ` Guenter Roeck
5 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2026-05-13 18:02 UTC (permalink / raw)
To: Alex Tran, Greg Kroah-Hartman
Cc: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, Guenter Roeck,
linux-iio, linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio,
linux-pm, linux-hwmon
+Greg (I believe the trend is to drop such messages and not add them [back]?)
On Wed, May 13, 2026 at 09:44:18AM -0700, Alex Tran wrote:
> SCMI client drivers do not consistently log the number of supported
> entities discovered from firmware. This information is useful during
> debugging because it shows which domains or resources were exposed by
> firmware during probe.
>
> Add logging of the number of supported entities to the SCMI cpufreq,
> pinctrl, reset, hwmon, and powercap client drivers after a successful
> probe. This aligns these drivers with the existing logging in the SCMI
> power and performance domain drivers.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 0/5] scmi: Log client subsystem entity counts
2026-05-13 18:02 ` [PATCH 0/5] scmi: Log client subsystem entity counts Andy Shevchenko
@ 2026-05-13 18:27 ` Guenter Roeck
0 siblings, 0 replies; 9+ messages in thread
From: Guenter Roeck @ 2026-05-13 18:27 UTC (permalink / raw)
To: Andy Shevchenko, Alex Tran, Greg Kroah-Hartman
Cc: Jyoti Bhayana, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, Sudeep Holla, Cristian Marussi, Linus Walleij,
Rafael J. Wysocki, Philipp Zabel, Viresh Kumar, linux-iio,
linux-kernel, arm-scmi, linux-arm-kernel, linux-gpio, linux-pm,
linux-hwmon
On 5/13/26 11:02, Andy Shevchenko wrote:
> +Greg (I believe the trend is to drop such messages and not add them [back]?)
>
Is there some common guidance on this ? I'd be all for dropping messages
instead of adding them, but there seems to be a perpetual battle between
people who want to log everything and people concerned about logging noise.
As maintainer I always seem to be stuck between those two camps.
Guenter
> On Wed, May 13, 2026 at 09:44:18AM -0700, Alex Tran wrote:
>> SCMI client drivers do not consistently log the number of supported
>> entities discovered from firmware. This information is useful during
>> debugging because it shows which domains or resources were exposed by
>> firmware during probe.
>>
>> Add logging of the number of supported entities to the SCMI cpufreq,
>> pinctrl, reset, hwmon, and powercap client drivers after a successful
>> probe. This aligns these drivers with the existing logging in the SCMI
>> power and performance domain drivers.
>
^ permalink raw reply [flat|nested] 9+ messages in thread