[PATCH] pwm: atmel-tcb: Remove unneeded semicolon

[PATCH] pwm: atmel-tcb: Remove unneeded semicolon

[Chen Ni]

Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/pwm/pwm-atmel-tcb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index 3d30aeab507e..a765ef279b51 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -443,7 +443,7 @@ static int atmel_tcb_pwm_probe(struct platform_device *pdev)
 
 	err = clk_prepare_enable(tcbpwmc->slow_clk);
 	if (err)
-		goto err_disable_clk;;
+		goto err_disable_clk;
 
 	err = clk_rate_exclusive_get(tcbpwmc->clk);
 	if (err)
-- 
2.25.1

Re: [PATCH] pwm: atmel-tcb: Remove unneeded semicolon

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

Hello,

On Tue, Apr 28, 2026 at 03:53:29PM +0800, Chen Ni wrote:
> -		goto err_disable_clk;;
> +		goto err_disable_clk;

Oh, that is my fault. If you're ok I'd add

	This was introduced in commit 68637b68afcc ("pwm: atmel-tcb:
	Cache clock rates and mark chip as atomic") in Uwe's adaption of
	Sangyun's original patch.

to the commit log. I'll apply it then to my fixes branch but not send it
to Linus. But if something more urgent pops up I'll send it along.

Thanks,
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] pwm: atmel-tcb: Remove unneeded semicolon

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

Hello Chen,

On Tue, Apr 28, 2026 at 03:36:45PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Apr 28, 2026 at 03:53:29PM +0800, Chen Ni wrote:
> > -		goto err_disable_clk;;
> > +		goto err_disable_clk;
> 
> Oh, that is my fault. If you're ok I'd add
> 
> 	This was introduced in commit 68637b68afcc ("pwm: atmel-tcb:
> 	Cache clock rates and mark chip as atomic") in Uwe's adaption of
> 	Sangyun's original patch.
> 
> to the commit log. I'll apply it then to my fixes branch but not send it
> to Linus. But if something more urgent pops up I'll send it along.

I'd like to pick up this commit, but don't want to modify the commit log
without your consent. For now this is blocked because of that.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] pwm: atmel-tcb: Remove unneeded semicolon

[Chen Ni]

On Sun, May 17, 2026 at 06:52:48PM +0200, Uwe Kleine-König wrote:

> I'd like to pick up this commit, but don't want to modify the commit log

> without your consent. For now this is blocked because of that.

Hi Uwe,

That is fine with me. Please go ahead and add the note to the commit log.

Best regards,
Chen Ni