* Re: [PATCH] soc: imx8m: Fix match data lookup for soc device
2026-04-27 1:01 [PATCH] soc: imx8m: Fix match data lookup for soc device Peng Fan (OSS)
@ 2026-05-07 10:57 ` Lucas Stach
2026-05-07 15:46 ` Frank Li
2026-05-26 9:07 ` Richard Leitner
2 siblings, 0 replies; 4+ messages in thread
From: Lucas Stach @ 2026-05-07 10:57 UTC (permalink / raw)
To: Peng Fan (OSS), Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Greg Kroah-Hartman, Rob Herring (Arm),
Bartosz Golaszewski
Cc: imx, Peng Fan, linux-kernel, linux-arm-kernel
Am Montag, dem 27.04.2026 um 09:01 +0800 schrieb Peng Fan (OSS):
> From: Peng Fan <peng.fan@nxp.com>
>
> The i.MX8M soc device is registered via platform_device_register_simple(),
> so it is not associated with a Device Tree node and the imx8m_soc_driver
> has no of_match_table.
>
> As a result, device_get_match_data() always returns NULL when probing
> the soc device.
>
> Retrieve the match data directly from the machine compatible using
> of_machine_get_match_data(imx8_soc_match), which provides the correct SoC
> data.
>
> Fixes: 2524b293a59e5 ("soc: imx8m: don't access of_root directly")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Frank, please apply this fix for the 7.1-rc release series to get rid
of the regression.
Regards,
Lucas
> ---
> drivers/soc/imx/soc-imx8m.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 77763a107edbd11302017e3f61ecb4369fda1ab0..fc080e56f50d423b88a673181a6bc986eb4c1691 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -247,7 +247,7 @@ static int imx8m_soc_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - data = device_get_match_data(dev);
> + data = of_machine_get_match_data(imx8_soc_match);
> if (data) {
> soc_dev_attr->soc_id = data->name;
> ret = imx8m_soc_prepare(pdev, data->ocotp_compatible);
>
> ---
> base-commit: 70c8a7ec6715b5fb14e501731b5b9210a16684f7
> change-id: 20260424-soc-imx8m-fix-90d7ce2397f5
>
> Best regards,
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: imx8m: Fix match data lookup for soc device
2026-04-27 1:01 [PATCH] soc: imx8m: Fix match data lookup for soc device Peng Fan (OSS)
2026-05-07 10:57 ` Lucas Stach
@ 2026-05-07 15:46 ` Frank Li
2026-05-26 9:07 ` Richard Leitner
2 siblings, 0 replies; 4+ messages in thread
From: Frank Li @ 2026-05-07 15:46 UTC (permalink / raw)
To: Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Greg Kroah-Hartman, Rob Herring (Arm), Bartosz Golaszewski,
Peng Fan (OSS)
Cc: imx, linux-arm-kernel, linux-kernel, Peng Fan
On Mon, 27 Apr 2026 09:01:48 +0800, Peng Fan (OSS) wrote:
> The i.MX8M soc device is registered via platform_device_register_simple(),
> so it is not associated with a Device Tree node and the imx8m_soc_driver
> has no of_match_table.
>
> As a result, device_get_match_data() always returns NULL when probing
> the soc device.
>
> [...]
Applied, thanks!
[1/1] soc: imx8m: Fix match data lookup for soc device
commit: 2c6821657ce3b3c85f92719ea81ec9f9ff27df11
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: imx8m: Fix match data lookup for soc device
2026-04-27 1:01 [PATCH] soc: imx8m: Fix match data lookup for soc device Peng Fan (OSS)
2026-05-07 10:57 ` Lucas Stach
2026-05-07 15:46 ` Frank Li
@ 2026-05-26 9:07 ` Richard Leitner
2 siblings, 0 replies; 4+ messages in thread
From: Richard Leitner @ 2026-05-26 9:07 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Greg Kroah-Hartman, Rob Herring (Arm), Bartosz Golaszewski, imx,
linux-arm-kernel, linux-kernel, Peng Fan
On Mon, Apr 27, 2026 at 09:01:48AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> The i.MX8M soc device is registered via platform_device_register_simple(),
> so it is not associated with a Device Tree node and the imx8m_soc_driver
> has no of_match_table.
>
> As a result, device_get_match_data() always returns NULL when probing
> the soc device.
>
> Retrieve the match data directly from the machine compatible using
> of_machine_get_match_data(imx8_soc_match), which provides the correct SoC
> data.
>
> Fixes: 2524b293a59e5 ("soc: imx8m: don't access of_root directly")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Thanks for that fix!
Tested-by: Richard Leitner <richard.leitner@linux.dev> # i.MX8MP
regards;rl
> ---
> drivers/soc/imx/soc-imx8m.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/imx/soc-imx8m.c b/drivers/soc/imx/soc-imx8m.c
> index 77763a107edbd11302017e3f61ecb4369fda1ab0..fc080e56f50d423b88a673181a6bc986eb4c1691 100644
> --- a/drivers/soc/imx/soc-imx8m.c
> +++ b/drivers/soc/imx/soc-imx8m.c
> @@ -247,7 +247,7 @@ static int imx8m_soc_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - data = device_get_match_data(dev);
> + data = of_machine_get_match_data(imx8_soc_match);
> if (data) {
> soc_dev_attr->soc_id = data->name;
> ret = imx8m_soc_prepare(pdev, data->ocotp_compatible);
>
> ---
> base-commit: 70c8a7ec6715b5fb14e501731b5b9210a16684f7
> change-id: 20260424-soc-imx8m-fix-90d7ce2397f5
>
> Best regards,
> --
> Peng Fan <peng.fan@nxp.com>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread