* [PATCH] drm/mxsfb/lcdif: don't hide lcdif_attach_bridge() deferral messages
@ 2026-06-19 7:02 Luca Ceresoli
2026-06-22 8:13 ` Liu Ying
0 siblings, 1 reply; 2+ messages in thread
From: Luca Ceresoli @ 2026-06-19 7:02 UTC (permalink / raw)
To: Marek Vasut, Stefan Agner, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: Hui Pu, Ian Ray, Thomas Petazzoni, dri-devel, imx,
linux-arm-kernel, linux-kernel, Luca Ceresoli
lcdif_attach_bridge() uses dev_err_probe() on all its error returns to
store a specific deferral message.
However its caller lcdif_load() calls dev_err_probe() again on error,
overwriting the specific deferral messages with a unique, unavoidably
generic, message.
Make the specific deferral message visible by using a plain 'return ret' on
the caller.
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
drivers/gpu/drm/mxsfb/lcdif_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdif_drv.c
index f5bb59cd5028..e2173c4d6fc2 100644
--- a/drivers/gpu/drm/mxsfb/lcdif_drv.c
+++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c
@@ -186,7 +186,7 @@ static int lcdif_load(struct drm_device *drm)
ret = lcdif_attach_bridge(lcdif);
if (ret)
- return dev_err_probe(drm->dev, ret, "Cannot connect bridge\n");
+ return ret;
drm->mode_config.min_width = LCDIF_MIN_XRES;
drm->mode_config.min_height = LCDIF_MIN_YRES;
---
base-commit: 98b46e693b912eef0e6d497327489113845cbd15
change-id: 20260619-drm-lcdif-deferral-msg-e736d5fb301b
Best regards,
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mxsfb/lcdif: don't hide lcdif_attach_bridge() deferral messages
2026-06-19 7:02 [PATCH] drm/mxsfb/lcdif: don't hide lcdif_attach_bridge() deferral messages Luca Ceresoli
@ 2026-06-22 8:13 ` Liu Ying
0 siblings, 0 replies; 2+ messages in thread
From: Liu Ying @ 2026-06-22 8:13 UTC (permalink / raw)
To: Luca Ceresoli
Cc: Marek Vasut, Stefan Agner, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Frank Li,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Hui Pu,
Ian Ray, Thomas Petazzoni, dri-devel, imx, linux-arm-kernel,
linux-kernel
On Fri, Jun 19, 2026 at 09:02:13AM +0200, Luca Ceresoli wrote:
> lcdif_attach_bridge() uses dev_err_probe() on all its error returns to
> store a specific deferral message.
>
> However its caller lcdif_load() calls dev_err_probe() again on error,
> overwriting the specific deferral messages with a unique, unavoidably
> generic, message.
>
> Make the specific deferral message visible by using a plain 'return ret' on
> the caller.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/gpu/drm/mxsfb/lcdif_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Liu Ying <victor.liu@nxp.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-22 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-19 7:02 [PATCH] drm/mxsfb/lcdif: don't hide lcdif_attach_bridge() deferral messages Luca Ceresoli
2026-06-22 8:13 ` Liu Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox