From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Lee Jones <lee@kernel.org>,
James Ogletree <jogletre@opensource.cirrus.com>,
Fred Treven <fred.treven@cirrus.com>,
Ben Bright <ben.bright@cirrus.com>,
Support Opensource <support.opensource@diasemi.com>,
Xu Yilun <yilun.xu@intel.com>, Tom Rix <trix@redhat.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Colin Foster <colin.foster@in-advantage.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
patches@opensource.cirrus.com, mfd@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 17/23] mfd: Use named initializers for arrays of spi_device_id
Date: Wed, 8 Jul 2026 13:14:03 +0100 [thread overview]
Message-ID: <ak4/C9MGcGa/FC0F@opensource.cirrus.com> (raw)
In-Reply-To: <005f42dc5bbbd8879edd7fb3cbd62d6ebe38f39f.1783507945.git.u.kleine-koenig@baylibre.com>
On Wed, Jul 08, 2026 at 01:15:24PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> While being less compact, using named initializers allows to more easily
> see which members of the structs are assigned which value without having
> to lookup the declaration of the struct. And it's also more robust
> against changes to the struct definition.
>
> The mentioned robustness is relevant for a planned change to struct
> spi_device_id that replaces .driver_data by an anonymous union.
>
> This patch doesn't modify the compiled arrays, only their representation
> in source form benefits.
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> drivers/mfd/arizona-spi.c | 10 +++++-----
> drivers/mfd/cs40l50-spi.c | 2 +-
> drivers/mfd/madera-spi.c | 18 +++++++++---------
> drivers/mfd/wm831x-spi.c | 14 +++++++-------
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2026-07-08 12:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1783507945.git.u.kleine-koenig@baylibre.com>
2026-07-08 11:15 ` [PATCH v2 01/23] mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locally Uwe Kleine-König (The Capable Hub)
2026-07-10 10:20 ` Stanimir Varbanov
2026-07-08 11:15 ` [PATCH v2 02/23] mfd: bcm2835-pm: Drop unused header Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 05/23] mfd: mt6360: Drop irrelevant __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 09/23] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:12 ` Charles Keepax
2026-07-08 12:55 ` André Draszik
2026-07-08 11:15 ` [PATCH v2 16/23] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-09 19:35 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 17/23] mfd: Use named initializers for arrays of spi_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:14 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak4/C9MGcGa/FC0F@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alexandre.torgue@foss.st.com \
--cc=ben.bright@cirrus.com \
--cc=colin.foster@in-advantage.com \
--cc=fred.treven@cirrus.com \
--cc=jogletre@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=support.opensource@diasemi.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox