From: Stanimir Varbanov <svarbanov@suse.de>
To: "Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>, "Lee Jones" <lee@kernel.org>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
mfd@lists.linux.dev, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/23] mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locally
Date: Fri, 10 Jul 2026 13:20:43 +0300 [thread overview]
Message-ID: <b3d228fd-6138-4195-b63c-65b28691e18b@suse.de> (raw)
In-Reply-To: <d80395cc8008817427e63417b97bc8631236c72a.1783507945.git.u.kleine-koenig@baylibre.com>
Hi Uwe,
On 7/8/26 2:15 PM, Uwe Kleine-König (The Capable Hub) wrote:
> struct bcm2835_pm::soc is only used in bcm2835_pm_probe() and thus can be
> replaced by a local variable.
>
> With that change enum bcm2835_soc is only used in the mfd core driver and
> so the definition can move there.
The original idea was to re-use bcm2835_pm::soc field in bcm2835-power.c
pmdomain driver where we implicitly decide which DOMAIN_GRAFX_V3D
register to use (see commit d4aa5960025a "pmdomain: bcm: bcm2835-power:
Prepare to support BCM2712"). So, instead of !power->asb the intention
is to use bcm2835_pm::soc == BCM2835_PM_SOC_BCM2712.
Please drop this patch from the series. I'll post a patch soon.
regards,
~Stan
next prev parent reply other threads:[~2026-07-10 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1783507945.git.u.kleine-koenig@baylibre.com>
2026-07-08 11:15 ` [PATCH v2 01/23] mfd: bcm2835-pm: Remove member of struct bcm2835_pm that is only used locally Uwe Kleine-König (The Capable Hub)
2026-07-10 10:20 ` Stanimir Varbanov [this message]
2026-07-08 11:15 ` [PATCH v2 02/23] mfd: bcm2835-pm: Drop unused header Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 05/23] mfd: mt6360: Drop irrelevant __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 09/23] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 13/23] mfd: Use named initializers for arrays of i2c_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:12 ` Charles Keepax
2026-07-08 12:55 ` André Draszik
2026-07-08 11:15 ` [PATCH v2 16/23] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-09 19:35 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 17/23] mfd: Use named initializers for arrays of spi_device_id Uwe Kleine-König (The Capable Hub)
2026-07-08 12:14 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3d228fd-6138-4195-b63c-65b28691e18b@suse.de \
--to=svarbanov@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=florian.fainelli@broadcom.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mfd@lists.linux.dev \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox