From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andi Shyti <andi.shyti@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Peter Rosin <peda@lysator.liu.se>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 4/7] i2c: davinci: calculate bus freq from Hz instead of kHz
Date: Wed, 8 Jul 2026 22:30:32 +0300 [thread overview]
Message-ID: <ak6lWKWDM8XwqLgw@ashevche-desk.local> (raw)
In-Reply-To: <20260708-i2c-mux-v10-4-09dca03c8a15@gmail.com>
On Wed, Jul 08, 2026 at 02:16:16PM +0200, Marcus Folkesson wrote:
> The bus frequency is unnecessarily converted between Hz and kHz in
> several places.
> This is probably an old legacy from the old times (pre-devicetrees)
> when the davinci_i2c_platform_data took the bus_freq in kHz.
>
> Stick to Hz.
...
> -#define DAVINCI_I2C_DEFAULT_BUS_FREQ 100000
> -
You need to rebase this on top of the i2c-next.
...
> + /* standard bus frequency */
> + unsigned int bus_freq_hz;
While at it, I would dare to suggest _Hz as we started doing in IIO (id est
we start following more closely the SI units in the suffixes of constant
definitions and variables to be case sensitive).
...
> r = device_property_read_u32(&pdev->dev, "clock-frequency", &prop);
> if (r)
> - prop = DAVINCI_I2C_DEFAULT_BUS_FREQ;
> + prop = I2C_MAX_STANDARD_MODE_FREQ;
>
See above about rebase.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-08 19:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 12:16 [PATCH v10 0/7] I2C Mux per channel bus speed Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 1/7] i2c: core: add callback to change bus frequency Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 2/7] i2c: mux: add idle_state property to i2c_mux_core Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 3/7] i2c: mux: add support for per channel bus frequency Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 4/7] i2c: davinci: calculate bus freq from Hz instead of kHz Marcus Folkesson
2026-07-08 19:30 ` Andy Shevchenko [this message]
2026-07-09 8:34 ` Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 5/7] i2c: davinci: add support for setting bus frequency Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 6/7] i2c: mux: ltc4306: set correct idle_state in i2c_mux_core Marcus Folkesson
2026-07-08 12:16 ` [PATCH v10 7/7] docs: i2c: i2c-topology: add section about bus speed Marcus Folkesson
2026-07-08 19:37 ` [PATCH v10 0/7] I2C Mux per channel " Andy Shevchenko
2026-07-09 8:33 ` Marcus Folkesson
2026-07-09 10:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak6lWKWDM8XwqLgw@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andi.shyti@kernel.org \
--cc=brgl@bgdev.pl \
--cc=brgl@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=peda@lysator.liu.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox