* [PATCH] hwrng: atmel - drop __maybe_unused from atmel_trng_pm_ops
@ 2026-06-06 13:17 Thorsten Blum
2026-07-05 5:31 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-06-06 13:17 UTC (permalink / raw)
To: Olivia Mackall, Herbert Xu, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, Sakari Ailus, AngeloGioacchino Del Regno
Cc: Thorsten Blum, linux-crypto, linux-arm-kernel, linux-kernel
Since atmel_trng_driver keeps atmel_trng_pm_ops referenced and pm_ptr()
uses IS_ENABLED(), which allows the compiler to optimize away unused
variables, drop the redundant __maybe_unused annotation.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/char/hw_random/atmel-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
index 6ed24be3481d..10082add0886 100644
--- a/drivers/char/hw_random/atmel-rng.c
+++ b/drivers/char/hw_random/atmel-rng.c
@@ -186,7 +186,7 @@ static int __maybe_unused atmel_trng_runtime_resume(struct device *dev)
return atmel_trng_init(trng);
}
-static const struct dev_pm_ops __maybe_unused atmel_trng_pm_ops = {
+static const struct dev_pm_ops atmel_trng_pm_ops = {
SET_RUNTIME_PM_OPS(atmel_trng_runtime_suspend,
atmel_trng_runtime_resume, NULL)
SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
base-commit: 79bbe453e5bfa6e1c6aa2e8329bfc8f152b81c9b
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwrng: atmel - drop __maybe_unused from atmel_trng_pm_ops
2026-06-06 13:17 [PATCH] hwrng: atmel - drop __maybe_unused from atmel_trng_pm_ops Thorsten Blum
@ 2026-07-05 5:31 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-07-05 5:31 UTC (permalink / raw)
To: Thorsten Blum
Cc: Olivia Mackall, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Sakari Ailus, AngeloGioacchino Del Regno, linux-crypto,
linux-arm-kernel, linux-kernel
On Sat, Jun 06, 2026 at 03:17:54PM +0200, Thorsten Blum wrote:
> Since atmel_trng_driver keeps atmel_trng_pm_ops referenced and pm_ptr()
> uses IS_ENABLED(), which allows the compiler to optimize away unused
> variables, drop the redundant __maybe_unused annotation.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/char/hw_random/atmel-rng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-05 5:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-06 13:17 [PATCH] hwrng: atmel - drop __maybe_unused from atmel_trng_pm_ops Thorsten Blum
2026-07-05 5:31 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox