Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] virt: arm-cca-guest: Drop unused assignment of platform_device_id driver data
@ 2026-06-17 10:28 Uwe Kleine-König (The Capable Hub)
  2026-07-20 13:17 ` Uwe Kleine-König (The Capable Hub)
  0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-06-17 10:28 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon; +Cc: linux-arm-kernel, linux-kernel

The driver explicitly sets the .driver_data member of struct
platform_device_id to zero without relying on that value. Drop this
unused assignment.

While touching this array use a named initializer for .name.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/virt/coco/arm-cca-guest/arm-cca-guest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c b/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c
index 66d00b6ceb78..6155576a9711 100644
--- a/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c
+++ b/drivers/virt/coco/arm-cca-guest/arm-cca-guest.c
@@ -223,7 +223,7 @@ module_exit(arm_cca_guest_exit);
 
 /* modalias, so userspace can autoload this module when RSI is available */
 static const struct platform_device_id arm_cca_match[] __maybe_unused = {
-	{ RSI_PDEV_NAME, 0},
+	{ .name = RSI_PDEV_NAME },
 	{ }
 };
 

base-commit: 4fa3f5fabb30bf00d7475d5a33459ea83d639bf9
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] virt: arm-cca-guest: Drop unused assignment of platform_device_id driver data
  2026-06-17 10:28 [PATCH v1] virt: arm-cca-guest: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
@ 2026-07-20 13:17 ` Uwe Kleine-König (The Capable Hub)
  2026-07-21 10:27   ` Will Deacon
  0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-07-20 13:17 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon; +Cc: linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

hello Catalin, hello Will,

On Wed, Jun 17, 2026 at 12:28:26PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly sets the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop this
> unused assignment.
> 
> While touching this array use a named initializer for .name.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

Do you have this patch still on your radar? Should I resend? To someone
else, too?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] virt: arm-cca-guest: Drop unused assignment of platform_device_id driver data
  2026-07-20 13:17 ` Uwe Kleine-König (The Capable Hub)
@ 2026-07-21 10:27   ` Will Deacon
  0 siblings, 0 replies; 3+ messages in thread
From: Will Deacon @ 2026-07-21 10:27 UTC (permalink / raw)
  To: Uwe Kleine-König (The Capable Hub)
  Cc: Catalin Marinas, linux-arm-kernel, linux-kernel

On Mon, Jul 20, 2026 at 03:17:14PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> hello Catalin, hello Will,
> 
> On Wed, Jun 17, 2026 at 12:28:26PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > The driver explicitly sets the .driver_data member of struct
> > platform_device_id to zero without relying on that value. Drop this
> > unused assignment.
> > 
> > While touching this array use a named initializer for .name.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> Do you have this patch still on your radar? Should I resend? To someone
> else, too?

It's on my radar but my inbox is still a wreck and I've been focussing
on fixes.

Will


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-21 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-17 10:28 [PATCH v1] virt: arm-cca-guest: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-20 13:17 ` Uwe Kleine-König (The Capable Hub)
2026-07-21 10:27   ` Will Deacon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox