* [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable
@ 2026-07-20 18:48 Fuad Tabba
2026-07-20 19:01 ` Vincent Donnefort
0 siblings, 1 reply; 4+ messages in thread
From: Fuad Tabba @ 2026-07-20 18:48 UTC (permalink / raw)
To: maz, oupton, linux-arm-kernel, kvmarm
Cc: vdonnefort, will, joey.gouly, seiden, suzuki.poulose, yuzenghui,
linux-kernel, tabba
When disabling, hyp_trace_clock_enable() cancels the clock work but then
falls through into the enable path, which re-schedules it and marks the
clock running again, so the worker never stops. Return once the work is
cancelled.
Fixes: b22888917fa41 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp")
Reported-by: Sashiko <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/all/20260720172923.E4F161F000E9@smtp.kernel.org/
Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
---
arch/arm64/kvm/hyp_trace.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c
index 2411b4c32932c..27367843fd211 100644
--- a/arch/arm64/kvm/hyp_trace.c
+++ b/arch/arm64/kvm/hyp_trace.c
@@ -116,6 +116,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl
if (!enable) {
cancel_delayed_work_sync(&hyp_clock->work);
hyp_clock->running = false;
+ return;
}
ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap);
base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable
2026-07-20 18:48 [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable Fuad Tabba
@ 2026-07-20 19:01 ` Vincent Donnefort
2026-07-20 19:02 ` Vincent Donnefort
0 siblings, 1 reply; 4+ messages in thread
From: Vincent Donnefort @ 2026-07-20 19:01 UTC (permalink / raw)
To: Fuad Tabba
Cc: maz, oupton, linux-arm-kernel, kvmarm, will, joey.gouly, seiden,
suzuki.poulose, yuzenghui, linux-kernel, tabba
On Mon, Jul 20, 2026 at 07:48:50PM +0100, Fuad Tabba wrote:
> When disabling, hyp_trace_clock_enable() cancels the clock work but then
> falls through into the enable path, which re-schedules it and marks the
> clock running again, so the worker never stops. Return once the work is
> cancelled.
>
> Fixes: b22888917fa41 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://lore.kernel.org/all/20260720172923.E4F161F000E9@smtp.kernel.org/
> Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
Done here already https://lore.kernel.org/all/alczBmnItMwq8xj4@google.com/
> ---
> arch/arm64/kvm/hyp_trace.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c
> index 2411b4c32932c..27367843fd211 100644
> --- a/arch/arm64/kvm/hyp_trace.c
> +++ b/arch/arm64/kvm/hyp_trace.c
> @@ -116,6 +116,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl
> if (!enable) {
> cancel_delayed_work_sync(&hyp_clock->work);
> hyp_clock->running = false;
> + return;
> }
>
> ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap);
>
> base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable
2026-07-20 19:01 ` Vincent Donnefort
@ 2026-07-20 19:02 ` Vincent Donnefort
2026-07-20 19:04 ` Fuad Tabba
0 siblings, 1 reply; 4+ messages in thread
From: Vincent Donnefort @ 2026-07-20 19:02 UTC (permalink / raw)
To: Fuad Tabba
Cc: maz, oupton, linux-arm-kernel, kvmarm, will, joey.gouly, seiden,
suzuki.poulose, yuzenghui, linux-kernel, tabba
On Mon, Jul 20, 2026 at 08:01:55PM +0100, Vincent Donnefort wrote:
> On Mon, Jul 20, 2026 at 07:48:50PM +0100, Fuad Tabba wrote:
> > When disabling, hyp_trace_clock_enable() cancels the clock work but then
> > falls through into the enable path, which re-schedules it and marks the
> > clock running again, so the worker never stops. Return once the work is
> > cancelled.
> >
> > Fixes: b22888917fa41 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp")
> > Reported-by: Sashiko <sashiko-bot@kernel.org>
> > Closes: https://lore.kernel.org/all/20260720172923.E4F161F000E9@smtp.kernel.org/
> > Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
>
> Done here already https://lore.kernel.org/all/alczBmnItMwq8xj4@google.com/
sorry I meant here:
https://lore.kernel.org/all/20260715105100.3178255-1-vdonnefort@google.com/
>
> > ---
> > arch/arm64/kvm/hyp_trace.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c
> > index 2411b4c32932c..27367843fd211 100644
> > --- a/arch/arm64/kvm/hyp_trace.c
> > +++ b/arch/arm64/kvm/hyp_trace.c
> > @@ -116,6 +116,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl
> > if (!enable) {
> > cancel_delayed_work_sync(&hyp_clock->work);
> > hyp_clock->running = false;
> > + return;
> > }
> >
> > ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap);
> >
> > base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f
> > --
> > 2.39.5
> >
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable
2026-07-20 19:02 ` Vincent Donnefort
@ 2026-07-20 19:04 ` Fuad Tabba
0 siblings, 0 replies; 4+ messages in thread
From: Fuad Tabba @ 2026-07-20 19:04 UTC (permalink / raw)
To: Vincent Donnefort
Cc: maz, oupton, linux-arm-kernel, kvmarm, will, joey.gouly, seiden,
suzuki.poulose, yuzenghui, linux-kernel
On Mon, 20 Jul 2026 at 20:03, Vincent Donnefort <vdonnefort@google.com> wrote:
>
> On Mon, Jul 20, 2026 at 08:01:55PM +0100, Vincent Donnefort wrote:
> > On Mon, Jul 20, 2026 at 07:48:50PM +0100, Fuad Tabba wrote:
> > > When disabling, hyp_trace_clock_enable() cancels the clock work but then
> > > falls through into the enable path, which re-schedules it and marks the
> > > clock running again, so the worker never stops. Return once the work is
> > > cancelled.
> > >
> > > Fixes: b22888917fa41 ("KVM: arm64: Sync boot clock with the nVHE/pKVM hyp")
> > > Reported-by: Sashiko <sashiko-bot@kernel.org>
> > > Closes: https://lore.kernel.org/all/20260720172923.E4F161F000E9@smtp.kernel.org/
> > > Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
> >
> > Done here already https://lore.kernel.org/all/alczBmnItMwq8xj4@google.com/
>
> sorry I meant here:
>
> https://lore.kernel.org/all/20260715105100.3178255-1-vdonnefort@google.com/
Thanks, and sorry for the noise!
/fuad
>
>
> >
> > > ---
> > > arch/arm64/kvm/hyp_trace.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/arm64/kvm/hyp_trace.c b/arch/arm64/kvm/hyp_trace.c
> > > index 2411b4c32932c..27367843fd211 100644
> > > --- a/arch/arm64/kvm/hyp_trace.c
> > > +++ b/arch/arm64/kvm/hyp_trace.c
> > > @@ -116,6 +116,7 @@ static void hyp_trace_clock_enable(struct hyp_trace_clock *hyp_clock, bool enabl
> > > if (!enable) {
> > > cancel_delayed_work_sync(&hyp_clock->work);
> > > hyp_clock->running = false;
> > > + return;
> > > }
> > >
> > > ktime_get_snapshot_id(CLOCK_BOOTTIME, &snap);
> > >
> > > base-commit: 1590cf0329716306e948a8fc29f1d3ee87d3989f
> > > --
> > > 2.39.5
> > >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-20 19:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-20 18:48 [PATCH] KVM: arm64: Stop the hyp trace clock worker on disable Fuad Tabba
2026-07-20 19:01 ` Vincent Donnefort
2026-07-20 19:02 ` Vincent Donnefort
2026-07-20 19:04 ` Fuad Tabba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox