Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Shih-Yuan Lee (FourDollars)" <fourdollars@debian.org>
Cc: Mark Brown <broonie@kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Lukas Wunner <lukas@wunner.de>, Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 5/7] spi: pxa2xx: disable DMA for Apple MacBook8,1
Date: Tue, 21 Jul 2026 23:31:25 +0300	[thread overview]
Message-ID: <al_XHWJktSD_MWHe@ashevche-desk.local> (raw)
In-Reply-To: <CAAT15mOxrJxb+jRf1P=yu=vXgDj9kRhrdSLkB8v4tEbhHOZ+Pw@mail.gmail.com>

On Tue, Jul 21, 2026 at 10:49:17PM +0800, Shih-Yuan Lee (FourDollars) wrote:
> On Tue, Jul 21, 2026 at 3:27 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > On Tue, Jul 21, 2026 at 12:21:14AM +0800, Shih-Yuan Lee wrote:

...

> Thank you for the review and feedback.
> 
> Regarding your question about why DMA fails on this hardware, I have
> just sent a detailed reply to Lukas in this thread outlining our
> physical verification findings. In short, I confirmed that the
> DMA controller's physical interrupt line is not functioning on this
> motherboard,

It might be wrongly described in ACPI tables, but in HW it works.

> and macOS and Windows 10 also completely bypass the DMA
> controller. Please refer to that email for the DMAR/IOMMU and
> cross-OS analysis details.
> 
> Regarding your other comments:

> 2. The force_pio Module Parameter:
> The original spi-pxa2xx driver is designed to hardcode DMA usage if
> DMA channels are available. I introduced the force_pio module
> parameter for two reasons:
>   • It serves as a diagnostic tool for users on similar hardware to
> easily test and verify if their issues are related to DMA.
>   • It allows developers to easily test and debug the PIO code path on
> DMA-capable LPSS hardware to prevent regressions.
> 
> That being said, if module parameters of this type are strictly not
> preferred, I am completely fine with removing force_pio and keeping
> only the DMI-based quirk for the MacBook8,1. Please let me know your
> preference.

Neither is preferred until we will fully understand what's going on there.
Yes, DMI quirk is a last resort, but to come to that we need to try better
options. See my other reply about the DMA case.

-- 
With Best Regards,
Andy Shevchenko




  reply	other threads:[~2026-07-21 20:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 16:21 [PATCH v16 0/7] spi: pxa2xx: Fix PM and interrupt issues on Intel LPSS SPI Shih-Yuan Lee
2026-07-20 16:21 ` [PATCH v16 1/7] spi: pxa2xx: introduce clock enable and disable helper functions Shih-Yuan Lee
2026-07-20 19:22   ` Andy Shevchenko
2026-07-20 16:21 ` [PATCH v16 2/7] spi: pxa2xx: introduce suspended flag for interrupt synchronization Shih-Yuan Lee
2026-07-20 17:18   ` Mark Brown
2026-07-20 16:21 ` [PATCH v16 3/7] spi: pxa2xx: overhaul teardown and suspend sequence using pxa2xx_spi_off Shih-Yuan Lee
2026-07-20 19:53   ` Andy Shevchenko
2026-07-20 16:21 ` [PATCH v16 4/7] spi: pxa2xx: lock out runtime autosuspend for Intel LPSS SPI in PIO mode Shih-Yuan Lee
2026-07-20 19:55   ` Andy Shevchenko
2026-07-20 16:21 ` [PATCH v16 5/7] spi: pxa2xx: disable DMA for Apple MacBook8,1 Shih-Yuan Lee
2026-07-20 19:27   ` Andy Shevchenko
2026-07-21 14:49     ` Shih-Yuan Lee (FourDollars)
2026-07-21 20:31       ` Andy Shevchenko [this message]
2026-07-21  9:00   ` Lukas Wunner
2026-07-21  9:26     ` Shih-Yuan Lee (FourDollars)
2026-07-21 14:34       ` Shih-Yuan Lee (FourDollars)
2026-07-21 15:05         ` Mark Brown
2026-07-21 15:26           ` Shih-Yuan Lee (FourDollars)
2026-07-21 16:09             ` Shih-Yuan Lee (FourDollars)
2026-07-21 20:41               ` Andy Shevchenko
2026-07-22  9:58               ` Lukas Wunner
2026-07-21 20:28             ` Andy Shevchenko
2026-07-20 16:21 ` [PATCH v16 6/7] spi: pxa2xx: restore LPSS private register state on S3 resume Shih-Yuan Lee
2026-07-20 19:59   ` Andy Shevchenko
2026-07-20 16:21 ` [PATCH v16 7/7] spi: pxa2xx: rename local status variable to ret Shih-Yuan Lee
2026-07-20 19:56   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al_XHWJktSD_MWHe@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=broonie@kernel.org \
    --cc=daniel@zonque.org \
    --cc=fourdollars@debian.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox