From: cl@linux.com (Christoph Lameter)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-next][regression] [PATCH] percpu: add preemption checks to __this_cpu ops
Date: Thu, 20 Mar 2014 09:06:34 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1403200905070.4107@nuc> (raw)
In-Reply-To: <20140318143759.04a892434d84a9fd3aa94262@linux-foundation.org>
On Tue, 18 Mar 2014, Andrew Morton wrote:
> > snprintf can cause hangs.
>
> This is weird. How the heck can snprintf() fail if called too early?
> All it does is shuffle chars around in memory. The only external
> dependency I'm seeing is a WARN_ON() which presumably didn't trigger
> anyway.
>
> I'm suspecting a misdiagnosis here. Otherwise, we seriously need to
> fix snprintf(), not work around it!
>
> Also, what does "before checking error conditions" refer to? Does this
> mean you know why snprintf() failed??
No I dont. I only know that this fixes Grygorii's issues. There could be
numerous arch specific per cpu setup issues going on that may impact on
snprintf.
If I move it behind the checks then I can avoid using snprintf.
next prev parent reply other threads:[~2014-03-20 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 15:01 [linux-next][regression] [PATCH] percpu: add preemption checks to __this_cpu ops Grygorii Strashko
2014-03-18 14:37 ` Christoph Lameter
2014-03-18 15:48 ` Grygorii Strashko
2014-03-18 15:54 ` Christoph Lameter
2014-03-18 21:37 ` Andrew Morton
2014-03-19 11:18 ` Grygorii Strashko
2014-03-20 14:06 ` Christoph Lameter [this message]
[not found] ` <534C182C.8040206@ti.com>
2014-04-14 17:12 ` [3.15-rc1] a huge number of warnings produced by xhci & Christoph Lameter
2014-04-15 10:00 ` Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1403200905070.4107@nuc \
--to=cl@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox