public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: fix regression in ixp4xx clocksource
Date: Mon, 4 Jul 2011 11:21:12 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1107041120190.2917@ionos> (raw)
In-Reply-To: <alpine.LFD.2.02.1106020100200.3078@ionos>

On Thu, 2 Jun 2011, Thomas Gleixner wrote:
> > I'm really not happy about using the MMIO clocksource stuff with random
> > other read functions like this - it defeats the entire purpose of the
> > MMIO clocksource stuff.  Maybe we should just undo the change for IXP4xx
> > and treat it as "special" for the time being.
> > 
> > Thomas - do you have any other views?
> 
> I have no objections to have special cased read functions as long as
> all the other copied code is gone. We have the same problem with the
> generic irq chip and I did not come up with a good decision function
> where to draw the line. As for everything we come up with in the
> consolidation space we need to apply common sense and keep an eye on
> the real abusers.
> 
> Though in the mmio clocksource case we might ask the question whether
> read[l|w]() is really necessary in the generic implemetation or
> not. [too tired to answer that now ]

Thinking more about it we should add BE accessor functions to the mmio
clocksource as this might be useful for other architectures as well.

Thanks,

	tglx

  reply	other threads:[~2011-07-04  9:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-30  8:43 [PATCH] arm: fix regression in ixp4xx clocksource Richard Cochran
2011-06-01 15:08 ` Krzysztof Halasa
2011-06-01 17:02   ` Richard Cochran
2011-06-06  8:43     ` Krzysztof Halasa
2011-06-01 22:58 ` Russell King - ARM Linux
2011-06-01 23:09   ` Thomas Gleixner
2011-07-04  9:21     ` Thomas Gleixner [this message]
2011-07-07  6:59       ` Krzysztof Halasa
2011-06-11  5:15   ` Richard Cochran
2011-06-11 11:22     ` Mikael Pettersson
2011-06-11 12:49       ` Richard Cochran
2011-06-11 13:18         ` Mikael Pettersson
2011-06-26 13:08       ` Krzysztof Halasa
2011-06-12 13:51     ` Russell King - ARM Linux
2011-06-13  5:58       ` Richard Cochran
2011-06-26 13:38 ` Krzysztof Halasa
2011-06-28 13:10   ` Richard Cochran
  -- strict thread matches above, loose matches on Subject: below --
2011-07-06 21:02 [PATCH] ARM: fix regression in IXP4xx clocksource Krzysztof Halasa
2011-07-06 21:14 ` Russell King - ARM Linux
2011-07-07  7:06   ` Krzysztof Halasa
2011-07-12  8:05 ` Richard Cochran
2011-07-12  8:32   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1107041120190.2917@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox