public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: smp_twd: Reconfigure clockevents after cpufreq change
Date: Thu, 6 Oct 2011 19:25:53 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1110061922440.3240@ionos> (raw)
In-Reply-To: <CAKnu2ModYp+F0kq6qVo9SQJ88GR_EwGNgH2WZXJrXUeR1xyzQw@mail.gmail.com>

On Thu, 6 Oct 2011, Linus Walleij wrote:

> 2011/9/6 Linus Walleij <linus.walleij@stericsson.com>:
> 
> > From: Colin Cross <ccross@android.com>
> >
> > The localtimer's clock changes with the cpu clock. After a
> > cpufreq transition, update the clockevent's frequency and
> > reprogram the next clock event.
> 
> Thomas do you think you can have a look at this patch and ACK
> it if it looks OK to you? It's the use of clockevents_update_freq()
> function you added after we discussed this in Budapest.
> 
> Since it's likely the first user of that infrastructure we need
> to get it right.

The usage is correct.
 
> Here is the entire patch i Russells tracker:
> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6956/2

The only thing what puzzles me is:

> +	if (!IS_ERR_OR_NULL(twd_clk))
> +		twd_timer_rate = clk_get_rate(twd_clk);
> +	else
> +		twd_calibrate_rate();

How is made sure that the cpu freq update thing is not called when
twd_clk is not available or am I missing something ?

Thanks,

	tglx

  reply	other threads:[~2011-10-06 17:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-06  7:06 [PATCH RESEND] ARM: smp_twd: Reconfigure clockevents after cpufreq change Linus Walleij
2011-10-06 17:10 ` Linus Walleij
2011-10-06 17:25   ` Thomas Gleixner [this message]
2011-10-07  6:42     ` Linus Walleij
2011-10-07  9:43       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1110061922440.3240@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox