From: tglx@linutronix.de (Thomas Gleixner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] ARM: smp_twd: Reconfigure clockevents after cpufreq change
Date: Fri, 7 Oct 2011 11:43:40 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1110071142570.3240@ionos> (raw)
In-Reply-To: <CACRpkdaQNA_n7haRCU++26CLuaZ=eRb7iAS+mm0fQV244G1S4g@mail.gmail.com>
On Fri, 7 Oct 2011, Linus Walleij wrote:
> On Thu, Oct 6, 2011 at 7:25 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > On Thu, 6 Oct 2011, Linus Walleij wrote:
> >> Here is the entire patch i Russells tracker:
> >> http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=6956/2
> >
> > The only thing what puzzles me is:
> >
> >> + ? ? if (!IS_ERR_OR_NULL(twd_clk))
> >> + ? ? ? ? ? ? twd_timer_rate = clk_get_rate(twd_clk);
> >> + ? ? else
> >> + ? ? ? ? ? ? twd_calibrate_rate();
> >
> > How is made sure that the cpu freq update thing is not called when
> > twd_clk is not available or am I missing something ?
>
> The CPUfreq transition notifier is only registered if twd_clk is
> not error or NULL in this #ifdef CONFIG_CPU_FREQ snippet
> above that code, but executed later:
>
> +static int twd_cpufreq_init(void)
> +{
> + if (!IS_ERR_OR_NULL(twd_clk))
> + return cpufreq_register_notifier(&twd_cpufreq_nb,
> + CPUFREQ_TRANSITION_NOTIFIER);
> +
> + return 0;
> +}
> +core_initcall(twd_cpufreq_init);
Duh. Could have seen that myself :)
Thans for clarification. Please add my Acked-by.
Thanks,
tglx
prev parent reply other threads:[~2011-10-07 9:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-06 7:06 [PATCH RESEND] ARM: smp_twd: Reconfigure clockevents after cpufreq change Linus Walleij
2011-10-06 17:10 ` Linus Walleij
2011-10-06 17:25 ` Thomas Gleixner
2011-10-07 6:42 ` Linus Walleij
2011-10-07 9:43 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1110071142570.3240@ionos \
--to=tglx@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox