From: fthain@telegraphics.com.au (Finn Thain)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure
Date: Wed, 19 Mar 2014 12:46:16 +1100 (EST) [thread overview]
Message-ID: <alpine.LNX.2.00.1403191240001.23002@nippy.intranet> (raw)
In-Reply-To: <1395190072.8649.2.camel@joe-AO722>
On Tue, 18 Mar 2014, Joe Perches wrote:
> But using "if (0)" prevents the no_printk from occurring at all so there
> would be no side-effects and the format & args would still be verified
> by the compiler.
I'd prefer this (for symmetry and clarity):
#if NDEBUG
#define dprintk(flg, fmt, ...) \
do { if ((NDEBUG) & (flg)) pr_debug(fmt, ## __VA_ARGS__); } while (0)
#else
#define dprintk(flg, fmt, ...) \
do { if (0) pr_debug(fmt, ## __VA_ARGS__); } while (0)
#endif
But you seem to be asking for this instead:
#if NDEBUG
#define dprintk(flg, fmt, ...) \
do { if ((NDEBUG) & (flg)) pr_debug(fmt, ## __VA_ARGS__); } while (0)
#else
#define dprintk(flg, fmt, ...) \
do { if (0) no_printk(fmt, ## __VA_ARGS__); } while (0)
#endif
Why is that better?
--
next prev parent reply other threads:[~2014-03-19 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140318002822.372705594@telegraphics.com.au>
2014-03-18 3:19 ` [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure Joe Perches
2014-03-18 12:00 ` Finn Thain
2014-03-18 12:45 ` Joe Perches
2014-03-18 12:55 ` Geert Uytterhoeven
2014-03-18 13:07 ` Joe Perches
2014-03-18 13:13 ` Geert Uytterhoeven
2014-03-18 13:20 ` Joe Perches
2014-03-18 23:14 ` Finn Thain
2014-03-19 0:47 ` Joe Perches
2014-03-19 1:46 ` Finn Thain [this message]
2014-03-19 1:54 ` Joe Perches
2014-03-18 0:42 Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1403191240001.23002@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox