* [PATCH] irqchip: imx-irqsteer: Call pm_runtime_disable() on remove
@ 2026-07-29 20:16 Fabio Estevam
2026-07-29 20:37 ` Frank Li
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2026-07-29 20:16 UTC (permalink / raw)
To: tglx; +Cc: radu, imx, linux-arm-kernel, Fabio Estevam
imx_irqsteer_probe() enables runtime PM, but imx_irqsteer_remove()
does not disable it.
Consequently, runtime PM remains enabled after unbinding the device,
and rebinding it triggers:
Unbalanced pm_runtime_enable!
Disable runtime PM when removing the device.
Fixes: 4730d2233311 ("irqchip/imx-irqsteer: Add runtime PM support")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/irqchip/irq-imx-irqsteer.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 87b07f517be3..a695ba31db9a 100644
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -276,6 +276,8 @@ static void imx_irqsteer_remove(struct platform_device *pdev)
struct irqsteer_data *irqsteer_data = platform_get_drvdata(pdev);
int i;
+ pm_runtime_disable(&pdev->dev);
+
for (i = 0; i < irqsteer_data->irq_count; i++) {
if (!irqsteer_data->irq[i])
break;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip: imx-irqsteer: Call pm_runtime_disable() on remove
2026-07-29 20:16 [PATCH] irqchip: imx-irqsteer: Call pm_runtime_disable() on remove Fabio Estevam
@ 2026-07-29 20:37 ` Frank Li
0 siblings, 0 replies; 2+ messages in thread
From: Frank Li @ 2026-07-29 20:37 UTC (permalink / raw)
To: Fabio Estevam; +Cc: tglx, radu, imx, linux-arm-kernel
On Wed, Jul 29, 2026 at 05:16:34PM -0300, Fabio Estevam wrote:
> imx_irqsteer_probe() enables runtime PM, but imx_irqsteer_remove()
> does not disable it.
>
> Consequently, runtime PM remains enabled after unbinding the device,
> and rebinding it triggers:
>
> Unbalanced pm_runtime_enable!
can change to use devm_pm_runtime_enable()?
Frank
>
> Disable runtime PM when removing the device.
>
> Fixes: 4730d2233311 ("irqchip/imx-irqsteer: Add runtime PM support")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/irqchip/irq-imx-irqsteer.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
> index 87b07f517be3..a695ba31db9a 100644
> --- a/drivers/irqchip/irq-imx-irqsteer.c
> +++ b/drivers/irqchip/irq-imx-irqsteer.c
> @@ -276,6 +276,8 @@ static void imx_irqsteer_remove(struct platform_device *pdev)
> struct irqsteer_data *irqsteer_data = platform_get_drvdata(pdev);
> int i;
>
> + pm_runtime_disable(&pdev->dev);
> +
> for (i = 0; i < irqsteer_data->irq_count; i++) {
> if (!irqsteer_data->irq[i])
> break;
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-29 20:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-29 20:16 [PATCH] irqchip: imx-irqsteer: Call pm_runtime_disable() on remove Fabio Estevam
2026-07-29 20:37 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox